From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 774F7C2D0CE for ; Sun, 29 Dec 2019 17:42:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 433A3206DB for ; Sun, 29 Dec 2019 17:42:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577641368; bh=tDD6UcQO//fPfKO1LLIweRfUJgq9pUxd+d+2vc02hPM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=QXLwyFLo9IuWEr0PNAp6PTSOIhS9vZE6Y/X8CWfyuX8h+QhZ0smN3QcXy9g9ZEu8q 7GhZMyeqkcyloFXTaXv09hSqU7Gw1D0xjxfQjfvLCp4jFnKy9p/WkpxLmgNXr7Nym5 UtqWFGPvS8x+/AxdjgppG/Kft12YkEP15qwh51Oo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730357AbfL2Rmr (ORCPT ); Sun, 29 Dec 2019 12:42:47 -0500 Received: from mail.kernel.org ([198.145.29.99]:49128 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730340AbfL2Rml (ORCPT ); Sun, 29 Dec 2019 12:42:41 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 23552207FF; Sun, 29 Dec 2019 17:42:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577641360; bh=tDD6UcQO//fPfKO1LLIweRfUJgq9pUxd+d+2vc02hPM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jL/9efnjOciwcysmVgi4NaPszmB5nbnoW/9A8xjJWMD1vaEmFuxJ6Tuq0I4j9loOP OBPQEOQJMYv7LabGWEPbPeHCxNVqfPdjRaX9jDSOfEgOIGWVXu7v2YZT+WuGkjMpab Gm1ZtH1e6WPTEUf07IFmq5OxPHM0ZabgtjvCaino= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Filipe Manana , Johannes Thumshirn , Josef Bacik , David Sterba Subject: [PATCH 5.4 034/434] btrfs: abort transaction after failed inode updates in create_subvol Date: Sun, 29 Dec 2019 18:21:27 +0100 Message-Id: <20191229172704.299990660@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191229172702.393141737@linuxfoundation.org> References: <20191229172702.393141737@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Josef Bacik commit c7e54b5102bf3614cadb9ca32d7be73bad6cecf0 upstream. We can just abort the transaction here, and in fact do that for every other failure in this function except these two cases. CC: stable@vger.kernel.org # 4.4+ Reviewed-by: Filipe Manana Reviewed-by: Johannes Thumshirn Signed-off-by: Josef Bacik Reviewed-by: David Sterba Signed-off-by: David Sterba Signed-off-by: Greg Kroah-Hartman --- fs/btrfs/ioctl.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -705,11 +705,17 @@ static noinline int create_subvol(struct btrfs_i_size_write(BTRFS_I(dir), dir->i_size + namelen * 2); ret = btrfs_update_inode(trans, root, dir); - BUG_ON(ret); + if (ret) { + btrfs_abort_transaction(trans, ret); + goto fail; + } ret = btrfs_add_root_ref(trans, objectid, root->root_key.objectid, btrfs_ino(BTRFS_I(dir)), index, name, namelen); - BUG_ON(ret); + if (ret) { + btrfs_abort_transaction(trans, ret); + goto fail; + } ret = btrfs_uuid_tree_add(trans, root_item->uuid, BTRFS_UUID_KEY_SUBVOL, objectid);