From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74867C2D0CE for ; Sun, 29 Dec 2019 17:45:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5028A20718 for ; Sun, 29 Dec 2019 17:45:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577641542; bh=dGcSCkEKLA/K0lOLlFsVXGgr732AN7g6bkG+QgG7JQs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=OmJQHEGmtIOTBHmBc9P2be1uBDcqYY8NN3f1wnlJ5MH7rikqpkUkkbYkS5srXUFNa ajBdZFAD/m5sgqwlYrZjWc35KH+UAXxeG+1VtKpnWRjM8Ls4W1DklcTYa9PQTnCZxY R2jvoVLJoOHLN6xJ+boYDiA9Kb7fA4KDeex0aZnI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730560AbfL2Rpl (ORCPT ); Sun, 29 Dec 2019 12:45:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:54780 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730926AbfL2Rpg (ORCPT ); Sun, 29 Dec 2019 12:45:36 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1A5B9206A4; Sun, 29 Dec 2019 17:45:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577641535; bh=dGcSCkEKLA/K0lOLlFsVXGgr732AN7g6bkG+QgG7JQs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hLkheIL+OnrwqlaDwNhyVy/zwYnOocCJ2U9uJAKDOUEb996CTRY4SV9dqBFQzJT27 AswAMi2ERLCA4mOB5Rj2dcXa9Q4ELV+5lzW4wE5WV4JkrqTkhd/1fYLUCyJb/bHr/i j1RqSlLEOvPEANiyrgxlZGQamtZq5PLqsDriq6Q0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Allen Pais , Kalle Valo , Sasha Levin Subject: [PATCH 5.4 067/434] libertas: fix a potential NULL pointer dereference Date: Sun, 29 Dec 2019 18:22:00 +0100 Message-Id: <20191229172706.182992792@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191229172702.393141737@linuxfoundation.org> References: <20191229172702.393141737@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Allen Pais [ Upstream commit 7da413a18583baaf35dd4a8eb414fa410367d7f2 ] alloc_workqueue is not checked for errors and as a result, a potential NULL dereference could occur. Signed-off-by: Allen Pais Signed-off-by: Kalle Valo Signed-off-by: Sasha Levin --- drivers/net/wireless/marvell/libertas/if_sdio.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/wireless/marvell/libertas/if_sdio.c b/drivers/net/wireless/marvell/libertas/if_sdio.c index 242d8845da3f..30f1025ecb9b 100644 --- a/drivers/net/wireless/marvell/libertas/if_sdio.c +++ b/drivers/net/wireless/marvell/libertas/if_sdio.c @@ -1179,6 +1179,10 @@ static int if_sdio_probe(struct sdio_func *func, spin_lock_init(&card->lock); card->workqueue = alloc_workqueue("libertas_sdio", WQ_MEM_RECLAIM, 0); + if (unlikely(!card->workqueue)) { + ret = -ENOMEM; + goto err_queue; + } INIT_WORK(&card->packet_worker, if_sdio_host_to_card_worker); init_waitqueue_head(&card->pwron_waitq); @@ -1230,6 +1234,7 @@ err_activate_card: lbs_remove_card(priv); free: destroy_workqueue(card->workqueue); +err_queue: while (card->packets) { packet = card->packets; card->packets = card->packets->next; -- 2.20.1