From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D936C2D0D3 for ; Mon, 30 Dec 2019 19:15:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DA185206CB for ; Mon, 30 Dec 2019 19:15:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="TrUeJBtY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727689AbfL3TP1 (ORCPT ); Mon, 30 Dec 2019 14:15:27 -0500 Received: from mail-oi1-f196.google.com ([209.85.167.196]:40174 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727612AbfL3TP0 (ORCPT ); Mon, 30 Dec 2019 14:15:26 -0500 Received: by mail-oi1-f196.google.com with SMTP id c77so10926469oib.7 for ; Mon, 30 Dec 2019 11:15:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=c8VNPmQpB/nhZUKa/jEyRPflBQQk4BiG2bU5Mb23sZI=; b=TrUeJBtYQrhGzh9bo/B1sO67yNnIt1G5Zq9WRF6nvkZcUR6pWDDa+fWAGu0DWTCQ58 tzBhNoxl1KdV90x1wXcm/AHv9kB5yLfnupfaa3D+qkb9LQ3CZJGqdf11DZWsGdFwG8FK N+79hxkfhaRxWj4KVx6cNl5Wg6kABBwrGJM7o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=c8VNPmQpB/nhZUKa/jEyRPflBQQk4BiG2bU5Mb23sZI=; b=rl4bNfoQyop+uF/D5AT8jTqtruqKQ0kpZHHrFTVr2s457loV5KEmkuDzmxvCP0Vd7l awVd7ksyVJJrVW5e52omAyM138gYk7wvzxVp0wqBtbHxA7KTCJPW02Ga3pirzs99BBXM bjiEomT+9M3W5FnB04bu8dd90YjBBjX4ZePp+j0RZUcwWZwGTaGCDKIWuazG+TFx/wSR rm3Jb6mq2ByErMfIGj4wZ21k0njKNiwFQTdz1ypC+BWLG/4+Xcb/JmOFzm5c6NrQeu24 8lO5x+oUZ1dZZbOGJ2LLwZCAHB7V53H/+ZgwGTZiP3yz20XXqmE2YWEowO0lVuY+5H+i UZcw== X-Gm-Message-State: APjAAAWU+27slZ6DIaaNC7bnoFZFIPZGzysNALacgRtft76CSd0k4i+X EviCUQCVM54RP2KU49u5CyhBOw== X-Google-Smtp-Source: APXvYqzHMhG2XB4gSSLkVkurcTS/kbf5+0VXeJOTvIqteere+/f7siDcsi2gN/gxmI1SnlIUiZ5MEQ== X-Received: by 2002:aca:4c15:: with SMTP id z21mr282394oia.8.1577733325313; Mon, 30 Dec 2019 11:15:25 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id w8sm15888580ote.80.2019.12.30.11.15.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Dec 2019 11:15:24 -0800 (PST) Date: Mon, 30 Dec 2019 11:15:23 -0800 From: Kees Cook To: KP Singh Cc: Casey Schaufler , open list , bpf , linux-security-module@vger.kernel.org, Alexei Starovoitov , Daniel Borkmann , James Morris , Thomas Garnier , Michael Halcrow , Paul Turner , Brendan Gregg , Jann Horn , Matthew Garrett , Christian Brauner , =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , Florent Revest , Brendan Jackman , Martin KaFai Lau , Song Liu , Yonghong Song , "Serge E. Hallyn" , Mauro Carvalho Chehab , "David S. Miller" , Greg Kroah-Hartman , Nicolas Ferre , Stanislav Fomichev , Quentin Monnet , Andrey Ignatov , Joe Stringer Subject: Re: [PATCH bpf-next v1 00/13] MAC and Audit policy using eBPF (KRSI) Message-ID: <201912301112.A1A63A4@keescook> References: <20191220154208.15895-1-kpsingh@chromium.org> <95036040-6b1c-116c-bd6b-684f00174b4f@schaufler-ca.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 20, 2019 at 06:38:45PM +0100, KP Singh wrote: > Hi Casey, > > Thanks for taking a look! > > On Fri, Dec 20, 2019 at 6:17 PM Casey Schaufler wrote: > > > > On 12/20/2019 7:41 AM, KP Singh wrote: > > > From: KP Singh > > > > > > This patch series is a continuation of the KRSI RFC > > > (https://lore.kernel.org/bpf/20190910115527.5235-1-kpsingh@chromium.org/) > > > > > > # Motivation > > > > > > Google does rich analysis of runtime security data collected from > > > internal Linux deployments (corporate devices and servers) to detect and > > > thwart threats in real-time. Currently, this is done in custom kernel > > > modules but we would like to replace this with something that's upstream > > > and useful to others. > > > > > > The current kernel infrastructure for providing telemetry (Audit, Perf > > > etc.) is disjoint from access enforcement (i.e. LSMs). Augmenting the > > > information provided by audit requires kernel changes to audit, its > > > policy language and user-space components. Furthermore, building a MAC > > > policy based on the newly added telemetry data requires changes to > > > various LSMs and their respective policy languages. > > > > > > This patchset proposes a new stackable and privileged LSM which allows > > > the LSM hooks to be implemented using eBPF. This facilitates a unified > > > and dynamic (not requiring re-compilation of the kernel) audit and MAC > > > policy. > > > > > > # Why an LSM? > > > > > > Linux Security Modules target security behaviours rather than the > > > kernel's API. For example, it's easy to miss out a newly added system > > > call for executing processes (eg. execve, execveat etc.) but the LSM > > > framework ensures that all process executions trigger the relevant hooks > > > irrespective of how the process was executed. > > > > > > Allowing users to implement LSM hooks at runtime also benefits the LSM > > > eco-system by enabling a quick feedback loop from the security community > > > about the kind of behaviours that the LSM Framework should be targeting. > > > > > > # How does it work? > > > > > > The LSM introduces a new eBPF (https://docs.cilium.io/en/v1.6/bpf/) > > > program type, BPF_PROG_TYPE_LSM, which can only be attached to a LSM > > > hook. All LSM hooks are exposed as files in securityfs. Attachment > > > requires CAP_SYS_ADMIN for loading eBPF programs and CAP_MAC_ADMIN for > > > modifying MAC policies. > > > > > > The eBPF programs are passed the same arguments as the LSM hooks and > > > executed in the body of the hook. > > > > This effectively exposes the LSM hooks as external APIs. > > It would mean that we can't change or delete them. That > > would be bad. > > Perhaps this should have been clearer, we *do not* want to make LSM hooks > a stable API and expect the eBPF programs to adapt when such changes occur. > > Based on our comparison with the previous approach, this still ends up > being a better trade-off (w.r.t. maintenance) when compared to adding > specific helpers or verifier logic for each new hook or field that > needs to be exposed. Given the discussion around tracing and stable ABI at the last kernel summit, Linus's mandate is mainly around "every day users" and not around these system-builder-sensitive cases where everyone has a strong expectation to rebuild their policy when the kernel changes. i.e. it's not "powertop", which was Linus's example of "and then everyone running Fedora breaks". So, while I know we've tried in the past to follow the letter of the law, it seems Linus really expects this only to be followed when it will have "real world" impact on unsuspecting end users. Obviously James Morris has the final say here, but as I understand it, it is fine to expose these here for the same reasons it's fine to expose the (ever changing) tracepoints and BPF hooks. -Kees -- Kees Cook