From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CEEDC2D0C2 for ; Tue, 31 Dec 2019 08:21:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0925B206DA for ; Tue, 31 Dec 2019 08:21:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726442AbfLaIVI (ORCPT ); Tue, 31 Dec 2019 03:21:08 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:43858 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725497AbfLaIVH (ORCPT ); Tue, 31 Dec 2019 03:21:07 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 9B55F1C2605; Tue, 31 Dec 2019 09:21:05 +0100 (CET) Date: Tue, 31 Dec 2019 09:21:04 +0100 From: Pavel Machek To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, kbuild test robot , Lianbo Jiang , Borislav Petkov , bhe@redhat.com, d.hatayama@fujitsu.com, dhowells@redhat.com, dyoung@redhat.com, ebiederm@xmission.com, horms@verge.net.au, "H. Peter Anvin" , Ingo Molnar , =?iso-8859-1?Q?J=FCrgen?= Gross , kexec@lists.infradead.org, Thomas Gleixner , Tom Lendacky , vgoyal@redhat.com, x86-ml , Sasha Levin Subject: Re: [PATCH 4.19 159/219] x86/crash: Add a forward declaration of struct kimage Message-ID: <20191231082104.GA18654@amd> References: <20191229162508.458551679@linuxfoundation.org> <20191229162532.764428471@linuxfoundation.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="mYCpIKhGyMATD0i+" Content-Disposition: inline In-Reply-To: <20191229162532.764428471@linuxfoundation.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --mYCpIKhGyMATD0i+ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun 2019-12-29 18:19:21, Greg Kroah-Hartman wrote: > From: Lianbo Jiang >=20 > [ Upstream commit 112eee5d06007dae561f14458bde7f2a4879ef4e ] >=20 > Add a forward declaration of struct kimage to the crash.h header because > future changes will invoke a crash-specific function from the realmode > init path and the compiler will complain otherwise like this: >=20 > In file included from arch/x86/realmode/init.c:11: > ./arch/x86/include/asm/crash.h:5:32: warning: =E2=80=98struct kimage=E2= =80=99 declared inside\ This is not needed in 4.19-stable, as 6f599d84231fd27e42f4ca2a786a6641e8cddf00 is not being backported there. (But is simple enough not to do harm). Best regards, Pavel > @@ -2,6 +2,8 @@ > #ifndef _ASM_X86_CRASH_H > #define _ASM_X86_CRASH_H > =20 > +struct kimage; > + > int crash_load_segments(struct kimage *image); > int crash_copy_backup_region(struct kimage *image); > int crash_setup_memmap_entries(struct kimage *image, --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --mYCpIKhGyMATD0i+ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl4LBPAACgkQMOfwapXb+vI1YwCgkt7BeSAXQG8Y9wgvq32qdefL FEMAnAnUXf/SFS6l9L7ov4sP9dCPQc4D =WrFA -----END PGP SIGNATURE----- --mYCpIKhGyMATD0i+--