From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1428001AbdDWIgq (ORCPT ); Sun, 23 Apr 2017 04:36:46 -0400 Received: from mga02.intel.com ([134.134.136.20]:33060 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1427726AbdDWIgg (ORCPT ); Sun, 23 Apr 2017 04:36:36 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,238,1488873600"; d="scan'208";a="1159824718" Subject: Re: [PATCH v6 0/7] perf report: Show branch type To: Jiri Olsa Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com, linuxppc-dev@lists.ozlabs.org References: <1492690075-17243-1-git-send-email-yao.jin@linux.intel.com> <20170420093656.GA28272@krava> From: "Jin, Yao" Message-ID: <201ae5e4-6cbe-532a-8377-55649349bd83@linux.intel.com> Date: Sun, 23 Apr 2017 16:36:30 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <20170420093656.GA28272@krava> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/20/2017 5:36 PM, Jiri Olsa wrote: > On Thu, Apr 20, 2017 at 08:07:48PM +0800, Jin Yao wrote: >> v6: >> Update according to the review comments from >> Jiri Olsa . Major modifications are: >> >> 1. Move that multiline conditional code inside {} brackets. >> >> 2. Move branch_type_stat_display() from builtin-report.c to >> branch.c. Move branch_type_str() from callchain.c to >> branch.c. >> >> 3. Keep the original branch info display order, that is: >> predicted, abort, cycles, iterations > for the tools part > > Acked-by: Jiri Olsa > > thanks, > jirka Thanks so much! Is the kernel part OK? Thanks Jin Yao