From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 216C4C2D0DC for ; Wed, 1 Jan 2020 14:52:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A51902072C for ; Wed, 1 Jan 2020 14:52:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ThSsbgXR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727180AbgAAOwz (ORCPT ); Wed, 1 Jan 2020 09:52:55 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:38836 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725872AbgAAOwz (ORCPT ); Wed, 1 Jan 2020 09:52:55 -0500 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 53F4B516; Wed, 1 Jan 2020 15:52:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1577890372; bh=Rk0K6LoFLxyI8BtA7Uh6mo1W3SlxSPy+7j4y/shJEn0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ThSsbgXR31D2hjqfzLrK8ukO7yklGCAxOK3T0Kg1IEDNXqQrxCqYshaHKs6ppwuYd VdDeu3jNG9N8HT7qHpdyyUfbR5eurnQbR3fiHC8SepYstUtT8iOvHhA3n/1+rMXd5W dv/xS9QDQ7XLYKIIAfOn2VZkDHqFwLDAiwiGTfFc= Date: Wed, 1 Jan 2020 16:52:42 +0200 From: Laurent Pinchart To: Julia Lawall Cc: Andrzej Hajda , kernel-janitors@vger.kernel.org, Neil Armstrong , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 15/16] drm: bridge: dw-hdmi: constify copied structure Message-ID: <20200101145242.GA4855@pendragon.ideasonboard.com> References: <1577864614-5543-1-git-send-email-Julia.Lawall@inria.fr> <1577864614-5543-16-git-send-email-Julia.Lawall@inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1577864614-5543-16-git-send-email-Julia.Lawall@inria.fr> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Julia, Thank you for the patch. On Wed, Jan 01, 2020 at 08:43:33AM +0100, Julia Lawall wrote: > The dw_hdmi_hw structure is only copied into another structure, > so make it const. > > The opportunity for this change was found using Coccinelle. > > Signed-off-by: Julia Lawall Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c > index 2b7539701b42..dd56996fe9c7 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c > @@ -291,7 +291,7 @@ static irqreturn_t snd_dw_hdmi_irq(int irq, void *data) > return IRQ_HANDLED; > } > > -static struct snd_pcm_hardware dw_hdmi_hw = { > +static const struct snd_pcm_hardware dw_hdmi_hw = { > .info = SNDRV_PCM_INFO_INTERLEAVED | > SNDRV_PCM_INFO_BLOCK_TRANSFER | > SNDRV_PCM_INFO_MMAP | -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Date: Wed, 01 Jan 2020 14:52:42 +0000 Subject: Re: [PATCH 15/16] drm: bridge: dw-hdmi: constify copied structure Message-Id: <20200101145242.GA4855@pendragon.ideasonboard.com> List-Id: References: <1577864614-5543-1-git-send-email-Julia.Lawall@inria.fr> <1577864614-5543-16-git-send-email-Julia.Lawall@inria.fr> In-Reply-To: <1577864614-5543-16-git-send-email-Julia.Lawall@inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: Jernej Skrabec , Jonas Karlman , David Airlie , Neil Armstrong , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Hi Julia, Thank you for the patch. On Wed, Jan 01, 2020 at 08:43:33AM +0100, Julia Lawall wrote: > The dw_hdmi_hw structure is only copied into another structure, > so make it const. > > The opportunity for this change was found using Coccinelle. > > Signed-off-by: Julia Lawall Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c > index 2b7539701b42..dd56996fe9c7 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c > @@ -291,7 +291,7 @@ static irqreturn_t snd_dw_hdmi_irq(int irq, void *data) > return IRQ_HANDLED; > } > > -static struct snd_pcm_hardware dw_hdmi_hw = { > +static const struct snd_pcm_hardware dw_hdmi_hw = { > .info = SNDRV_PCM_INFO_INTERLEAVED | > SNDRV_PCM_INFO_BLOCK_TRANSFER | > SNDRV_PCM_INFO_MMAP | -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 960C7C2D0DF for ; Wed, 1 Jan 2020 14:52:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5173F2072C for ; Wed, 1 Jan 2020 14:52:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ThSsbgXR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5173F2072C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 58C1389BA3; Wed, 1 Jan 2020 14:52:57 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id B3A6E89BA3 for ; Wed, 1 Jan 2020 14:52:55 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 53F4B516; Wed, 1 Jan 2020 15:52:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1577890372; bh=Rk0K6LoFLxyI8BtA7Uh6mo1W3SlxSPy+7j4y/shJEn0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ThSsbgXR31D2hjqfzLrK8ukO7yklGCAxOK3T0Kg1IEDNXqQrxCqYshaHKs6ppwuYd VdDeu3jNG9N8HT7qHpdyyUfbR5eurnQbR3fiHC8SepYstUtT8iOvHhA3n/1+rMXd5W dv/xS9QDQ7XLYKIIAfOn2VZkDHqFwLDAiwiGTfFc= Date: Wed, 1 Jan 2020 16:52:42 +0200 From: Laurent Pinchart To: Julia Lawall Subject: Re: [PATCH 15/16] drm: bridge: dw-hdmi: constify copied structure Message-ID: <20200101145242.GA4855@pendragon.ideasonboard.com> References: <1577864614-5543-1-git-send-email-Julia.Lawall@inria.fr> <1577864614-5543-16-git-send-email-Julia.Lawall@inria.fr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1577864614-5543-16-git-send-email-Julia.Lawall@inria.fr> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , Jonas Karlman , David Airlie , Neil Armstrong , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Julia, Thank you for the patch. On Wed, Jan 01, 2020 at 08:43:33AM +0100, Julia Lawall wrote: > The dw_hdmi_hw structure is only copied into another structure, > so make it const. > > The opportunity for this change was found using Coccinelle. > > Signed-off-by: Julia Lawall Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c > index 2b7539701b42..dd56996fe9c7 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c > @@ -291,7 +291,7 @@ static irqreturn_t snd_dw_hdmi_irq(int irq, void *data) > return IRQ_HANDLED; > } > > -static struct snd_pcm_hardware dw_hdmi_hw = { > +static const struct snd_pcm_hardware dw_hdmi_hw = { > .info = SNDRV_PCM_INFO_INTERLEAVED | > SNDRV_PCM_INFO_BLOCK_TRANSFER | > SNDRV_PCM_INFO_MMAP | -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel