From: Wei Liu <wl@xen.org>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "Stefano Stabellini" <sstabellini@kernel.org>,
"Julien Grall" <julien@xen.org>, "Wei Liu" <wl@xen.org>,
"Jan Beulich" <JBeulich@suse.com>,
Xen-devel <xen-devel@lists.xenproject.org>,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH] xen/efi: Drop infinite loops and use unreachable()/noreturn
Date: Thu, 2 Jan 2020 16:46:07 +0000 [thread overview]
Message-ID: <20200102164607.ichqzymxpwnb4pno@debian> (raw)
In-Reply-To: <20200102135624.30787-1-andrew.cooper3@citrix.com>
On Thu, Jan 02, 2020 at 01:56:24PM +0000, Andrew Cooper wrote:
> No functional change.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Wei Liu <wl@xen.org>
Preferably with one additional adjustment below.
>
> static void __init efi_arch_cfg_file_early(EFI_FILE_HANDLE dir_handle, char *section)
> diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c
> index 3f1c330afe..1b7dc16056 100644
> --- a/xen/common/efi/boot.c
> +++ b/xen/common/efi/boot.c
> @@ -1402,7 +1402,6 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
> efi_exit_boot(ImageHandle, SystemTable);
>
efi_arch_post_exit_boot(); /* never returns */
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-01-02 16:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-02 13:56 [Xen-devel] [PATCH] xen/efi: Drop infinite loops and use unreachable()/noreturn Andrew Cooper
2020-01-02 16:46 ` Wei Liu [this message]
2020-01-03 13:24 ` Jan Beulich
2020-01-03 17:14 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200102164607.ichqzymxpwnb4pno@debian \
--to=wl@xen.org \
--cc=JBeulich@suse.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=julien@xen.org \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.