From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7F84C3276C for ; Thu, 2 Jan 2020 22:24:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B29DD222C3 for ; Thu, 2 Jan 2020 22:24:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578003886; bh=Bm30xWwA5ZXQd66HwXCJ4MHYY/5Lva7ZuZAueK2m5QE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=L9dqzRCaWEMruD71EQKXPXk1KZJloxLS/dIbzcdRycsaOWttqtVFtdyoQJtTOW7G/ 6vLj04+WkbDorC8sP8TV3RaLJm26uBDFaHMYC2HkJIeWxsQeCLeb2rLOh9rPjFEwi+ 6xRe6Ig8MQP5kI6/b06JzpYifxAlTfzjbJiLjYmg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729010AbgABWYq (ORCPT ); Thu, 2 Jan 2020 17:24:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:48946 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729292AbgABWYk (ORCPT ); Thu, 2 Jan 2020 17:24:40 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 71FC3222C3; Thu, 2 Jan 2020 22:24:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578003879; bh=Bm30xWwA5ZXQd66HwXCJ4MHYY/5Lva7ZuZAueK2m5QE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UcBd86+hiNtMeJV+RlzG8l+nS38oPLKBKQ8APnKV0bmk5yuQLmyWEViv4rpCE6GiT LXxwpWwbJsG6QzyWoXULRNy6+4MH2+0svZ3xKBPdxYS25vl1SZ7IabHceYzO4qvAPw wbp2RpdZv8ZxxFh83wagfeHmaAXQgGdfXofas69U= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Maurizio Lombardi , Douglas Gilbert , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 4.14 38/91] scsi: scsi_debug: num_tgts must be >= 0 Date: Thu, 2 Jan 2020 23:07:20 +0100 Message-Id: <20200102220433.340097844@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200102220356.856162165@linuxfoundation.org> References: <20200102220356.856162165@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Maurizio Lombardi [ Upstream commit aa5334c4f3014940f11bf876e919c956abef4089 ] Passing the parameter "num_tgts=-1" will start an infinite loop that exhausts the system memory Link: https://lore.kernel.org/r/20191115163727.24626-1-mlombard@redhat.com Signed-off-by: Maurizio Lombardi Acked-by: Douglas Gilbert Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/scsi_debug.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c index 92bc5b2d24ae..ac936b5ca74e 100644 --- a/drivers/scsi/scsi_debug.c +++ b/drivers/scsi/scsi_debug.c @@ -4960,6 +4960,11 @@ static int __init scsi_debug_init(void) return -EINVAL; } + if (sdebug_num_tgts < 0) { + pr_err("num_tgts must be >= 0\n"); + return -EINVAL; + } + if (sdebug_guard > 1) { pr_err("guard must be 0 or 1\n"); return -EINVAL; -- 2.20.1