From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC3D1C32767 for ; Fri, 3 Jan 2020 13:35:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8D74F222C4 for ; Fri, 3 Jan 2020 13:35:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="RZnmy0Rk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727587AbgACNfc (ORCPT ); Fri, 3 Jan 2020 08:35:32 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:46510 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727508AbgACNfc (ORCPT ); Fri, 3 Jan 2020 08:35:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=+G47s2y2Sg2fK9dxyGmLkDMSg3BWEgjGRsQXMWhTH40=; b=RZnmy0RktlxTOiaci5ujm5SkgM sj9PqJ5OSEpfxJWoVYB36/1Pl6K0jTQm3po3dG6SDD8Wfw9xjvt9SjWyCEuP5swCXyGVEtTEwFnUY FZ4JorisTE3hwC/tQNR9wyWBUIZYUMnkwi/R/PVkF7QxC5R6JPCQGGwhmmsAQMOmAZmE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1inN6p-0006JX-TD; Fri, 03 Jan 2020 14:35:23 +0100 Date: Fri, 3 Jan 2020 14:35:23 +0100 From: Andrew Lunn To: Russell King - ARM Linux admin Cc: "Madalin Bucur (OSS)" , "devicetree@vger.kernel.org" , "davem@davemloft.net" , "netdev@vger.kernel.org" , "f.fainelli@gmail.com" , "hkallweit1@gmail.com" , "shawnguo@kernel.org" Subject: Re: [PATCH 1/6] net: phy: add interface modes for XFI, SFI Message-ID: <20200103133523.GA22988@lunn.ch> References: <1576768881-24971-1-git-send-email-madalin.bucur@oss.nxp.com> <1576768881-24971-2-git-send-email-madalin.bucur@oss.nxp.com> <20191219172834.GC25745@shell.armlinux.org.uk> <20191223120730.GO25745@shell.armlinux.org.uk> <20200103092718.GB25745@shell.armlinux.org.uk> <20200103094204.GA18808@shell.armlinux.org.uk> <20200103125310.GE25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200103125310.GE25745@shell.armlinux.org.uk> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > What I might be willing to accept is if we were to introduce > XFI_10GBASER, XFI_10GBASEW, XFI_10GFC, XFI_G709 and their SFI > counterparts - but, there would remain one HUGE problem with that, > which is the total lack of specification of the board characteristics > required to achieve XFI electrical compliance. Hi Russell The four RGMII variants are precedents for mixing protocol and 'electrical' properties, in terms of clock delays. But having four RGMII variants has been a pain point, implementations getting it wrong, etc. So i would avoid mixing them in one property. I would prefer we keep phy-mode as a protocol property, and we define additional DT properties to describe the electrical parts of the SERDES interface. Madalin, what electrical properties do you actually need in DT? I guess you need to know if it is using XFI or SFI. But that is only the start. Do you want to place all the other properties in DT as well, or are they in a board specific firmware blobs, and you just need to know if you should use the XFI blob or the SFI blob? We can probably define a vendor neutral DT property for XFI vs SFI, but i expect all the other electrical properties are going to be vendor specific. Andrew