All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: linux-fscrypt@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fscrypt: include <linux/ioctl.h> in UAPI header
Date: Fri, 3 Jan 2020 09:02:53 -0800	[thread overview]
Message-ID: <20200103170253.GK19521@gmail.com> (raw)
In-Reply-To: <20191219185624.21251-1-ebiggers@kernel.org>

On Thu, Dec 19, 2019 at 10:56:24AM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
> 
> <linux/fscrypt.h> defines ioctl numbers using the macros like _IORW()
> which are defined in <linux/ioctl.h>, so <linux/ioctl.h> should be
> included as a prerequisite, like it is in many other kernel headers.
> 
> In practice this doesn't really matter since anyone referencing these
> ioctl numbers will almost certainly include <sys/ioctl.h> too in order
> to actually call ioctl().  But we might as well fix this.
> 
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
>  include/uapi/linux/fscrypt.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/uapi/linux/fscrypt.h b/include/uapi/linux/fscrypt.h
> index d5112a24e8b9f..0d8a6f47711c3 100644
> --- a/include/uapi/linux/fscrypt.h
> +++ b/include/uapi/linux/fscrypt.h
> @@ -8,6 +8,7 @@
>  #ifndef _UAPI_LINUX_FSCRYPT_H
>  #define _UAPI_LINUX_FSCRYPT_H
>  
> +#include <linux/ioctl.h>
>  #include <linux/types.h>
>  
>  /* Encryption policy flags */
> -- 
> 2.24.1.735.g03f4e72817-goog
> 

Applied to fscrypt.git#master for 5.6.

(Fixed a typo in the commit message -- "_IORW()" should be "_IOWR()".)

- Eric

      reply	other threads:[~2020-01-03 17:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-19 18:56 [PATCH] fscrypt: include <linux/ioctl.h> in UAPI header Eric Biggers
2020-01-03 17:02 ` Eric Biggers [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200103170253.GK19521@gmail.com \
    --to=ebiggers@kernel.org \
    --cc=linux-fscrypt@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.