* [PATCH] fscrypt: include <linux/ioctl.h> in UAPI header
@ 2019-12-19 18:56 Eric Biggers
2020-01-03 17:02 ` Eric Biggers
0 siblings, 1 reply; 2+ messages in thread
From: Eric Biggers @ 2019-12-19 18:56 UTC (permalink / raw)
To: linux-fscrypt; +Cc: linux-fsdevel
From: Eric Biggers <ebiggers@google.com>
<linux/fscrypt.h> defines ioctl numbers using the macros like _IORW()
which are defined in <linux/ioctl.h>, so <linux/ioctl.h> should be
included as a prerequisite, like it is in many other kernel headers.
In practice this doesn't really matter since anyone referencing these
ioctl numbers will almost certainly include <sys/ioctl.h> too in order
to actually call ioctl(). But we might as well fix this.
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
include/uapi/linux/fscrypt.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/uapi/linux/fscrypt.h b/include/uapi/linux/fscrypt.h
index d5112a24e8b9f..0d8a6f47711c3 100644
--- a/include/uapi/linux/fscrypt.h
+++ b/include/uapi/linux/fscrypt.h
@@ -8,6 +8,7 @@
#ifndef _UAPI_LINUX_FSCRYPT_H
#define _UAPI_LINUX_FSCRYPT_H
+#include <linux/ioctl.h>
#include <linux/types.h>
/* Encryption policy flags */
--
2.24.1.735.g03f4e72817-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fscrypt: include <linux/ioctl.h> in UAPI header
2019-12-19 18:56 [PATCH] fscrypt: include <linux/ioctl.h> in UAPI header Eric Biggers
@ 2020-01-03 17:02 ` Eric Biggers
0 siblings, 0 replies; 2+ messages in thread
From: Eric Biggers @ 2020-01-03 17:02 UTC (permalink / raw)
To: linux-fscrypt; +Cc: linux-fsdevel
On Thu, Dec 19, 2019 at 10:56:24AM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> <linux/fscrypt.h> defines ioctl numbers using the macros like _IORW()
> which are defined in <linux/ioctl.h>, so <linux/ioctl.h> should be
> included as a prerequisite, like it is in many other kernel headers.
>
> In practice this doesn't really matter since anyone referencing these
> ioctl numbers will almost certainly include <sys/ioctl.h> too in order
> to actually call ioctl(). But we might as well fix this.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> include/uapi/linux/fscrypt.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/uapi/linux/fscrypt.h b/include/uapi/linux/fscrypt.h
> index d5112a24e8b9f..0d8a6f47711c3 100644
> --- a/include/uapi/linux/fscrypt.h
> +++ b/include/uapi/linux/fscrypt.h
> @@ -8,6 +8,7 @@
> #ifndef _UAPI_LINUX_FSCRYPT_H
> #define _UAPI_LINUX_FSCRYPT_H
>
> +#include <linux/ioctl.h>
> #include <linux/types.h>
>
> /* Encryption policy flags */
> --
> 2.24.1.735.g03f4e72817-goog
>
Applied to fscrypt.git#master for 5.6.
(Fixed a typo in the commit message -- "_IORW()" should be "_IOWR()".)
- Eric
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-03 17:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-19 18:56 [PATCH] fscrypt: include <linux/ioctl.h> in UAPI header Eric Biggers
2020-01-03 17:02 ` Eric Biggers
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.