From: Andrew Lunn <andrew@lunn.ch>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Vladimir Oltean <olteanv@gmail.com>,
Matthew Wilcox <willy@infradead.org>,
yu kuai <yukuai3@huawei.com>,
klassert@kernel.org, "David S. Miller" <davem@davemloft.net>,
Heiner Kallweit <hkallweit1@gmail.com>,
Jakub Kicinski <jakub.kicinski@netronome.com>,
hslester96@gmail.com, mst@redhat.com, yang.wei9@zte.com.cn,
netdev <netdev@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
yi.zhang@huawei.com, zhengbin13@huawei.com
Subject: Re: [PATCH] net: 3com: 3c59x: remove set but not used variable 'mii_reg1'
Date: Fri, 3 Jan 2020 20:37:58 +0100 [thread overview]
Message-ID: <20200103193758.GO1397@lunn.ch> (raw)
In-Reply-To: <b4697457-51d2-c987-4138-b4b2b92e391d@gmail.com>
> And since more reviewers are on the same boat, the fix should probably
> look to eliminate the warning by doing something like:
>
> (void)mdio_read(dev, vp->phys[0], MII_BMSR);
Yes, this is the safe option.
Andrew
next prev parent reply other threads:[~2020-01-03 19:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-03 12:19 [PATCH] net: 3com: 3c59x: remove set but not used variable 'mii_reg1' yu kuai
2020-01-03 14:46 ` Matthew Wilcox
2020-01-03 14:59 ` Michal Kubecek
2020-01-03 17:53 ` Andrew Lunn
2020-01-03 18:17 ` Michal Kubecek
2020-01-03 19:13 ` Vladimir Oltean
2020-01-03 19:17 ` Florian Fainelli
2020-01-03 19:37 ` Andrew Lunn [this message]
[not found] ` <CAP8WD_a6QJNz2mUpz_eCaNReoZKVAdL0TpoF-m+gA4VPWRrrMg@mail.gmail.com>
2020-01-03 20:03 ` tedheadster
2020-01-06 12:48 ` yukuai (C)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200103193758.GO1397@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=hslester96@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=klassert@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=willy@infradead.org \
--cc=yang.wei9@zte.com.cn \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.