From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 131C8C32770 for ; Sat, 4 Jan 2020 17:52:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EB02121734 for ; Sat, 4 Jan 2020 17:52:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726099AbgADRwV (ORCPT ); Sat, 4 Jan 2020 12:52:21 -0500 Received: from asavdk3.altibox.net ([109.247.116.14]:51958 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726083AbgADRwV (ORCPT ); Sat, 4 Jan 2020 12:52:21 -0500 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 439A420034; Sat, 4 Jan 2020 18:52:17 +0100 (CET) Date: Sat, 4 Jan 2020 18:52:15 +0100 From: Sam Ravnborg To: Linus Walleij Cc: devicetree@vger.kernel.org, Stephan Gerhold , dri-devel@lists.freedesktop.org, Sean Paul , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] drm/panel: Add DT bindings for Novatek NT35510-based panels Message-ID: <20200104175215.GA19679@ravnborg.org> References: <20191225115610.14518-1-linus.walleij@linaro.org> <20200104172717.GB8724@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200104172717.GB8724@ravnborg.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=eMA9ckh1 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=j8Cu_9a8AAAA:8 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=gEfo2CItAAAA:8 a=e5mUnYsNAAAA:8 a=fdb9Mel2xOjeGKR8vtwA:9 a=CjuIK1q_8ugA:10 a=A2jcf3dkIZPIRbEE90CI:22 a=AjGcO6oz07-iQ99wixmX:22 a=cvBusfyB2V15izCimMoJ:22 a=sptkURWiP4Gy88Gu7hUp:22 a=Vxmtnl_E_bksehYqCbjh:22 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Linus On Sat, Jan 04, 2020 at 06:27:17PM +0100, Sam Ravnborg wrote: > Hi Linus. > > On Wed, Dec 25, 2019 at 12:56:09PM +0100, Linus Walleij wrote: > > This adds device tree bindings for the Novatek NT35510-based > > family of panels. Since several such panels are in existence > > we define bindings common for all, and define the compatible > > string for one certain panel (Hydis HVA40WV1). Reading this once more make me think that the right way to do this is to have two compatible's. enum - novatek,nt35510 - hydis,hva40wv1 So there shall be a match for both. Then we have explicit documented that this is the combination of a specific controller and a specific panel. Sam > > > > As other panels are discovered and investigated, we can add > > more compatibles to the binding. > > > > Cc: Stephan Gerhold > > Cc: devicetree@vger.kernel.org > > Signed-off-by: Linus Walleij > > --- > > .../display/panel/novatek-nt35510.yaml | 53 +++++++++++++++++++ > > 1 file changed, 53 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/panel/novatek-nt35510.yaml > > > > diff --git a/Documentation/devicetree/bindings/display/panel/novatek-nt35510.yaml b/Documentation/devicetree/bindings/display/panel/novatek-nt35510.yaml > > new file mode 100644 > > index 000000000000..a4a6b5adf15b > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/panel/novatek-nt35510.yaml > > @@ -0,0 +1,53 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/panel/novatek-nt35510.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Novatek NT35510-based display panels > > + > > +maintainers: > > + - Linus Walleij > > + > > +allOf: > > + - $ref: panel-common.yaml# > > + > > +properties: > > + compatible: > > + const: hydis,hva40wv1 > compatible fail to match filename - which is common practice. > And hydis is not a known vendor-prefix. > > > > + description: This indicates the panel manufacturer of the panel > > + that is in turn using the NT35510 panel driver. The compatible > > + string determines how the NT35510 panel driver shall be configured > > + to work with the indicated panel. > The description is just a general description of what compatible is used > for. > Please drop it as it does not provide anything specific for the panel. > > Sam > > > + reg: true > > + reset-gpios: true > > + vdd-supply: > > + description: regulator that supplies the vdd voltage > > + vddi-supply: > > + description: regulator that supplies the vddi voltage > > + backlight: true > > + > > +required: > > + - compatible > > + - reg > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include > > + > > + dsi@a0351000 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + panel { > > + compatible = "hydis,hva40wv1"; > > + reg = <0>; > > + vdd-supply = <&ab8500_ldo_aux4_reg>; > > + vddi-supply = <&ab8500_ldo_aux6_reg>; > > + reset-gpios = <&gpio4 11 GPIO_ACTIVE_LOW>; > > + backlight = <&gpio_bl>; > > + }; > > + }; > > + > > +... > > -- > > 2.21.0 > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86C0EC2D0C2 for ; Sat, 4 Jan 2020 17:52:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 60D4921734 for ; Sat, 4 Jan 2020 17:52:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="n0qYQO/9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 60D4921734 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ju0zcjMFJeEsJ6EBj3QP3L/8M4LKC+y0dBgyZP4YZ/0=; b=n0qYQO/9RMB2cF 44YLUmXt2KvlwuT4K0k4xN7C/H55cHaj4czgbRlut4tmCboddthdawuZHzbyxfRfHy19+lzbcTuUX m7TnSHJB+nB14LSJSGDOcRQAXMqLG0sbPvqtWLq0N9xFNRBi/NpMyxIFLNRtYawoTUjVLMj/XU/Yd nW0KUK7EcqgH5/FYC1TmWdNFvLzV+x3EjYNcl4r+V6JENwma76xoqhtyXlMBuMa9CKJbQwb0SiBeQ ibZ5SjZyY7EolrHGcAh5NOPeKmgRaQp5dRrFcVPnHOLIlcglq3stxduw1RCcb3yrWPDCOSiV+LQYw 9WFTWzBLdPcloL8t5mlQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1innb6-0003Kc-9v; Sat, 04 Jan 2020 17:52:24 +0000 Received: from asavdk3.altibox.net ([109.247.116.14]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1innb3-0003K4-4V for linux-arm-kernel@lists.infradead.org; Sat, 04 Jan 2020 17:52:23 +0000 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 439A420034; Sat, 4 Jan 2020 18:52:17 +0100 (CET) Date: Sat, 4 Jan 2020 18:52:15 +0100 From: Sam Ravnborg To: Linus Walleij Subject: Re: [PATCH 1/2] drm/panel: Add DT bindings for Novatek NT35510-based panels Message-ID: <20200104175215.GA19679@ravnborg.org> References: <20191225115610.14518-1-linus.walleij@linaro.org> <20200104172717.GB8724@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200104172717.GB8724@ravnborg.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=eMA9ckh1 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=j8Cu_9a8AAAA:8 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=gEfo2CItAAAA:8 a=e5mUnYsNAAAA:8 a=fdb9Mel2xOjeGKR8vtwA:9 a=CjuIK1q_8ugA:10 a=A2jcf3dkIZPIRbEE90CI:22 a=AjGcO6oz07-iQ99wixmX:22 a=cvBusfyB2V15izCimMoJ:22 a=sptkURWiP4Gy88Gu7hUp:22 a=Vxmtnl_E_bksehYqCbjh:22 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200104_095221_540864_07CBDC42 X-CRM114-Status: GOOD ( 25.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Sean Paul , dri-devel@lists.freedesktop.org, Stephan Gerhold Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Linus On Sat, Jan 04, 2020 at 06:27:17PM +0100, Sam Ravnborg wrote: > Hi Linus. > > On Wed, Dec 25, 2019 at 12:56:09PM +0100, Linus Walleij wrote: > > This adds device tree bindings for the Novatek NT35510-based > > family of panels. Since several such panels are in existence > > we define bindings common for all, and define the compatible > > string for one certain panel (Hydis HVA40WV1). Reading this once more make me think that the right way to do this is to have two compatible's. enum - novatek,nt35510 - hydis,hva40wv1 So there shall be a match for both. Then we have explicit documented that this is the combination of a specific controller and a specific panel. Sam > > > > As other panels are discovered and investigated, we can add > > more compatibles to the binding. > > > > Cc: Stephan Gerhold > > Cc: devicetree@vger.kernel.org > > Signed-off-by: Linus Walleij > > --- > > .../display/panel/novatek-nt35510.yaml | 53 +++++++++++++++++++ > > 1 file changed, 53 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/panel/novatek-nt35510.yaml > > > > diff --git a/Documentation/devicetree/bindings/display/panel/novatek-nt35510.yaml b/Documentation/devicetree/bindings/display/panel/novatek-nt35510.yaml > > new file mode 100644 > > index 000000000000..a4a6b5adf15b > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/panel/novatek-nt35510.yaml > > @@ -0,0 +1,53 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/panel/novatek-nt35510.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Novatek NT35510-based display panels > > + > > +maintainers: > > + - Linus Walleij > > + > > +allOf: > > + - $ref: panel-common.yaml# > > + > > +properties: > > + compatible: > > + const: hydis,hva40wv1 > compatible fail to match filename - which is common practice. > And hydis is not a known vendor-prefix. > > > > + description: This indicates the panel manufacturer of the panel > > + that is in turn using the NT35510 panel driver. The compatible > > + string determines how the NT35510 panel driver shall be configured > > + to work with the indicated panel. > The description is just a general description of what compatible is used > for. > Please drop it as it does not provide anything specific for the panel. > > Sam > > > + reg: true > > + reset-gpios: true > > + vdd-supply: > > + description: regulator that supplies the vdd voltage > > + vddi-supply: > > + description: regulator that supplies the vddi voltage > > + backlight: true > > + > > +required: > > + - compatible > > + - reg > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include > > + > > + dsi@a0351000 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + panel { > > + compatible = "hydis,hva40wv1"; > > + reg = <0>; > > + vdd-supply = <&ab8500_ldo_aux4_reg>; > > + vddi-supply = <&ab8500_ldo_aux6_reg>; > > + reset-gpios = <&gpio4 11 GPIO_ACTIVE_LOW>; > > + backlight = <&gpio_bl>; > > + }; > > + }; > > + > > +... > > -- > > 2.21.0 > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E545BC2D0C2 for ; Sat, 4 Jan 2020 17:52:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B553721734 for ; Sat, 4 Jan 2020 17:52:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B553721734 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 14B206E027; Sat, 4 Jan 2020 17:52:20 +0000 (UTC) Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 40DC56E027 for ; Sat, 4 Jan 2020 17:52:19 +0000 (UTC) Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 439A420034; Sat, 4 Jan 2020 18:52:17 +0100 (CET) Date: Sat, 4 Jan 2020 18:52:15 +0100 From: Sam Ravnborg To: Linus Walleij Subject: Re: [PATCH 1/2] drm/panel: Add DT bindings for Novatek NT35510-based panels Message-ID: <20200104175215.GA19679@ravnborg.org> References: <20191225115610.14518-1-linus.walleij@linaro.org> <20200104172717.GB8724@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200104172717.GB8724@ravnborg.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=eMA9ckh1 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=j8Cu_9a8AAAA:8 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=gEfo2CItAAAA:8 a=e5mUnYsNAAAA:8 a=fdb9Mel2xOjeGKR8vtwA:9 a=CjuIK1q_8ugA:10 a=A2jcf3dkIZPIRbEE90CI:22 a=AjGcO6oz07-iQ99wixmX:22 a=cvBusfyB2V15izCimMoJ:22 a=sptkURWiP4Gy88Gu7hUp:22 a=Vxmtnl_E_bksehYqCbjh:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Sean Paul , dri-devel@lists.freedesktop.org, Stephan Gerhold Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Linus On Sat, Jan 04, 2020 at 06:27:17PM +0100, Sam Ravnborg wrote: > Hi Linus. > > On Wed, Dec 25, 2019 at 12:56:09PM +0100, Linus Walleij wrote: > > This adds device tree bindings for the Novatek NT35510-based > > family of panels. Since several such panels are in existence > > we define bindings common for all, and define the compatible > > string for one certain panel (Hydis HVA40WV1). Reading this once more make me think that the right way to do this is to have two compatible's. enum - novatek,nt35510 - hydis,hva40wv1 So there shall be a match for both. Then we have explicit documented that this is the combination of a specific controller and a specific panel. Sam > > > > As other panels are discovered and investigated, we can add > > more compatibles to the binding. > > > > Cc: Stephan Gerhold > > Cc: devicetree@vger.kernel.org > > Signed-off-by: Linus Walleij > > --- > > .../display/panel/novatek-nt35510.yaml | 53 +++++++++++++++++++ > > 1 file changed, 53 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/panel/novatek-nt35510.yaml > > > > diff --git a/Documentation/devicetree/bindings/display/panel/novatek-nt35510.yaml b/Documentation/devicetree/bindings/display/panel/novatek-nt35510.yaml > > new file mode 100644 > > index 000000000000..a4a6b5adf15b > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/panel/novatek-nt35510.yaml > > @@ -0,0 +1,53 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/panel/novatek-nt35510.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Novatek NT35510-based display panels > > + > > +maintainers: > > + - Linus Walleij > > + > > +allOf: > > + - $ref: panel-common.yaml# > > + > > +properties: > > + compatible: > > + const: hydis,hva40wv1 > compatible fail to match filename - which is common practice. > And hydis is not a known vendor-prefix. > > > > + description: This indicates the panel manufacturer of the panel > > + that is in turn using the NT35510 panel driver. The compatible > > + string determines how the NT35510 panel driver shall be configured > > + to work with the indicated panel. > The description is just a general description of what compatible is used > for. > Please drop it as it does not provide anything specific for the panel. > > Sam > > > + reg: true > > + reset-gpios: true > > + vdd-supply: > > + description: regulator that supplies the vdd voltage > > + vddi-supply: > > + description: regulator that supplies the vddi voltage > > + backlight: true > > + > > +required: > > + - compatible > > + - reg > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include > > + > > + dsi@a0351000 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + panel { > > + compatible = "hydis,hva40wv1"; > > + reg = <0>; > > + vdd-supply = <&ab8500_ldo_aux4_reg>; > > + vddi-supply = <&ab8500_ldo_aux6_reg>; > > + reset-gpios = <&gpio4 11 GPIO_ACTIVE_LOW>; > > + backlight = <&gpio_bl>; > > + }; > > + }; > > + > > +... > > -- > > 2.21.0 > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel