From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3637C00523 for ; Mon, 6 Jan 2020 02:57:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7A161206F0 for ; Mon, 6 Jan 2020 02:57:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727374AbgAFC5w (ORCPT ); Sun, 5 Jan 2020 21:57:52 -0500 Received: from mga11.intel.com ([192.55.52.93]:41599 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727307AbgAFC5v (ORCPT ); Sun, 5 Jan 2020 21:57:51 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Jan 2020 18:57:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,401,1571727600"; d="scan'208";a="232694802" Received: from hao-dev.bj.intel.com (HELO localhost) ([10.238.157.65]) by orsmga002.jf.intel.com with ESMTP; 05 Jan 2020 18:57:49 -0800 Date: Mon, 6 Jan 2020 10:37:42 +0800 From: Wu Hao To: Will Deacon Cc: mdf@kernel.org, mark.rutland@arm.com, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, atull@kernel.org, gregkh@linuxfoundation.org, yilun.xu@intel.com Subject: Re: [PATCH v6 0/2] add performance reporting support to FPGA DFL drivers Message-ID: <20200106023742.GA3980@hao-dev> References: <1573622695-25607-1-git-send-email-hao.wu@intel.com> <20191125033412.GB890@hao-dev> <20191125080127.GC1809@willie-the-truck> <20191125080839.GA6227@hao-dev> <20191209024527.GA22625@hao-dev> <20191216010104.GA32154@yilunxu-OptiPlex-7050> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191216010104.GA32154@yilunxu-OptiPlex-7050> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 16, 2019 at 09:01:04AM +0800, Xu Yilum wrote: > On Mon, Dec 09, 2019 at 10:45:27AM +0800, Wu Hao wrote: > > On Mon, Nov 25, 2019 at 04:08:39PM +0800, Wu Hao wrote: > > > On Mon, Nov 25, 2019 at 08:01:28AM +0000, Will Deacon wrote: > > > > On Mon, Nov 25, 2019 at 11:34:12AM +0800, Wu Hao wrote: > > > > > Hi Will and Mark, > > > > > > > > > > Could you please help us on review this patchset? as this patchset mainly > > > > > introduced a new perf driver following the similar way as drivers/perf/*. > > > > > > > > Why is it not under drivers/perf/, then? > > > > > > Hi Will > > > > > > Thanks for the quick response. This is one sub feature for DFL based FPGAs, > > > and we plan to put this sub feature together with others, including related > > > documentation. It only registers a standard perf pmu for its userspace > > > interfaces. > > > > > > > > > > > > This patchset has been submitted for a long time but didn't receive any > > > > > comment after v4. we appreciate any review comments! thanks in advance. :) > > > > > > > > Hmm, not sure I saw the previous versions. Guessing I wasn't on cc? > > > > > > We switched to perf API from v4, and started ccing you and Mark from v5. :) > > > > Hi Will > > > > Did you get a chance to look into this patchset? > > > > Thanks > > Hao > > Hi Will > > Did you have time to look into this patchset? We have done review work > for FPGA part. And as a perf driver, we appreciate your comments. > > Thanks > Yilun Hi Will Did you get a chance to look into this patchset these days? Actually we didn't receive any comments for a long time, if you are busy and don't have enough time on this, do you know if someone else could help with review and ack from perf driver point of view, or any other things we can do to speed up this? Thanks in advance! Hao > > > > > > > > > Thanks > > > Hao > > > > > > > > > > > Will