From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B56EC33C9B for ; Mon, 6 Jan 2020 13:17:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E725C207FD for ; Mon, 6 Jan 2020 13:17:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="w0ppQOyx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726551AbgAFNRW (ORCPT ); Mon, 6 Jan 2020 08:17:22 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:40021 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726340AbgAFNRW (ORCPT ); Mon, 6 Jan 2020 08:17:22 -0500 Received: by mail-wr1-f68.google.com with SMTP id c14so49542088wrn.7 for ; Mon, 06 Jan 2020 05:17:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=FR/KySs86ffBpbHH+kpMl4ePalFaMSRboiPIel9rYrI=; b=w0ppQOyxa9BpzzUmN9s31SbUIxxKvXZjxngFTwTH+s32uOaLCPYjI/iHVnLLcWlMSj yyjUqXbbtGQxjoFWSn+ep7gJJ1grJgq/J5VOaiPeHf+usEwXYKp9d0xdtjoloz777RY+ MUWECSR/Oz2K/azWLZm6hQla6gYy/D4RHlOo0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FR/KySs86ffBpbHH+kpMl4ePalFaMSRboiPIel9rYrI=; b=j2WBaRClKe2ZcndAEN9Mxv70obfBcEAopQ2toBFBowRRCUiQrs2+cWzUxDuoTOewhM z3Q4Z/ArOILjiPmm5y0TLzrlqVOegAj401qWFrQHCnZGtEvmqfPlpKoIsEYNOETlTEM2 j6J6mJkMiowbYJw170Bn3S7OEG2orrAcTdBbQJVOO264SgkuBpeKokpsN86day4h6tOr 1BdY3bz40ntY5Vx1Oc2dqR8DE9umbKCwPOgtsGIND90ygZuQN87wqsj9VX0IzMMMa5aM WNPVDOeyGxdB4ESWMyfv4LHfNBH5sEk+D2SoWcM0PUPGU7hJUiKdipQIzF+r3h1dBBSY Ol8w== X-Gm-Message-State: APjAAAVPrLqkkDaTwlUA8kV18xL+/0qQh5FnMScgYV6X2Oz5HTv0a7Fw Vn+6hSwexMTgkjaPugmKlJWsRA== X-Google-Smtp-Source: APXvYqwydYsFcx/lAJEweADm0F8TYKxbw+Ktk9jZs3fwgCWfVmUr7KAwfkYV5CH+hA+r33UHztVEEw== X-Received: by 2002:a5d:6441:: with SMTP id d1mr103180769wrw.93.1578316640253; Mon, 06 Jan 2020 05:17:20 -0800 (PST) Received: from localhost ([2a01:4b00:8432:8a00:63de:dd93:20be:f460]) by smtp.gmail.com with ESMTPSA id o4sm70942309wrx.25.2020.01.06.05.17.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jan 2020 05:17:19 -0800 (PST) Date: Mon, 6 Jan 2020 13:17:19 +0000 From: Chris Down To: "zhengbin (A)" Cc: linux-mm@kvack.org, Hugh Dickins , Andrew Morton , Al Viro , Matthew Wilcox , Amir Goldstein , Jeff Layton , Johannes Weiner , Tejun Heo , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH v5 1/2] tmpfs: Add per-superblock i_ino support Message-ID: <20200106131719.GB361303@chrisdown.name> References: <91b4ed6727712cb6d426cf60c740fe2f473f7638.1578225806.git.chris@chrisdown.name> <4106bf3f-5c99-77a4-717e-10a0ffa6a3fa@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <4106bf3f-5c99-77a4-717e-10a0ffa6a3fa@huawei.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org zhengbin (A) writes: >Use spin_lock will affect performance "Performance" isn't a binary. In discussions, you should avoid invoking the performance boogeyman without presenting any real-world data. :-) We already have to take this spin lock before when setting the free inode count. The two sites can be merged, but it seems unnecessary to conflate their purpose at this time.