All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olof Johansson <olof@lixom.net>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-clk@vger.kernel.org, soc@kernel.org
Subject: Re: [PATCH 4/5] ARM: dts: mmp3: Add HSIC controllers
Date: Mon, 6 Jan 2020 11:22:25 -0800	[thread overview]
Message-ID: <20200106192225.wc3ber4abkf7s3iu@localhost> (raw)
In-Reply-To: <186ca73e408654981e08f7f12ae543ba51debb68.camel@v3.sk>

On Fri, Dec 20, 2019 at 08:05:50AM +0100, Lubomir Rintel wrote:
> On Fri, 2019-12-20 at 07:53 +0100, Lubomir Rintel wrote:
> > There are two on MMP3, along with the PHYs. The PHYs are made compatible
> > with the NOP transceiver, since there's no driver for the time being and
> > they're likely configured by the firmware.
> > 
> > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> > ---
> >  arch/arm/boot/dts/mmp3.dtsi | 44 +++++++++++++++++++++++++++++++++++++
> >  1 file changed, 44 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/mmp3.dtsi b/arch/arm/boot/dts/mmp3.dtsi
> > index d9762de0ed34b..36c50706e60e0 100644
> > --- a/arch/arm/boot/dts/mmp3.dtsi
> > +++ b/arch/arm/boot/dts/mmp3.dtsi
> > @@ -201,6 +201,50 @@ usb_otg0: usb-otg@d4208000 {
> >  				status = "disabled";
> >  			};
> >  
> > +			hsic_phy0: hsic-phy@f0001800 {
> > +				compatible = "marvell,mmp3-hsic-phy",
> > +					     "usb-nop-xceiv",
> 
> I managed to mess this up right before sending it out.     ^^^
> Sorry for that. There should be a semicolon there. I'll fix this up on
> next patch spin.

Missed the comments when applying, but I fixed it up locally with the below
patch. Please send new versions incremental on top of it.

I applied the series to the mmp/hsic (and mmp/hsic-fixed) branch in our tree if
you want to use that as a base.


-Olof


---

From e2ce979bf176af4b8eb7aea866919d618c08f752 Mon Sep 17 00:00:00 2001
From: Olof Johansson <olof@lixom.net>
Date: Mon, 6 Jan 2020 11:14:10 -0800
Subject: [PATCH] ARM: dts: mmp3: Fix typos

Fixes build failures due to syntax errors.

Fixes: 3240d5b872f2 ("ARM: dts: mmp3: Add HSIC controllers")
Signed-off-by: Olof Johansson <olof@lixom.net>
---
 arch/arm/boot/dts/mmp3.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/mmp3.dtsi b/arch/arm/boot/dts/mmp3.dtsi
index 36c50706e60e..1eba7fb6629b 100644
--- a/arch/arm/boot/dts/mmp3.dtsi
+++ b/arch/arm/boot/dts/mmp3.dtsi
@@ -203,7 +203,7 @@
 
 			hsic_phy0: hsic-phy@f0001800 {
 				compatible = "marvell,mmp3-hsic-phy",
-					     "usb-nop-xceiv",
+					     "usb-nop-xceiv";
 				reg = <0xf0001800 0x40>;
 				#phy-cells = <0>;
 				status = "disabled";
@@ -225,7 +225,7 @@
 
 			hsic_phy1: hsic-phy@f0002800 {
 				compatible = "marvell,mmp3-hsic-phy",
-					     "usb-nop-xceiv",
+					     "usb-nop-xceiv";
 				reg = <0xf0002800 0x40>;
 				#phy-cells = <0>;
 				status = "disabled";
-- 
2.22.GIT


  reply	other threads:[~2020-01-06 19:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-20  6:53 [PATCH 1/5] Enable HSIC on MMP3 SoC Lubomir Rintel
2019-12-20  6:53 ` [PATCH 1/5] dt-bindings: marvell,mmp2: Add clock ids for the HSIC clocks Lubomir Rintel
2019-12-23 19:32   ` Stephen Boyd
2019-12-20  6:53 ` [PATCH 2/5] clk: mmp2: Add " Lubomir Rintel
2019-12-23 19:33   ` Stephen Boyd
2019-12-20  6:53 ` [PATCH 3/5] dt-bindings: phy: Add binding for marvell,mmp3-hsic-phy Lubomir Rintel
2020-01-07 22:20   ` Rob Herring
2019-12-20  6:53 ` [PATCH 4/5] ARM: dts: mmp3: Add HSIC controllers Lubomir Rintel
2019-12-20  7:05   ` Lubomir Rintel
2020-01-06 19:22     ` Olof Johansson [this message]
2019-12-23  9:57   ` kbuild test robot
2019-12-23  9:57     ` kbuild test robot
2019-12-20  6:53 ` [PATCH 5/5] ARM: dts: mmp3-dell-ariel: Enable the HSIC Lubomir Rintel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200106192225.wc3ber4abkf7s3iu@localhost \
    --to=olof@lixom.net \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=kishon@ti.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkundrak@v3.sk \
    --cc=mark.rutland@arm.com \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=soc@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.