From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F38AC33C99 for ; Tue, 7 Jan 2020 09:39:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 10DD82077B for ; Tue, 7 Jan 2020 09:39:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CiAxq/64" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727739AbgAGJjK (ORCPT ); Tue, 7 Jan 2020 04:39:10 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:31590 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726485AbgAGJjJ (ORCPT ); Tue, 7 Jan 2020 04:39:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578389947; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KTZsZnppU+2QHEms25h87mEXIcd3CR1WH++YNAVYQNY=; b=CiAxq/64b9ZXwHdMaPnATKTkfAX+il2AFK/1O3h6gwg+n8rZ1ghbmhXxNTWnkyKM5jVY7Y MAWsdbAkLF6hfDuRpy2/76AqZXffPE3z/xSnB5nk3lCducpHNsKMUJxvlmFu82DUUVvAQJ CINpnLHw6eJImF78mxUwPfKBXry38h4= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-31-963xah0ZMei1wgHr78XEYw-1; Tue, 07 Jan 2020 04:39:06 -0500 X-MC-Unique: 963xah0ZMei1wgHr78XEYw-1 Received: by mail-qv1-f71.google.com with SMTP id p3so9901089qvt.9 for ; Tue, 07 Jan 2020 01:39:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=KTZsZnppU+2QHEms25h87mEXIcd3CR1WH++YNAVYQNY=; b=tBxlTTcqhq6OMk7A3qtlS/wOrrr6wPFDJWQPFhRrz0O6t+GVt9e/ZyMp0qLptAVgwm 14/PmHtXAANU81HlzJVvQkkoPX4RP+0aN4Mr1ZoJDmHYvZpcdJtVmMct88xOW9jaaqOz leW4rsZiqNYrd0mYi2XnC0qIvuZK6EIpRwxGEgiSYCg0iORrNpa6F7H73F4s1HUKjkgz 8dEvff6lTMphYa18B3cUA9OJ4PSQoHKaDjDsdl/ZIMoSv612XmWcy0oJq3XV7a1WNam1 zCQQeKlYybQUSwRY536Iw4EAvl74/DO1hOIQUgfkgvcEnmB4H7hnB/KJ0XLLDBEpEEV8 D9Mw== X-Gm-Message-State: APjAAAUFZccMwqunX5ypZsHV5Vs8MB8TMxsrUtfKDPIiCCD4zMqEkb2M wf34FKyztz5Bmx6pr5XQ+X95TqzeNQ8kHXYhR1Nq33SPVfK/oz0U9ogMx/qf7ucoYgiZ5Ogu06l DnEiUKlmLTgABGGyjHbsv7Rpb X-Received: by 2002:ac8:1bd4:: with SMTP id m20mr80192048qtk.301.1578389946367; Tue, 07 Jan 2020 01:39:06 -0800 (PST) X-Google-Smtp-Source: APXvYqxNBSffjTXlW+OajOtddlXmtV11+UXzECSfu7cNC0iRx6P/v+pltqGMwIX+pamDcwsrKCW75A== X-Received: by 2002:ac8:1bd4:: with SMTP id m20mr80192040qtk.301.1578389946145; Tue, 07 Jan 2020 01:39:06 -0800 (PST) Received: from redhat.com (bzq-79-183-34-164.red.bezeqint.net. [79.183.34.164]) by smtp.gmail.com with ESMTPSA id u57sm24900235qth.68.2020.01.07.01.39.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jan 2020 01:39:05 -0800 (PST) Date: Tue, 7 Jan 2020 04:39:00 -0500 From: "Michael S. Tsirkin" To: Christian Borntraeger Cc: "virtualization@lists.linux-foundation.org" , Stephen Rothwell , Linux Next Mailing List , "linux-kernel@vger.kernel.org" , kvm list , Halil Pasic Subject: Re: vhost changes (batched) in linux-next after 12/13 trigger random crashes in KVM guests after reboot Message-ID: <20200107042401-mutt-send-email-mst@kernel.org> References: <20191218100926-mutt-send-email-mst@kernel.org> <2ffdbd95-e375-a627-55a1-6990b0a0e37a@de.ibm.com> <20200106054041-mutt-send-email-mst@kernel.org> <08ae8d28-3d8c-04e8-bdeb-0117d06c6dc7@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <08ae8d28-3d8c-04e8-bdeb-0117d06c6dc7@de.ibm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 07, 2020 at 09:59:16AM +0100, Christian Borntraeger wrote: > > > On 06.01.20 11:50, Michael S. Tsirkin wrote: > > On Wed, Dec 18, 2019 at 04:59:02PM +0100, Christian Borntraeger wrote: > >> On 18.12.19 16:10, Michael S. Tsirkin wrote: > >>> On Wed, Dec 18, 2019 at 03:43:43PM +0100, Christian Borntraeger wrote: > >>>> Michael, > >>>> > >>>> with > >>>> commit db7286b100b503ef80612884453bed53d74c9a16 (refs/bisect/skip-db7286b100b503ef80612884453bed53d74c9a16) > >>>> vhost: use batched version by default > >>>> plus > >>>> commit 6bd262d5eafcdf8cdfae491e2e748e4e434dcda6 (HEAD, refs/bisect/bad) > >>>> Revert "vhost/net: add an option to test new code" > >>>> to make things compile (your next tree is not easily bisectable, can you fix that as well?). > >>> > >>> I'll try. > >>> > >>>> > >>>> I get random crashes in my s390 KVM guests after reboot. > >>>> Reverting both patches together with commit decd9b8 "vhost: use vhost_desc instead of vhost_log" to > >>>> make it compile again) on top of linux-next-1218 makes the problem go away. > >>>> > >>>> Looks like the batched version is not yet ready for prime time. Can you drop these patches until > >>>> we have fixed the issues? > >>>> > >>>> Christian > >>>> > >>> > >>> Will do, thanks for letting me know. > >> > >> I have confirmed with the initial reporter (internal test team) that > >> with a known to be broken linux next kernel also fixes the problem, so it is really the > >> vhost changes. > > > > OK I'm back and trying to make it more bisectable. > > > > I pushed a new tag "batch-v2". > > It's same code but with this bisect should get more information. > > I get the following with this tag > > drivers/vhost/net.c: In function ‘vhost_net_tx_get_vq_desc’: > drivers/vhost/net.c:574:7: error: implicit declaration of function ‘vhost_get_vq_desc_batch’; did you mean ‘vhost_get_vq_desc’? [-Werror=implicit-function-declaration] > 574 | r = vhost_get_vq_desc_batch(tvq, tvq->iov, ARRAY_SIZE(tvq->iov), > | ^~~~~~~~~~~~~~~~~~~~~~~ > | vhost_get_vq_desc > Not sure why but I pushed a wrong commit. Sorry. Should be good now. -- MST From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: vhost changes (batched) in linux-next after 12/13 trigger random crashes in KVM guests after reboot Date: Tue, 7 Jan 2020 04:39:00 -0500 Message-ID: <20200107042401-mutt-send-email-mst@kernel.org> References: <20191218100926-mutt-send-email-mst@kernel.org> <2ffdbd95-e375-a627-55a1-6990b0a0e37a@de.ibm.com> <20200106054041-mutt-send-email-mst@kernel.org> <08ae8d28-3d8c-04e8-bdeb-0117d06c6dc7@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <08ae8d28-3d8c-04e8-bdeb-0117d06c6dc7@de.ibm.com> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" To: Christian Borntraeger Cc: Stephen Rothwell , kvm list , "linux-kernel@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , Halil Pasic , Linux Next Mailing List List-Id: virtualization@lists.linuxfoundation.org T24gVHVlLCBKYW4gMDcsIDIwMjAgYXQgMDk6NTk6MTZBTSArMDEwMCwgQ2hyaXN0aWFuIEJvcm50 cmFlZ2VyIHdyb3RlOgo+IAo+IAo+IE9uIDA2LjAxLjIwIDExOjUwLCBNaWNoYWVsIFMuIFRzaXJr aW4gd3JvdGU6Cj4gPiBPbiBXZWQsIERlYyAxOCwgMjAxOSBhdCAwNDo1OTowMlBNICswMTAwLCBD aHJpc3RpYW4gQm9ybnRyYWVnZXIgd3JvdGU6Cj4gPj4gT24gMTguMTIuMTkgMTY6MTAsIE1pY2hh ZWwgUy4gVHNpcmtpbiB3cm90ZToKPiA+Pj4gT24gV2VkLCBEZWMgMTgsIDIwMTkgYXQgMDM6NDM6 NDNQTSArMDEwMCwgQ2hyaXN0aWFuIEJvcm50cmFlZ2VyIHdyb3RlOgo+ID4+Pj4gTWljaGFlbCwK PiA+Pj4+Cj4gPj4+PiB3aXRoIAo+ID4+Pj4gY29tbWl0IGRiNzI4NmIxMDBiNTAzZWY4MDYxMjg4 NDQ1M2JlZDUzZDc0YzlhMTYgKHJlZnMvYmlzZWN0L3NraXAtZGI3Mjg2YjEwMGI1MDNlZjgwNjEy ODg0NDUzYmVkNTNkNzRjOWExNikKPiA+Pj4+ICAgICB2aG9zdDogdXNlIGJhdGNoZWQgdmVyc2lv biBieSBkZWZhdWx0Cj4gPj4+PiBwbHVzCj4gPj4+PiBjb21taXQgNmJkMjYyZDVlYWZjZGY4Y2Rm YWU0OTFlMmU3NDhlNGU0MzRkY2RhNiAoSEVBRCwgcmVmcy9iaXNlY3QvYmFkKQo+ID4+Pj4gICAg IFJldmVydCAidmhvc3QvbmV0OiBhZGQgYW4gb3B0aW9uIHRvIHRlc3QgbmV3IGNvZGUiCj4gPj4+ PiB0byBtYWtlIHRoaW5ncyBjb21waWxlICh5b3VyIG5leHQgdHJlZSBpcyBub3QgZWFzaWx5IGJp c2VjdGFibGUsIGNhbiB5b3UgZml4IHRoYXQgYXMgd2VsbD8pLgo+ID4+Pgo+ID4+PiBJJ2xsIHRy eS4KPiA+Pj4KPiA+Pj4+Cj4gPj4+PiBJIGdldCByYW5kb20gY3Jhc2hlcyBpbiBteSBzMzkwIEtW TSBndWVzdHMgYWZ0ZXIgcmVib290Lgo+ID4+Pj4gUmV2ZXJ0aW5nIGJvdGggcGF0Y2hlcyB0b2dl dGhlciB3aXRoIGNvbW1pdCBkZWNkOWI4ICJ2aG9zdDogdXNlIHZob3N0X2Rlc2MgaW5zdGVhZCBv ZiB2aG9zdF9sb2ciIHRvCj4gPj4+PiBtYWtlIGl0IGNvbXBpbGUgYWdhaW4pIG9uIHRvcCBvZiBs aW51eC1uZXh0LTEyMTggbWFrZXMgdGhlIHByb2JsZW0gZ28gYXdheS4KPiA+Pj4+Cj4gPj4+PiBM b29rcyBsaWtlIHRoZSBiYXRjaGVkIHZlcnNpb24gaXMgbm90IHlldCByZWFkeSBmb3IgcHJpbWUg dGltZS4gQ2FuIHlvdSBkcm9wIHRoZXNlIHBhdGNoZXMgdW50aWwKPiA+Pj4+IHdlIGhhdmUgZml4 ZWQgdGhlIGlzc3Vlcz8KPiA+Pj4+Cj4gPj4+PiBDaHJpc3RpYW4KPiA+Pj4+Cj4gPj4+Cj4gPj4+ IFdpbGwgZG8sIHRoYW5rcyBmb3IgbGV0dGluZyBtZSBrbm93Lgo+ID4+Cj4gPj4gSSBoYXZlIGNv bmZpcm1lZCB3aXRoIHRoZSBpbml0aWFsIHJlcG9ydGVyIChpbnRlcm5hbCB0ZXN0IHRlYW0pIHRo YXQgPGRyaXZlciBuYW1lPSdxZW11Jy8+IAo+ID4+IHdpdGggYSBrbm93biB0byBiZSBicm9rZW4g bGludXggbmV4dCBrZXJuZWwgYWxzbyBmaXhlcyB0aGUgcHJvYmxlbSwgc28gaXQgaXMgcmVhbGx5 IHRoZQo+ID4+IHZob3N0IGNoYW5nZXMuCj4gPiAKPiA+IE9LIEknbSBiYWNrIGFuZCB0cnlpbmcg dG8gbWFrZSBpdCBtb3JlIGJpc2VjdGFibGUuCj4gPiAKPiA+IEkgcHVzaGVkIGEgbmV3IHRhZyAi YmF0Y2gtdjIiLgo+ID4gSXQncyBzYW1lIGNvZGUgYnV0IHdpdGggdGhpcyBiaXNlY3Qgc2hvdWxk IGdldCBtb3JlIGluZm9ybWF0aW9uLgo+IAo+IEkgZ2V0IHRoZSBmb2xsb3dpbmcgd2l0aCB0aGlz IHRhZwo+IAo+IGRyaXZlcnMvdmhvc3QvbmV0LmM6IEluIGZ1bmN0aW9uIOKAmHZob3N0X25ldF90 eF9nZXRfdnFfZGVzY+KAmToKPiBkcml2ZXJzL3Zob3N0L25ldC5jOjU3NDo3OiBlcnJvcjogaW1w bGljaXQgZGVjbGFyYXRpb24gb2YgZnVuY3Rpb24g4oCYdmhvc3RfZ2V0X3ZxX2Rlc2NfYmF0Y2ji gJk7IGRpZCB5b3UgbWVhbiDigJh2aG9zdF9nZXRfdnFfZGVzY+KAmT8gWy1XZXJyb3I9aW1wbGlj aXQtZnVuY3Rpb24tZGVjbGFyYXRpb25dCj4gICA1NzQgfCAgIHIgPSB2aG9zdF9nZXRfdnFfZGVz Y19iYXRjaCh0dnEsIHR2cS0+aW92LCBBUlJBWV9TSVpFKHR2cS0+aW92KSwKPiAgICAgICB8ICAg ICAgIF5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+Cj4gICAgICAgfCAgICAgICB2aG9zdF9nZXRfdnFf ZGVzYwo+IAoKTm90IHN1cmUgd2h5IGJ1dCBJIHB1c2hlZCBhIHdyb25nIGNvbW1pdC4gU29ycnku IFNob3VsZCBiZSBnb29kIG5vdy4KCi0tIApNU1QKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fClZpcnR1YWxpemF0aW9uIG1haWxpbmcgbGlzdApWaXJ0dWFs aXphdGlvbkBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91 bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby92aXJ0dWFsaXphdGlvbg==