From: Cornelia Huck <cohuck@redhat.com>
To: Denis Plotnikov <dplotnikov@virtuozzo.com>
Cc: ehabkost@redhat.com, mst@redhat.com, qemu-devel@nongnu.org,
pbonzini@redhat.com, rth@twiddle.net
Subject: Re: [PATCH v1] hw: fix using 4.2 compat in 5.0 machine types for i440fx/q35
Date: Tue, 7 Jan 2020 10:24:26 +0100 [thread overview]
Message-ID: <20200107102426.3f31d4d6.cohuck@redhat.com> (raw)
In-Reply-To: <20191223072856.5369-1-dplotnikov@virtuozzo.com>
On Mon, 23 Dec 2019 10:28:56 +0300
Denis Plotnikov <dplotnikov@virtuozzo.com> wrote:
> 5.0 machine type uses 4.2 compats. This seems to be incorrect, since
> the latests machine type by now is 5.0 and it should use its own
> compat or shouldn't use any relying on the defaults.
> Seems, like this appeared because of some problems on merge/rebase.
Yes, I seem to have fat-fingered that while rebasing.
>
> Signed-off-by: Denis Plotnikov <dplotnikov@virtuozzo.com>
> ---
> hw/i386/pc_piix.c | 1 -
> hw/i386/pc_q35.c | 1 -
> 2 files changed, 2 deletions(-)
I double checked that the other compat machines seem fine.
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2020-01-07 9:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-23 7:28 [PATCH v1] hw: fix using 4.2 compat in 5.0 machine types for i440fx/q35 Denis Plotnikov
2019-12-26 10:15 ` Igor Mammedov
2020-01-07 9:24 ` Cornelia Huck [this message]
2020-01-07 10:51 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200107102426.3f31d4d6.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=dplotnikov@virtuozzo.com \
--cc=ehabkost@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.