From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68044C33C8C for ; Tue, 7 Jan 2020 13:35:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 26714208C4 for ; Tue, 7 Jan 2020 13:35:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578404129; bh=eT3Q2mOtqsLr5AMSNIN68RzaigXoxZEOJVANm5/L4iw=; h=From:To:Cc:Subject:Date:List-ID:From; b=RGRKnXsiQfzWFmG3y7MF7pwZtbDiWiifgRTPc18R1ZCPgiyvyTgox6KK8PQU54iNb Lq4PX9loKP3SC8Zratp8FZGGXroyD8vOU2Dn4YzDEf6sCAa05H9mQfFk0iH70iH+nv YlGC54cdIitX5nAtLBfzBj66/mvKG4uYLZkaF4rc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728122AbgAGNf2 (ORCPT ); Tue, 7 Jan 2020 08:35:28 -0500 Received: from mail-pj1-f68.google.com ([209.85.216.68]:54470 "EHLO mail-pj1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727559AbgAGNf0 (ORCPT ); Tue, 7 Jan 2020 08:35:26 -0500 Received: by mail-pj1-f68.google.com with SMTP id kx11so9036768pjb.4; Tue, 07 Jan 2020 05:35:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LgLKqwmlNN4Mr0eDg0yf4FKDSvMJLZg0nMWsSJUvFPU=; b=FBGIL/UVilYyRZhq/DwOW78LnN7jI2/Xn3EWnkDWC/QkPGhmHMU3og21ak3ER4uUr+ FAzMbIGt79D2l/AHNU2v5ZlGC2eOR5et1tJ1hnTQ6YIcGVF4ayXJAkXznfQJyhBaIGn0 d64K84q89XLmXsy/+Eoh7WVnU6KjwcGeWLIcYJqbzE6dWpv+mSR4ijsyhk1N5hwsJ+rh dQUDMQos42OJS6PTRUEHjWn0f8+o9+l290sW+PjXRvqijUC8+YtCCAn+Gm3R+4u93WSG DC8rxOtY0SnGoKnCy/RedA0uhgPbTkBhhnoHeocYSWIEJUwmIsKeu5KfQmmXwnCLzT45 pctw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=LgLKqwmlNN4Mr0eDg0yf4FKDSvMJLZg0nMWsSJUvFPU=; b=Q5H0zszP7iymZxf9Lc1OkIMYR/DVrrVmvtNIqsvfXKhjWurOMAJonT3U/GVvc/VjV/ dUUBmB9nVnmwOaG5Fpfi5PBhMukYg3d67zxh8rDG0hW5vqRhx/Uf83sjVWIwbzfrZJpz /uIm5pY4NCh9DfZC0JkWysGyhMRHhAK5nATLCTI23lzxUKngUIklFOQ+PhLMQSFvb3vC /46Ohmxd3OzZTQQo4eUT5RZeGh+fs9yF876fzdeZPxqOrJEZGq/tVnGivpGu94j91Zln 0qHBymlsU8vxJbhj6V/5hlrNRtrGkVAu0diKQCNfvDKBjKPoTk4AnOc56fuy+huuqHvZ CHzQ== X-Gm-Message-State: APjAAAXkxcfG1qBH2qtexCer5nnLY6RXGn2kyRh19C+z7fFsf86h2Jcb IQ8EJiDyTfItToU9YcHYnso= X-Google-Smtp-Source: APXvYqyerrLA2H8IC8zw9hF+PmLIhK+JPVE9wt+mkNq4KDajfJoSA8M1b+PteQQiRiiKCh3KLZMiSA== X-Received: by 2002:a17:902:bd96:: with SMTP id q22mr62709260pls.94.1578404125852; Tue, 07 Jan 2020 05:35:25 -0800 (PST) Received: from gaurie.seo.corp.google.com ([2401:fa00:d:1:4eb0:a5ef:3975:7440]) by smtp.gmail.com with ESMTPSA id p17sm80358484pfn.31.2020.01.07.05.35.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jan 2020 05:35:25 -0800 (PST) From: Namhyung Kim To: Ingo Molnar , Peter Zijlstra , Arnaldo Carvalho de Melo Cc: Jiri Olsa , Alexander Shishkin , Mark Rutland , Stephane Eranian , LKML , linux-perf-users@vger.kernel.org, Tejun Heo , Li Zefan , Johannes Weiner , Adrian Hunter Subject: [PATCHSET 0/9] perf: Improve cgroup profiling (v4) Date: Tue, 7 Jan 2020 22:34:52 +0900 Message-Id: <20200107133501.327117-1-namhyung@kernel.org> X-Mailer: git-send-email 2.24.1.735.g03f4e72817-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, This work is to improve cgroup profiling in perf. Currently it only supports profiling tasks in a specific cgroup and there's no way to identify which cgroup the current sample belongs to. So I added PERF_SAMPLE_CGROUP to add cgroup id into each sample. It's a 64-bit integer having file handle of the cgroup. And kernel also generates PERF_RECORD_CGROUP event for new groups to correlate the cgroup id and cgroup name (path in the cgroup filesystem). The cgroup id can be read from userspace by name_to_handle_at() system call so it can synthesize the CGROUP event for existing groups. So why do we want this? Systems running a large number of jobs in different cgroups want to profiling such jobs precisely. This includes container hosting systems widely used today. Currently perf supports namespace tracking but the systems may not use (cgroup) namespace for their jobs. Also it'd be more intuitive to see cgroup names (as they're given by user or sysadmin) rather than numeric cgroup/namespace id even if they use the namespaces. >From Stephane Eranian: > In data centers you care about attributing samples to a job not such > much to a process. A job may have multiple processes which may come > and go. The cgroup on the other hand stays around for the entire > lifetime of the job. It is much easier to map a cgroup name to a > particular job than it is to map a pid back to a job name, > especially for offline post-processing. Note that this only works for "perf_event" cgroups (obviously) so if users are still using cgroup-v1 interface, they need to have same hierarchy for subsystem(s) want to profile with it. * Changes from v3: - staticize perf_event_cgroup() - fix sample parsing test * Changes from v2: - remove path_len from cgroup_event - bail out if kernel doesn't support cgroup sampling - add some description in the Kconfig * Changes from v1: - use new cgroup id (= file handle) The code is available at perf/cgroup-v4 branch in git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git The testing result looks something like this: [root@qemu build]# ./perf record --all-cgroups ./cgtest [ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.009 MB perf.data (150 samples) ] [root@qemu build]# ./perf report -s cgroup,comm --stdio # To display the perf.data header info, please use --header/--header-only options. # # # Total Lost Samples: 0 # # Samples: 150 of event 'cpu-clock:pppH' # Event count (approx.): 37500000 # # Overhead cgroup Command # ........ .......... ....... # 32.00% /sub/cgrp2 looper2 28.00% /sub/cgrp1 looper1 25.33% /sub looper0 4.00% / cgtest 4.00% /sub cgtest 3.33% /sub/cgrp2 cgtest 2.67% /sub/cgrp1 cgtest 0.67% / looper0 The test program (cgtest) follows. Thanks, Namhyung Cc: Tejun Heo Cc: Li Zefan Cc: Johannes Weiner Cc: Adrian Hunter -------8<-----------------------------------------8<---------------- #define _GNU_SOURCE #include #include #include #include #include #include #include #include #include #include #include char cgbase[] = "/sys/fs/cgroup/perf_event"; void mkcgrp(char *name) { char buf[256]; snprintf(buf, sizeof(buf), "%s%s", cgbase, name); if (mkdir(buf, 0755) < 0) perror("mkdir"); } void rmcgrp(char *name) { char buf[256]; snprintf(buf, sizeof(buf), "%s%s", cgbase, name); if (rmdir(buf) < 0) perror("rmdir"); } void setcgrp(char *name) { char buf[256]; int fd; snprintf(buf, sizeof(buf), "%s%s/tasks", cgbase, name); fd = open(buf, O_WRONLY); if (fd > 0) { if (write(fd, "0\n", 2) != 2) perror("write"); close(fd); } } void create_sub_cgroup(int idx) { char buf[128]; snprintf(buf, sizeof(buf), "/sub/cgrp%d", idx); mkcgrp(buf); } void remove_sub_cgroup(int idx) { char buf[128]; snprintf(buf, sizeof(buf), "/sub/cgrp%d", idx); rmcgrp(buf); } void set_sub_cgroup(int idx) { char buf[128]; snprintf(buf, sizeof(buf), "/sub/cgrp%d", idx); setcgrp(buf); } void set_task_name(int idx) { char buf[16]; snprintf(buf, sizeof(buf), "looper%d", idx); prctl(PR_SET_NAME, buf, 0, 0, 0); } void loop(unsigned max) { volatile unsigned int count = 1; while (count++ != max) { asm volatile ("pause"); } } void worker(int idx, unsigned cnt, int new_ns) { int oldns; create_sub_cgroup(idx); set_sub_cgroup(idx); if (new_ns) { if (unshare(CLONE_NEWCGROUP) < 0) perror("unshare"); #if 0 /* FIXME */ if (unshare(CLONE_NEWNS) < 0) perror("unshare"); if (mount("none", "/sys", NULL, MS_REMOUNT | MS_REC | MS_SLAVE, NULL) < 0) perror("mount --make-rslave"); sleep(1); if (umount("/sys/fs/cgroup/perf_event") < 0) perror("umount"); if (mount("cgroup", "/sys/fs/cgroup/perf_event", "cgroup", MS_NODEV | MS_NOEXEC | MS_NOSUID, "perf_event") < 0) perror("mount again"); #endif } if (fork() == 0) { set_task_name(idx); loop(cnt); exit(0); } wait(NULL); } int main(int argc, char *argv[]) { int i, nr = 2; int new_ns = 1; unsigned cnt = 1000000; int fd; if (argc > 1) nr = atoi(argv[1]); if (argc > 2) cnt = atoi(argv[2]); if (argc > 3) new_ns = atoi(argv[3]); mkcgrp("/sub"); setcgrp("/sub"); for (i = 0; i < nr; i++) { if (fork() == 0) { worker(i+1, cnt, new_ns); exit(0); } } set_task_name(0); loop(cnt); for (i = 0; i < nr; i++) wait(NULL); for (i = 0; i < nr; i++) remove_sub_cgroup(i+1); setcgrp("/"); rmcgrp("/sub"); return 0; } -------8<-----------------------------------------8<---------------- Namhyung Kim (9): perf/core: Add PERF_RECORD_CGROUP event perf/core: Add PERF_SAMPLE_CGROUP feature perf tools: Basic support for CGROUP event perf tools: Maintain cgroup hierarchy perf report: Add 'cgroup' sort key perf record: Support synthesizing cgroup events perf record: Add --all-cgroups option perf top: Add --all-cgroups option perf script: Add --show-cgroup-events option include/linux/perf_event.h | 1 + include/uapi/linux/perf_event.h | 16 ++- init/Kconfig | 3 +- kernel/events/core.c | 133 ++++++++++++++++++++++ tools/include/uapi/linux/perf_event.h | 16 ++- tools/lib/perf/include/perf/event.h | 7 ++ tools/perf/Documentation/perf-record.txt | 5 +- tools/perf/Documentation/perf-report.txt | 1 + tools/perf/Documentation/perf-script.txt | 3 + tools/perf/Documentation/perf-top.txt | 4 + tools/perf/builtin-diff.c | 1 + tools/perf/builtin-record.c | 10 ++ tools/perf/builtin-report.c | 1 + tools/perf/builtin-script.c | 41 +++++++ tools/perf/builtin-top.c | 9 ++ tools/perf/tests/sample-parsing.c | 6 +- tools/perf/util/cgroup.c | 75 +++++++++++- tools/perf/util/cgroup.h | 16 ++- tools/perf/util/event.c | 19 ++++ tools/perf/util/event.h | 6 + tools/perf/util/evsel.c | 17 ++- tools/perf/util/evsel.h | 1 + tools/perf/util/hist.c | 7 ++ tools/perf/util/hist.h | 1 + tools/perf/util/machine.c | 19 ++++ tools/perf/util/machine.h | 3 + tools/perf/util/perf_event_attr_fprintf.c | 2 + tools/perf/util/record.h | 1 + tools/perf/util/session.c | 8 ++ tools/perf/util/sort.c | 31 +++++ tools/perf/util/sort.h | 2 + tools/perf/util/synthetic-events.c | 127 +++++++++++++++++++++ tools/perf/util/synthetic-events.h | 1 + tools/perf/util/tool.h | 2 + 34 files changed, 581 insertions(+), 14 deletions(-) base-commit: 6c4798d3f08b81c2c52936b10e0fa872590c96ae -- 2.24.1.735.g03f4e72817-goog