From: Mika Westerberg <email@example.com>
To: Linus Walleij <firstname.lastname@example.org>
Cc: "email@example.com" <firstname.lastname@example.org>,
"open list:GPIO SUBSYSTEM" <email@example.com>,
Andy Shevchenko <firstname.lastname@example.org>,
Mathias Nyman <email@example.com>
Subject: Re: [PATCH] pinctrl: intel: Pass irqchip when adding gpiochip
Date: Tue, 7 Jan 2020 15:52:16 +0200 [thread overview]
Message-ID: <20200107135216.GR465886@lahna.fi.intel.com> (raw)
On Tue, Jan 07, 2020 at 11:32:54AM +0100, Linus Walleij wrote:
> On Mon, Dec 30, 2019 at 11:20 AM Mika Westerberg
> <firstname.lastname@example.org> wrote:
> > On Sun, Dec 29, 2019 at 02:30:59AM +0100, Linus Walleij wrote:
> > > We need to convert all old gpio irqchips to pass the irqchip
> > > setup along when adding the gpio_chip. For more info see
> > > drivers/gpio/TODO.
> > >
> > > Set up the pin ranges using the new callback.
> > Maybe have this one split as a separate patch? Same what we do for
> > Baytrail and Cherryview.
> I'm afraid to do that since splitting the semantic ordering was
> something that broke a lot of times already, I was under the
> impression that doing the two things (moving to the callback
> and adding along with the gpio_chip) at the same time was
> the only way to preserve the semantic ordering.
Well at least we do the same for others (add the callback in another
patch and then pass irqchip in another) but no strong feelings. I'm fine
with this one as well :)
> But more than anything I want someone to test it ...
I quickly tested this on Whiskey Lake and SD card detection interrupt
still works fine after this patch.
next prev parent reply other threads:[~2020-01-07 13:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-29 1:30 [PATCH] pinctrl: intel: Pass irqchip when adding gpiochip Linus Walleij
2019-12-30 10:20 ` Mika Westerberg
2020-01-07 10:32 ` Linus Walleij
2020-01-07 13:52 ` Mika Westerberg [this message]
2020-01-07 14:48 ` Andy Shevchenko
-- strict thread matches above, loose matches on Subject: below --
2019-10-06 0:59 Linus Walleij
2019-10-07 8:11 ` Andy Shevchenko
2019-10-07 14:22 ` Mika Westerberg
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.