From: Arvind Sankar <nivedita@alum.mit.edu>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: linux-efi@vger.kernel.org
Subject: [PATCH 2/3] x86/boot/compressed/32: Allow adjust_got to be called repeatedly
Date: Tue, 7 Jan 2020 08:54:59 -0500 [thread overview]
Message-ID: <20200107135500.644618-3-nivedita@alum.mit.edu> (raw)
In-Reply-To: <20200107135500.644618-1-nivedita@alum.mit.edu>
Save the new relocation address so that this function can be called
safely multiple times.
Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu>
---
arch/x86/boot/compressed/head_32.S | 42 +++++++++++++++++++++++-------
1 file changed, 33 insertions(+), 9 deletions(-)
diff --git a/arch/x86/boot/compressed/head_32.S b/arch/x86/boot/compressed/head_32.S
index e43ac17cb9fb..973ac0b51af5 100644
--- a/arch/x86/boot/compressed/head_32.S
+++ b/arch/x86/boot/compressed/head_32.S
@@ -173,15 +173,7 @@ SYM_FUNC_START_LOCAL_NOALIGN(.Lrelocated)
/*
* Adjust our own GOT
*/
- leal _got(%ebx), %edx
- leal _egot(%ebx), %ecx
-1:
- cmpl %ecx, %edx
- jae 2f
- addl %ebx, (%edx)
- addl $4, %edx
- jmp 1b
-2:
+ call .Ladjust_got
/*
* Do the extraction, and jump to the new kernel..
@@ -211,6 +203,38 @@ SYM_FUNC_START_LOCAL_NOALIGN(.Lrelocated)
jmp *%eax
SYM_FUNC_END(.Lrelocated)
+/*
+ * Adjust the global offset table
+ *
+ * The relocation base address is passed in EBX. If the kernel is being
+ * relocated to a new address, this function must be called after the kernel
+ * has been copied to the new location. We keep track of the relocation address
+ * so that it can be backed out if this function is called repeatedly.
+ */
+
+SYM_FUNC_START_LOCAL(.Ladjust_got)
+ /* Get the new relocation base address */
+ movl %ebx, %eax
+ /* Backout the previous relocation address if any */
+ subl got_relocation_base(%ebx), %eax
+ /* Store the relocation base address for future reference */
+ addl %eax, got_relocation_base(%ebx)
+
+ leal _got(%ebx), %edx
+ leal _egot(%ebx), %ecx
+1:
+ cmpl %ecx, %edx
+ jae 2f
+ addl %eax, (%edx)
+ addl $4, %edx
+ jmp 1b
+2:
+ ret
+SYM_FUNC_END(.Ladjust_got)
+
+ .data
+SYM_DATA_LOCAL(got_relocation_base, .long 0)
+
/*
* Stack and heap for uncompression
*/
--
2.24.1
next prev parent reply other threads:[~2020-01-07 13:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 13:54 [PATCH 0/3] Relocate GOT before calling EFI stub Arvind Sankar
2020-01-07 13:54 ` [PATCH 1/3] x86/boot/compressed/64: Make adjust_got easier to use repeatedly Arvind Sankar
2020-01-07 13:54 ` Arvind Sankar [this message]
2020-01-07 13:55 ` [PATCH 3/3] x86/boot: Perform GOT relocation before calling EFI stub Arvind Sankar
2020-01-07 14:01 ` [PATCH 0/3] Relocate GOT " Ard Biesheuvel
2020-01-07 14:13 ` Ard Biesheuvel
2020-01-07 14:21 ` Arvind Sankar
2020-01-07 14:24 ` Ard Biesheuvel
2020-01-07 14:27 ` Arvind Sankar
2020-01-07 14:28 ` Ard Biesheuvel
2020-01-07 17:58 ` Arvind Sankar
2020-01-07 17:59 ` Ard Biesheuvel
2020-01-07 18:08 ` Arvind Sankar
2020-01-07 18:10 ` Ard Biesheuvel
2020-01-07 18:32 ` Arvind Sankar
2020-01-07 19:03 ` Ard Biesheuvel
2020-01-07 19:14 ` Arvind Sankar
2020-01-07 19:23 ` Ard Biesheuvel
2020-01-07 19:51 ` Ard Biesheuvel
2020-01-07 20:00 ` Arvind Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200107135500.644618-3-nivedita@alum.mit.edu \
--to=nivedita@alum.mit.edu \
--cc=ardb@kernel.org \
--cc=linux-efi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.