All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [PULL 37/37] qdev/qom: remove some TODO limitations now that PROP_PTR is gone
Date: Tue,  7 Jan 2020 19:04:42 +0400	[thread overview]
Message-ID: <20200107150442.1727958-38-marcandre.lureau@redhat.com> (raw)
In-Reply-To: <20200107150442.1727958-1-marcandre.lureau@redhat.com>

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
---
 hw/core/qdev.c     |  8 --------
 qom/qom-qmp-cmds.c | 10 ----------
 2 files changed, 18 deletions(-)

diff --git a/hw/core/qdev.c b/hw/core/qdev.c
index aa3ccbf2ec..9f1753f5cf 100644
--- a/hw/core/qdev.c
+++ b/hw/core/qdev.c
@@ -736,14 +736,6 @@ void qdev_property_add_static(DeviceState *dev, Property *prop,
     if (prop->info->create) {
         prop->info->create(obj, prop, &local_err);
     } else {
-        /*
-         * TODO qdev_prop_ptr does not have getters or setters.  It must
-         * go now that it can be replaced with links.  The test should be
-         * removed along with it: all static properties are read/write.
-         */
-        if (!prop->info->get && !prop->info->set) {
-            return;
-        }
         object_property_add(obj, prop->name, prop->info->name,
                             prop->info->get, prop->info->set,
                             prop->info->release,
diff --git a/qom/qom-qmp-cmds.c b/qom/qom-qmp-cmds.c
index 236e8e41dd..f4494f98ac 100644
--- a/qom/qom-qmp-cmds.c
+++ b/qom/qom-qmp-cmds.c
@@ -142,16 +142,6 @@ static ObjectPropertyInfo *make_device_property_info(ObjectClass *klass,
                 continue;
             }
 
-            /*
-             * TODO Properties without a parser are just for dirty hacks.
-             * qdev_prop_ptr is the only such PropertyInfo.  It's marked
-             * for removal.  This conditional should be removed along with
-             * it.
-             */
-            if (!prop->info->set && !prop->info->create) {
-                return NULL;           /* no way to set it, don't show */
-            }
-
             info = g_malloc0(sizeof(*info));
             info->name = g_strdup(prop->name);
             info->type = default_type ? g_strdup(default_type)
-- 
2.25.0.rc1.20.g2443f3f80d



  parent reply	other threads:[~2020-01-07 15:31 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-07 15:04 [PULL 00/37] qom-ify serial and remove QDEV_PROP_PTR Marc-André Lureau
2020-01-07 15:04 ` [PULL 01/37] hw/display/sm501: Always map the UART0 Marc-André Lureau
2020-01-07 15:04 ` [PULL 02/37] sysbus: remove unused sysbus_try_create* Marc-André Lureau
2020-01-07 15:04 ` [PULL 03/37] sysbus: remove outdated comment Marc-André Lureau
2020-01-07 15:04 ` [PULL 04/37] chardev: generate an internal id when none given Marc-André Lureau
2020-01-07 15:04 ` [PULL 05/37] serial-pci-multi: factor out multi_serial_get_port_count() Marc-André Lureau
2020-01-07 15:04 ` [PULL 06/37] serial: initial qom-ification Marc-André Lureau
2020-01-07 15:04 ` [PULL 07/37] serial: register vmsd with DeviceClass Marc-André Lureau
2020-01-07 15:04 ` [PULL 08/37] serial: add "chardev" property Marc-André Lureau
2020-01-07 15:04 ` [PULL 09/37] serial: add "baudbase" property Marc-André Lureau
2020-01-07 15:04 ` [PULL 10/37] serial: realize the serial device Marc-André Lureau
2020-01-07 15:04 ` [PULL 11/37] serial: replace serial_exit_core() with unrealize Marc-André Lureau
2020-01-07 15:04 ` [PULL 12/37] serial: start making SerialMM a sysbus device Marc-André Lureau
2020-01-07 15:04 ` [PULL 13/37] serial-mm: add "regshift" property Marc-André Lureau
2020-01-07 15:04 ` [PULL 14/37] serial-mm: add endianness property Marc-André Lureau
2020-01-07 15:04 ` [PULL 15/37] serial-mm: use sysbus facilities Marc-André Lureau
2020-01-07 15:04 ` [PULL 16/37] serial: make SerialIO a sysbus device Marc-André Lureau
2020-01-07 15:04 ` [PULL 17/37] mips: inline serial_init() Marc-André Lureau
2020-01-07 15:04 ` [PULL 18/37] mips: baudbase is 115200 by default Marc-André Lureau
2020-01-07 15:04 ` [PULL 19/37] mips: use sysbus_add_io() Marc-André Lureau
2020-01-07 15:04 ` [PULL 20/37] mips: use sysbus_mmio_get_region() instead of internal fields Marc-André Lureau
2020-01-07 15:04 ` [PULL 21/37] sm501: make SerialMM a child, export chardev property Marc-André Lureau
2020-01-07 15:04 ` [PULL 22/37] vmmouse: replace PROP_PTR with PROP_LINK Marc-André Lureau
2020-01-07 15:04 ` [PULL 23/37] lance: " Marc-André Lureau
2020-01-07 15:04 ` [PULL 24/37] etraxfs: remove PROP_PTR usage Marc-André Lureau
2020-01-07 15:04 ` [PULL 25/37] dp8393x: replace PROP_PTR with PROP_LINK Marc-André Lureau
2020-01-07 15:04 ` [PULL 26/37] leon3: use qemu_irq framework instead of callback as property Marc-André Lureau
2020-01-07 15:04 ` [PULL 27/37] leon3: use qdev gpio facilities for the PIL Marc-André Lureau
2020-01-07 15:04 ` [PULL 28/37] qdev: use g_strcmp0() instead of open-coding it Marc-André Lureau
2020-01-07 15:04 ` [PULL 29/37] mips/cps: fix setting saar property Marc-André Lureau
2020-01-07 15:04 ` [PULL 30/37] cris: improve passing PIC interrupt vector to the CPU Marc-André Lureau
2020-01-07 15:04 ` [PULL 31/37] smbus-eeprom: remove PROP_PTR Marc-André Lureau
2020-01-07 15:04 ` [PULL 32/37] omap-intc: " Marc-André Lureau
2020-01-07 15:04 ` [PULL 33/37] omap-i2c: " Marc-André Lureau
2020-01-07 15:04 ` [PULL 34/37] omap-gpio: " Marc-André Lureau
2020-01-07 15:04 ` [PULL 35/37] qdev: remove PROP_MEMORY_REGION Marc-André Lureau
2020-01-07 15:04 ` [PULL 36/37] qdev: remove QDEV_PROP_PTR Marc-André Lureau
2020-07-06  8:44   ` Philippe Mathieu-Daudé
2020-07-06 10:01     ` Marc-André Lureau
2020-07-06 10:13       ` Philippe Mathieu-Daudé
2020-07-06 12:03         ` Markus Armbruster
2020-01-07 15:04 ` Marc-André Lureau [this message]
2020-01-10 10:31 ` [PULL 00/37] qom-ify serial and " Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200107150442.1727958-38-marcandre.lureau@redhat.com \
    --to=marcandre.lureau@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.