From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D5B9C33C8C for ; Tue, 7 Jan 2020 16:32:13 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6BEE1222D9 for ; Tue, 7 Jan 2020 16:32:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TVse+DvP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6BEE1222D9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52694 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iorm8-000064-19 for qemu-devel@archiver.kernel.org; Tue, 07 Jan 2020 11:32:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45971) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iorjx-0006bT-8z for qemu-devel@nongnu.org; Tue, 07 Jan 2020 11:29:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iorjv-0004eT-UZ for qemu-devel@nongnu.org; Tue, 07 Jan 2020 11:29:57 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:60183 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iorjv-0004e4-Qd for qemu-devel@nongnu.org; Tue, 07 Jan 2020 11:29:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578414595; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Nm5rBDcoCplmlWRAfpJUTX03Lt2BWA14BTGdBKMUPBs=; b=TVse+DvPP1lxY5mdfUaNN4AgHXU0go0jqTtfCbAYbpije+Dh2Y3d0nkMbxUZ4JhTYwHb8y VAuk4mKnsp2aZpDtXLn1Y20JUXRRNFL8NPHOlVz5GpCQmyfxlGOHYS9aRTtyLE7nkr/fYt 6CfSyNWIGYVmDozukmQs7p8Nu+EL++o= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-221-M8BApqhDPRiqYhOBDwRenA-1; Tue, 07 Jan 2020 11:29:54 -0500 Received: by mail-qt1-f200.google.com with SMTP id c8so102969qte.22 for ; Tue, 07 Jan 2020 08:29:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=SV/3gkt55AkXiObd4ttRVZfM0Ouiap0tkA8DR2mthfg=; b=PY1NKvDnK5azM9eq7OL2VyYH3a1D8Ix5Gm/TAsed8Lj/MOvL0vXEhhUq5JqlqvLQW5 X0ebiemkHJP0q0Jy+vVIt9i1uNsq1CHEaxYTJ8+au1TJ8za6R0tj//az7y997x44dkt1 gN9LS7zOYyC91Omq3m8oTnBC0l233Luh0eD5pK5d2wJn6UDlpWksQn7kMzCCqUZXbg+t DefhzRrvJ7GCVAqEoM4rrmfuBonoK5gocOfriKs2CNk3FNhRGFVDaxMYd4FyKYY+T+uX Ab7tN/LYrp+ZYciSbbeDNJa4O7/XIyHa98IB65wF+4YzTKaU/GAoE4Kb7lAdEcevKn1H l7NA== X-Gm-Message-State: APjAAAXJB/ndmCyecEzYBx9tyPkbzLgq2EoIPCo7/r+4PDYYIq0fLafl adXWlXnaF9J3Iv3hL+73MEZb5R4Kl8k7gebtcPIg78TT9+0zkrTPUMEwCnw2zn2S8ueJmhtEfgs Cl1+jntr6SeTzdCQ= X-Received: by 2002:ae9:e204:: with SMTP id c4mr104969qkc.191.1578414593235; Tue, 07 Jan 2020 08:29:53 -0800 (PST) X-Google-Smtp-Source: APXvYqzzGafIqGXWMFtMi5y/B7HlJaWT7iqZxsL3O5cyqPsyf3xHCxf/upu110K+8VtcO50lbASzzQ== X-Received: by 2002:ae9:e204:: with SMTP id c4mr104950qkc.191.1578414593003; Tue, 07 Jan 2020 08:29:53 -0800 (PST) Received: from redhat.com (bzq-79-183-34-164.red.bezeqint.net. [79.183.34.164]) by smtp.gmail.com with ESMTPSA id l49sm115569qtk.7.2020.01.07.08.29.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jan 2020 08:29:52 -0800 (PST) Date: Tue, 7 Jan 2020 11:29:48 -0500 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Subject: [PULL v3 04/32] virtio-serial-bus: fix memory leak while attach virtio-serial-bus Message-ID: <20200107162850.411448-5-mst@redhat.com> References: <20200107162850.411448-1-mst@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200107162850.411448-1-mst@redhat.com> X-Mailer: git-send-email 2.24.1.751.gd10ce2899c X-Mutt-Fcc: =sent X-MC-Unique: M8BApqhDPRiqYhOBDwRenA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Peter Maydell , Amit Shah , Pan Nengyuan , Paolo Bonzini , Euler Robot , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Pan Nengyuan ivqs/ovqs/c_ivq/c_ovq is forgot to cleanup in virtio_serial_device_unrealize, the memory leak stack is as bellow: Direct leak of 1290240 byte(s) in 180 object(s) allocated from: #0 0x7fc9bfc27560 in calloc (/usr/lib64/libasan.so.3+0xc7560) #1 0x7fc9bed6f015 in g_malloc0 (/usr/lib64/libglib-2.0.so.0+0x50015) #2 0x5650e02b83e7 in virtio_add_queue hw/virtio/virtio.c:2327 #3 0x5650e02847b5 in virtio_serial_device_realize hw/char/virtio-serial= -bus.c:1089 #4 0x5650e02b56a7 in virtio_device_realize hw/virtio/virtio.c:3504 #5 0x5650e03bf031 in device_set_realized hw/core/qdev.c:876 #6 0x5650e0531efd in property_set_bool qom/object.c:2080 #7 0x5650e053650e in object_property_set_qobject qom/qom-qobject.c:26 #8 0x5650e0533e14 in object_property_set_bool qom/object.c:1338 #9 0x5650e04c0e37 in virtio_pci_realize hw/virtio/virtio-pci.c:1801 Reported-by: Euler Robot Signed-off-by: Pan Nengyuan Cc: Laurent Vivier Cc: Amit Shah Cc: "Marc-Andr=C3=A9 Lureau" Cc: Paolo Bonzini Message-Id: <1575444716-17632-3-git-send-email-pannengyuan@huawei.com> Signed-off-by: Michael S. Tsirkin Reviewed-by: Michael S. Tsirkin --- hw/char/virtio-serial-bus.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c index 33259042a9..e1cbce3ba3 100644 --- a/hw/char/virtio-serial-bus.c +++ b/hw/char/virtio-serial-bus.c @@ -1126,9 +1126,17 @@ static void virtio_serial_device_unrealize(DeviceSta= te *dev, Error **errp) { VirtIODevice *vdev =3D VIRTIO_DEVICE(dev); VirtIOSerial *vser =3D VIRTIO_SERIAL(dev); + int i; =20 QLIST_REMOVE(vser, next); =20 + virtio_delete_queue(vser->c_ivq); + virtio_delete_queue(vser->c_ovq); + for (i =3D 0; i < vser->bus.max_nr_ports; i++) { + virtio_delete_queue(vser->ivqs[i]); + virtio_delete_queue(vser->ovqs[i]); + } + g_free(vser->ivqs); g_free(vser->ovqs); g_free(vser->ports_map); --=20 MST