From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2065CC33C8C for ; Tue, 7 Jan 2020 16:59:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E3A21206DB for ; Tue, 7 Jan 2020 16:59:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="d+WxAhYz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E3A21206DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53168 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iosCA-00074s-W2 for qemu-devel@archiver.kernel.org; Tue, 07 Jan 2020 11:59:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37886) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ios7j-0001YF-4d for qemu-devel@nongnu.org; Tue, 07 Jan 2020 11:54:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ios7i-0006Y0-4Q for qemu-devel@nongnu.org; Tue, 07 Jan 2020 11:54:30 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:32153 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ios7i-0006XT-0w for qemu-devel@nongnu.org; Tue, 07 Jan 2020 11:54:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578416069; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nFDOCPmSXH8bZUNWRQB5ZxxGg/sXOpSyOndloGfLzcg=; b=d+WxAhYznr1znLNrRP7Ez0/W1gwWMTAqHkL7uuvUOBMuDYw4dnQYU1EYla1Y3eOCPd/pLC YfKt7wjzmk2RCsGJLrNGJEcD1WH4VMwZjUEnlY4N9q2epIW5soU0E1zwaeWySgUkNyK64m SDZFRH2RvsW7NscnNjVEzZeHERxV3hg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-337-1F-4xrLHPoOnr2PhCe1c0g-1; Tue, 07 Jan 2020 11:54:26 -0500 X-MC-Unique: 1F-4xrLHPoOnr2PhCe1c0g-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 636CE800D4E; Tue, 7 Jan 2020 16:54:25 +0000 (UTC) Received: from localhost (unknown [10.36.118.91]) by smtp.corp.redhat.com (Postfix) with ESMTP id EC09385F13; Tue, 7 Jan 2020 16:54:24 +0000 (UTC) Date: Tue, 7 Jan 2020 16:54:23 +0000 From: Stefan Hajnoczi To: Daniel Henrique Barboza Subject: Re: [PATCH v1 17/59] block/dmg.c: remove unneeded 'fail' label in dmg_read_mish_block() Message-ID: <20200107165423.GA410801@stefanha-x1.localdomain> References: <20200106182425.20312-1-danielhb413@gmail.com> <20200106182425.20312-18-danielhb413@gmail.com> MIME-Version: 1.0 In-Reply-To: <20200106182425.20312-18-danielhb413@gmail.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zYM0uCDKw75PZbzx" Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, qemu-block@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --zYM0uCDKw75PZbzx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 06, 2020 at 03:23:43PM -0300, Daniel Henrique Barboza wrote: > Both the 'fail' label and 'ret' variable can be removed from the > function. Instead, call 'return -EINVAL' in the error conditions. >=20 > CC: Stefan Hajnoczi > CC: qemu-block@nongnu.org > Signed-off-by: Daniel Henrique Barboza > --- > block/dmg.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) Reviewed-by: Stefan Hajnoczi --zYM0uCDKw75PZbzx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAl4Ut78ACgkQnKSrs4Gr c8hGYAgAqAa6OqSNkw7RLXe//mM1/mCxHdPmM2l5uck0jyyR37mxbdJfPS30eUGb urohApMEDZlbez4zZsRZRm/J1h7Nt81svz25cR88vJkaaEtFuoXLZjsfhm85fo50 PBbdZ1sS/GVMdKCiSo40TgeAKVAduSzDa6fuhsTt4I7RA2MBNl5wYhQEI7Idyfo1 3RWHR5WaWc47egMaaGbtOYA1z35Gts0xJV5lgRg+pGqEDRlswxKRFYn4vN524GnL J1rxHLjStb/veh6YTfqvbqXJOKsc3tyTNChvAqjHtHrPiFbDvukKkLZdo+Ho6pY3 rqUVFBdheJEGNY9M5sr/5hP9h+cN0w== =/S9a -----END PGP SIGNATURE----- --zYM0uCDKw75PZbzx--