All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Shannon Nelson <snelson@pensando.io>
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH v2 net-next 3/4] ionic: restrict received packets to mtu size
Date: Tue, 7 Jan 2020 20:45:36 +0100	[thread overview]
Message-ID: <20200107194536.GB16895@lunn.ch> (raw)
In-Reply-To: <112c6fd3-6565-e88a-dde5-520770d9f024@pensando.io>

> Hi Andrew,
> 

Hi Shannon

> In my experience the driver typically tells the NIC about the current
> max_frame size (e.g. MTU + ETH_HLEN), the NIC only copies max_frame bytes,
> and the NIC returns an error indication on a packets that had more than
> max_frame.

Having played around with a few different NICs for DSA, it seems more
like 75% don't care about the 'MRU' and will happily accept bigger
frames.

Anyway, it does not hurt to drop received frames bigger than what you
can transmit.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

  reply	other threads:[~2020-01-07 19:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-07  3:43 [PATCH v2 net-next 0/4] ionic: driver updates Shannon Nelson
2020-01-07  3:43 ` [PATCH v2 net-next 1/4] ionic: drop use of subdevice tags Shannon Nelson
2020-01-07  3:43 ` [PATCH v2 net-next 2/4] ionic: add Rx dropped packet counter Shannon Nelson
2020-01-07  3:43 ` [PATCH v2 net-next 3/4] ionic: restrict received packets to mtu size Shannon Nelson
2020-01-07 13:09   ` Andrew Lunn
2020-01-07 18:00     ` Shannon Nelson
2020-01-07 19:45       ` Andrew Lunn [this message]
2020-01-07 21:30         ` Vladimir Oltean
2020-01-07  3:43 ` [PATCH v2 net-next 4/4] ionic: clear compiler warning on hb use before set Shannon Nelson
2020-01-07 21:05 ` [PATCH v2 net-next 0/4] ionic: driver updates David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200107194536.GB16895@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=snelson@pensando.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.