From: Jason Gunthorpe <jgg@ziepe.ca>
To: Leon Romanovsky <leon@kernel.org>
Cc: Doug Ledford <dledford@redhat.com>,
Leon Romanovsky <leonro@mellanox.com>,
RDMA mailing list <linux-rdma@vger.kernel.org>,
Parav Pandit <parav@mellanox.com>
Subject: Re: [PATCH rdma-next v1 2/4] IB/core: Let IB core distribute cache update events
Date: Tue, 7 Jan 2020 17:02:30 -0400 [thread overview]
Message-ID: <20200107210230.GA7774@ziepe.ca> (raw)
In-Reply-To: <20191212113024.336702-3-leon@kernel.org>
On Thu, Dec 12, 2019 at 01:30:22PM +0200, Leon Romanovsky wrote:
> @@ -2627,7 +2626,11 @@ struct ib_device {
> struct rcu_head rcu_head;
>
> struct list_head event_handler_list;
> - spinlock_t event_handler_lock;
> + /* Protects event_handler_list */
> + struct rw_semaphore event_handler_rwsem;
> +
> + /* Protects QP's event_handler calls and open_qp list */
> + spinlock_t event_handler_lock;
This only protects the open_qp list really, the event handler call
doesn't need a spinlock. So lets name it properly. open_list_lock ?
It is sort of weird that we globally serialize all the qp event
handlers? ie that this lock isn't in the ib_qp.
Is this deliberate and relied upon or just something random?
Jason
next prev parent reply other threads:[~2020-01-07 21:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 11:30 [PATCH rdma-next v1 0/4] Let IB core distribute cache update events Leon Romanovsky
2019-12-12 11:30 ` [PATCH rdma-next v1 1/4] IB/mlx5: Do reverse sequence during device removal Leon Romanovsky
2019-12-12 11:30 ` [PATCH rdma-next v1 2/4] IB/core: Let IB core distribute cache update events Leon Romanovsky
2020-01-07 21:02 ` Jason Gunthorpe [this message]
2020-01-08 11:35 ` Parav Pandit
2019-12-12 11:30 ` [PATCH rdma-next v1 3/4] IB/core: Cut down single member ib_cache structure Leon Romanovsky
2019-12-12 11:30 ` [PATCH rdma-next v1 4/4] IB/core: Prefix qp to event_handler_lock Leon Romanovsky
2020-01-08 0:28 ` [PATCH rdma-next v1 0/4] Let IB core distribute cache update events Jason Gunthorpe
2020-01-08 11:42 ` Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200107210230.GA7774@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=dledford@redhat.com \
--cc=leon@kernel.org \
--cc=leonro@mellanox.com \
--cc=linux-rdma@vger.kernel.org \
--cc=parav@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.