[peterz-queue:perf/cgroup 9/9] kernel/events/core.c:1591:29: error: 'struct cgroup' has no member named 'id'

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3519 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git perf/cgroup
head:   c55787fb50f1a63069b0e8afb8b00e2eb668c685
commit: c55787fb50f1a63069b0e8afb8b00e2eb668c685 [9/9] perf/cgroup: Order events in RB tree by cgroup id
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.5.0-3) 7.5.0
reproduce:
        git checkout c55787fb50f1a63069b0e8afb8b00e2eb668c685
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   kernel/events/core.c: In function 'perf_event_groups_less':
>> kernel/events/core.c:1591:29: error: 'struct cgroup' has no member named 'id'
      if (left->cgrp->css.cgroup->id < right->cgrp->css.cgroup->id)
                                ^~
   kernel/events/core.c:1591:59: error: 'struct cgroup' has no member named 'id'
      if (left->cgrp->css.cgroup->id < right->cgrp->css.cgroup->id)
                                                              ^~
   kernel/events/core.c: In function 'perf_event_groups_first':
   kernel/events/core.c:1689:17: error: 'struct cgroup' has no member named 'id'
      cgrp_id = cgrp->id;
                    ^~
   kernel/events/core.c:1706:47: error: 'struct cgroup' has no member named 'id'
       node_cgrp_id = node_event->cgrp->css.cgroup->id;
                                                  ^~
   kernel/events/core.c: In function 'perf_event_groups_next':
   kernel/events/core.c:1742:41: error: 'struct cgroup' has no member named 'id'
      curr_cgrp_id = event->cgrp->css.cgroup->id;
                                            ^~
   kernel/events/core.c:1745:40: error: 'struct cgroup' has no member named 'id'
      next_cgrp_id = next->cgrp->css.cgroup->id;
                                           ^~

vim +1591 kernel/events/core.c

  1559	
  1560	/*
  1561	 * Compare function for event groups;
  1562	 *
  1563	 * Implements complex key that first sorts by CPU and then by virtual index
  1564	 * which provides ordering when rotating groups for the same CPU.
  1565	 */
  1566	static bool
  1567	perf_event_groups_less(struct perf_event *left, struct perf_event *right)
  1568	{
  1569		if (left->cpu < right->cpu)
  1570			return true;
  1571		if (left->cpu > right->cpu)
  1572			return false;
  1573	
  1574	#ifdef CONFIG_CGROUP_PERF
  1575		if (left->cgrp != right->cgrp) {
  1576			if (!left->cgrp || !left->cgrp->css.cgroup) {
  1577				/*
  1578				 * Left has no cgroup but right does, no cgroups come
  1579				 * first.
  1580				 */
  1581				return true;
  1582			}
  1583			if (!right->cgrp || right->cgrp->css.cgroup) {
  1584				/*
  1585				 * Right has no cgroup but left does, no cgroups come
  1586				 * first.
  1587				 */
  1588				return false;
  1589			}
  1590			/* Two dissimilar cgroups, order by id. */
> 1591			if (left->cgrp->css.cgroup->id < right->cgrp->css.cgroup->id)
  1592				return true;
  1593	
  1594			return false;
  1595		}
  1596	#endif
  1597	
  1598		if (left->group_index < right->group_index)
  1599			return true;
  1600		if (left->group_index > right->group_index)
  1601			return false;
  1602	
  1603		return false;
  1604	}
  1605	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 70349 bytes --]