All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 0/1] Regression in rockchipdrm
@ 2020-01-09  7:31 ` Tobias Schramm
  0 siblings, 0 replies; 10+ messages in thread
From: Tobias Schramm @ 2020-01-09  7:31 UTC (permalink / raw)
  To: Sandy Huang, Heiko Stübner, David Airlie, Daniel Vetter
  Cc: dri-devel, linux-arm-kernel, linux-rockchip, linux-kernel,
	Tobias Schramm

commit 2589c4025f13 ("drm/rockchip: Avoid drm_dp_link helpers") changed
the datatype used for storing the display port data rate to u8.
A u8 is not sufficient to store the data rate, resulting in a crash due
to incorrect calculations.

This series resolves the issue by restoring the data type changed in
commit 2589c4025f13 to their original type.

Thanks to CrystalGamma for identifying the commit causing the regression.

v2: Keep lane count as u8

Tobias Schramm (1):
  drm/rockchip: fix integer type used for storing dp data rate

 drivers/gpu/drm/rockchip/cdn-dp-core.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.24.1


^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH v2 0/1] Regression in rockchipdrm
@ 2020-01-09  7:31 ` Tobias Schramm
  0 siblings, 0 replies; 10+ messages in thread
From: Tobias Schramm @ 2020-01-09  7:31 UTC (permalink / raw)
  To: Sandy Huang, Heiko Stübner, David Airlie, Daniel Vetter
  Cc: linux-rockchip, Tobias Schramm, linux-arm-kernel, dri-devel,
	linux-kernel

commit 2589c4025f13 ("drm/rockchip: Avoid drm_dp_link helpers") changed
the datatype used for storing the display port data rate to u8.
A u8 is not sufficient to store the data rate, resulting in a crash due
to incorrect calculations.

This series resolves the issue by restoring the data type changed in
commit 2589c4025f13 to their original type.

Thanks to CrystalGamma for identifying the commit causing the regression.

v2: Keep lane count as u8

Tobias Schramm (1):
  drm/rockchip: fix integer type used for storing dp data rate

 drivers/gpu/drm/rockchip/cdn-dp-core.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.24.1

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH v2 0/1] Regression in rockchipdrm
@ 2020-01-09  7:31 ` Tobias Schramm
  0 siblings, 0 replies; 10+ messages in thread
From: Tobias Schramm @ 2020-01-09  7:31 UTC (permalink / raw)
  To: Sandy Huang, Heiko Stübner, David Airlie, Daniel Vetter
  Cc: linux-rockchip, Tobias Schramm, linux-arm-kernel, dri-devel,
	linux-kernel

commit 2589c4025f13 ("drm/rockchip: Avoid drm_dp_link helpers") changed
the datatype used for storing the display port data rate to u8.
A u8 is not sufficient to store the data rate, resulting in a crash due
to incorrect calculations.

This series resolves the issue by restoring the data type changed in
commit 2589c4025f13 to their original type.

Thanks to CrystalGamma for identifying the commit causing the regression.

v2: Keep lane count as u8

Tobias Schramm (1):
  drm/rockchip: fix integer type used for storing dp data rate

 drivers/gpu/drm/rockchip/cdn-dp-core.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.24.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH v2 0/1] Regression in rockchipdrm
@ 2020-01-09  7:31 ` Tobias Schramm
  0 siblings, 0 replies; 10+ messages in thread
From: Tobias Schramm @ 2020-01-09  7:31 UTC (permalink / raw)
  To: Sandy Huang, Heiko Stübner, David Airlie, Daniel Vetter
  Cc: linux-rockchip, Tobias Schramm, linux-arm-kernel, dri-devel,
	linux-kernel

commit 2589c4025f13 ("drm/rockchip: Avoid drm_dp_link helpers") changed
the datatype used for storing the display port data rate to u8.
A u8 is not sufficient to store the data rate, resulting in a crash due
to incorrect calculations.

This series resolves the issue by restoring the data type changed in
commit 2589c4025f13 to their original type.

Thanks to CrystalGamma for identifying the commit causing the regression.

v2: Keep lane count as u8

Tobias Schramm (1):
  drm/rockchip: fix integer type used for storing dp data rate

 drivers/gpu/drm/rockchip/cdn-dp-core.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.24.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH v2 1/1] drm/rockchip: fix integer type used for storing dp data rate
  2020-01-09  7:31 ` Tobias Schramm
  (?)
@ 2020-01-09  7:31   ` Tobias Schramm
  -1 siblings, 0 replies; 10+ messages in thread
From: Tobias Schramm @ 2020-01-09  7:31 UTC (permalink / raw)
  To: Sandy Huang, Heiko Stübner, David Airlie, Daniel Vetter
  Cc: dri-devel, linux-arm-kernel, linux-rockchip, linux-kernel,
	Tobias Schramm

commmit 2589c4025f13 ("drm/rockchip: Avoid drm_dp_link helpers") changes
the type of variables used to store the display port data rate and
number of lanes to u8. However u8 is not sufficient to store the link
data rate of the display port.
This commit reverts the type of data rate to unsigned int.

Signed-off-by: Tobias Schramm <t.schramm@manjaro.org>
---
 drivers/gpu/drm/rockchip/cdn-dp-core.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.h b/drivers/gpu/drm/rockchip/cdn-dp-core.h
index 83c4586665b4..81ac9b658a70 100644
--- a/drivers/gpu/drm/rockchip/cdn-dp-core.h
+++ b/drivers/gpu/drm/rockchip/cdn-dp-core.h
@@ -95,7 +95,7 @@ struct cdn_dp_device {
 	struct cdn_dp_port *port[MAX_PHY];
 	u8 ports;
 	u8 max_lanes;
-	u8 max_rate;
+	unsigned int max_rate;
 	u8 lanes;
 	int active_port;
 
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH v2 1/1] drm/rockchip: fix integer type used for storing dp data rate
@ 2020-01-09  7:31   ` Tobias Schramm
  0 siblings, 0 replies; 10+ messages in thread
From: Tobias Schramm @ 2020-01-09  7:31 UTC (permalink / raw)
  To: Sandy Huang, Heiko Stübner, David Airlie, Daniel Vetter
  Cc: linux-rockchip, Tobias Schramm, linux-arm-kernel, dri-devel,
	linux-kernel

commmit 2589c4025f13 ("drm/rockchip: Avoid drm_dp_link helpers") changes
the type of variables used to store the display port data rate and
number of lanes to u8. However u8 is not sufficient to store the link
data rate of the display port.
This commit reverts the type of data rate to unsigned int.

Signed-off-by: Tobias Schramm <t.schramm@manjaro.org>
---
 drivers/gpu/drm/rockchip/cdn-dp-core.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.h b/drivers/gpu/drm/rockchip/cdn-dp-core.h
index 83c4586665b4..81ac9b658a70 100644
--- a/drivers/gpu/drm/rockchip/cdn-dp-core.h
+++ b/drivers/gpu/drm/rockchip/cdn-dp-core.h
@@ -95,7 +95,7 @@ struct cdn_dp_device {
 	struct cdn_dp_port *port[MAX_PHY];
 	u8 ports;
 	u8 max_lanes;
-	u8 max_rate;
+	unsigned int max_rate;
 	u8 lanes;
 	int active_port;
 
-- 
2.24.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH v2 1/1] drm/rockchip: fix integer type used for storing dp data rate
@ 2020-01-09  7:31   ` Tobias Schramm
  0 siblings, 0 replies; 10+ messages in thread
From: Tobias Schramm @ 2020-01-09  7:31 UTC (permalink / raw)
  To: Sandy Huang, Heiko Stübner, David Airlie, Daniel Vetter
  Cc: linux-rockchip, Tobias Schramm, linux-arm-kernel, dri-devel,
	linux-kernel

commmit 2589c4025f13 ("drm/rockchip: Avoid drm_dp_link helpers") changes
the type of variables used to store the display port data rate and
number of lanes to u8. However u8 is not sufficient to store the link
data rate of the display port.
This commit reverts the type of data rate to unsigned int.

Signed-off-by: Tobias Schramm <t.schramm@manjaro.org>
---
 drivers/gpu/drm/rockchip/cdn-dp-core.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.h b/drivers/gpu/drm/rockchip/cdn-dp-core.h
index 83c4586665b4..81ac9b658a70 100644
--- a/drivers/gpu/drm/rockchip/cdn-dp-core.h
+++ b/drivers/gpu/drm/rockchip/cdn-dp-core.h
@@ -95,7 +95,7 @@ struct cdn_dp_device {
 	struct cdn_dp_port *port[MAX_PHY];
 	u8 ports;
 	u8 max_lanes;
-	u8 max_rate;
+	unsigned int max_rate;
 	u8 lanes;
 	int active_port;
 
-- 
2.24.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* Re: [PATCH v2 1/1] drm/rockchip: fix integer type used for storing dp data rate
  2020-01-09  7:31   ` Tobias Schramm
  (?)
@ 2020-01-13 13:36     ` Heiko Stuebner
  -1 siblings, 0 replies; 10+ messages in thread
From: Heiko Stuebner @ 2020-01-13 13:36 UTC (permalink / raw)
  To: Tobias Schramm
  Cc: Sandy Huang, David Airlie, Daniel Vetter, dri-devel,
	linux-arm-kernel, linux-rockchip, linux-kernel

Am Donnerstag, 9. Januar 2020, 08:31:29 CET schrieb Tobias Schramm:
> commmit 2589c4025f13 ("drm/rockchip: Avoid drm_dp_link helpers") changes
> the type of variables used to store the display port data rate and
> number of lanes to u8. However u8 is not sufficient to store the link
> data rate of the display port.
> This commit reverts the type of data rate to unsigned int.
> 
> Signed-off-by: Tobias Schramm <t.schramm@manjaro.org>

applied to drm-misc-fixes

Thanks
Heiko



^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH v2 1/1] drm/rockchip: fix integer type used for storing dp data rate
@ 2020-01-13 13:36     ` Heiko Stuebner
  0 siblings, 0 replies; 10+ messages in thread
From: Heiko Stuebner @ 2020-01-13 13:36 UTC (permalink / raw)
  To: Tobias Schramm
  Cc: David Airlie, Sandy Huang, dri-devel, linux-kernel,
	linux-rockchip, Daniel Vetter, linux-arm-kernel

Am Donnerstag, 9. Januar 2020, 08:31:29 CET schrieb Tobias Schramm:
> commmit 2589c4025f13 ("drm/rockchip: Avoid drm_dp_link helpers") changes
> the type of variables used to store the display port data rate and
> number of lanes to u8. However u8 is not sufficient to store the link
> data rate of the display port.
> This commit reverts the type of data rate to unsigned int.
> 
> Signed-off-by: Tobias Schramm <t.schramm@manjaro.org>

applied to drm-misc-fixes

Thanks
Heiko



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH v2 1/1] drm/rockchip: fix integer type used for storing dp data rate
@ 2020-01-13 13:36     ` Heiko Stuebner
  0 siblings, 0 replies; 10+ messages in thread
From: Heiko Stuebner @ 2020-01-13 13:36 UTC (permalink / raw)
  To: Tobias Schramm
  Cc: David Airlie, Sandy Huang, dri-devel, linux-kernel,
	linux-rockchip, linux-arm-kernel

Am Donnerstag, 9. Januar 2020, 08:31:29 CET schrieb Tobias Schramm:
> commmit 2589c4025f13 ("drm/rockchip: Avoid drm_dp_link helpers") changes
> the type of variables used to store the display port data rate and
> number of lanes to u8. However u8 is not sufficient to store the link
> data rate of the display port.
> This commit reverts the type of data rate to unsigned int.
> 
> Signed-off-by: Tobias Schramm <t.schramm@manjaro.org>

applied to drm-misc-fixes

Thanks
Heiko


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-01-13 13:36 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-09  7:31 [PATCH v2 0/1] Regression in rockchipdrm Tobias Schramm
2020-01-09  7:31 ` Tobias Schramm
2020-01-09  7:31 ` Tobias Schramm
2020-01-09  7:31 ` Tobias Schramm
2020-01-09  7:31 ` [PATCH v2 1/1] drm/rockchip: fix integer type used for storing dp data rate Tobias Schramm
2020-01-09  7:31   ` Tobias Schramm
2020-01-09  7:31   ` Tobias Schramm
2020-01-13 13:36   ` Heiko Stuebner
2020-01-13 13:36     ` Heiko Stuebner
2020-01-13 13:36     ` Heiko Stuebner

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.