From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA534C282DD for ; Thu, 9 Jan 2020 12:57:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C6EFD2077C for ; Thu, 9 Jan 2020 12:57:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729821AbgAIM5g (ORCPT ); Thu, 9 Jan 2020 07:57:36 -0500 Received: from mga09.intel.com ([134.134.136.24]:49911 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727701AbgAIM5f (ORCPT ); Thu, 9 Jan 2020 07:57:35 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2020 04:57:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,413,1571727600"; d="scan'208";a="227394836" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.163]) by fmsmga001.fm.intel.com with SMTP; 09 Jan 2020 04:57:28 -0800 Received: by lahna (sSMTP sendmail emulation); Thu, 09 Jan 2020 14:57:27 +0200 Date: Thu, 9 Jan 2020 14:57:27 +0200 From: Mika Westerberg To: Andy Shevchenko Cc: Darren Hart , Lee Jones , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , x86@kernel.org, Zha Qipeng , Rajneesh Bhardwaj , "David E . Box" , Guenter Roeck , Heikki Krogerus , Greg Kroah-Hartman , Wim Van Sebroeck , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 34/36] platform/x86: intel_pmc_ipc: Convert to MFD Message-ID: <20200109125727.GG2838@lahna.fi.intel.com> References: <20200108114201.27908-1-mika.westerberg@linux.intel.com> <20200108114201.27908-35-mika.westerberg@linux.intel.com> <20200109114354.GP32742@smile.fi.intel.com> <20200109114753.GF2838@lahna.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200109114753.GF2838@lahna.fi.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 09, 2020 at 01:47:59PM +0200, Mika Westerberg wrote: > > > config INTEL_SOC_PMIC_BXTWC > > > tristate "Support for Intel Broxton Whiskey Cove PMIC" > > > - depends on INTEL_PMC_IPC > > > + depends on MFD_INTEL_PMC_BXT > > > select MFD_CORE > > > select REGMAP_IRQ > > > help > > > @@ -632,6 +632,18 @@ config MFD_INTEL_MSIC > > > Passage) chip. This chip embeds audio, battery, GPIO, etc. > > > devices used in Intel Medfield platforms. > > > > > > +config MFD_INTEL_PMC_BXT > > > + tristate "Intel PMC Driver for Broxton" > > > > > + depends on X86 && X86_PLATFORM_DEVICES && ACPI > > > > Is the X86_PLATFORM_DEVICES dependency compulsory? > > Quick grep shows that none of drivers (except nouveau) relies on it. > > Well, we need that to be able to do the "select INTEL_SCU_IPC" below. > I'm happy to change it if you have a better alternative ;-) Just to provide more information. If I don't have that dependency I get warnings like this: WARNING: unmet direct dependencies detected for INTEL_SCU_IPC Depends on [n]: X86 [=y] && X86_PLATFORM_DEVICES [=n] Selected by [y]: - MFD_INTEL_PMC_BXT [=y] && HAS_IOMEM [=y] && X86 [=y] && ACPI [=y]