From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65775C33CA2 for ; Thu, 9 Jan 2020 12:59:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 461102077B for ; Thu, 9 Jan 2020 12:59:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730251AbgAIM7q (ORCPT ); Thu, 9 Jan 2020 07:59:46 -0500 Received: from mga06.intel.com ([134.134.136.31]:45114 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728435AbgAIM7q (ORCPT ); Thu, 9 Jan 2020 07:59:46 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2020 04:59:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,413,1571727600"; d="scan'208";a="423246044" Received: from tassilo.jf.intel.com (HELO tassilo.localdomain) ([10.7.201.21]) by fmsmga006.fm.intel.com with ESMTP; 09 Jan 2020 04:59:44 -0800 Received: by tassilo.localdomain (Postfix, from userid 1000) id D19B0301003; Thu, 9 Jan 2020 04:59:44 -0800 (PST) Date: Thu, 9 Jan 2020 04:59:44 -0800 From: Andi Kleen To: Jiri Olsa Cc: Jann Horn , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Namhyung Kim , kernel list Subject: Re: "perf ftrace" segfault because ->cpus!=NULL but ->all_cpus==NULL Message-ID: <20200109125944.GS15478@tassilo.jf.intel.com> References: <20200109122443.GF52936@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200109122443.GF52936@krava> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > oops, ftrace is using evlist without event ;-) so all_cpus > will not get initialized.. > > Andi, should we initialize evlist::all_cpus with the first > cpus we get, like in the patch below? I assume perf stat -A still works for all CPUs? If yes it's ok. -andi