From: Andrew Morton <akpm@linux-foundation.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Oleksandr Natalenko <oleksandr@redhat.com>,
linux-mm@kvack.org, Arnaldo Carvalho de Melo <acme@redhat.com>,
Will Deacon <will@kernel.org>, Song Liu <songliubraving@fb.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Marc Zyngier <maz@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kallsyms: work around bogus -Wrestrict warning
Date: Thu, 9 Jan 2020 14:02:02 -0800 [thread overview]
Message-ID: <20200109140202.fd5488a2ac02f81b25d83b88@linux-foundation.org> (raw)
In-Reply-To: <20200108102602.43d4c5433eb495cdbf387e9b@kernel.org>
On Wed, 8 Jan 2020 10:26:02 +0900 Masami Hiramatsu <mhiramat@kernel.org> wrote:
> Hi Arnd,
>
> On Tue, 7 Jan 2020 22:40:26 +0100
> Arnd Bergmann <arnd@arndb.de> wrote:
>
> > gcc -O3 produces some really odd warnings for this file:
> >
> > kernel/kallsyms.c: In function 'sprint_symbol':
> > kernel/kallsyms.c:369:3: error: 'strcpy' source argument is the same as destination [-Werror=restrict]
> > strcpy(buffer, name);
> > ^~~~~~~~~~~~~~~~~~~~
> > kernel/kallsyms.c: In function 'sprint_symbol_no_offset':
> > kernel/kallsyms.c:369:3: error: 'strcpy' source argument is the same as destination [-Werror=restrict]
> > strcpy(buffer, name);
> > ^~~~~~~~~~~~~~~~~~~~
> > kernel/kallsyms.c: In function 'sprint_backtrace':
> > kernel/kallsyms.c:369:3: error: 'strcpy' source argument is the same as destination [-Werror=restrict]
> > strcpy(buffer, name);
> > ^~~~~~~~~~~~~~~~~~~~
> >
> > This obviously cannot be since it is preceded by an 'if (name != buffer)'
> > check.
>
> Hmm, this looks like a bug in gcc.
Yes, we're getting a lot of such reports. I don't think current gcc is
ready for this patch so I'll drop it, sorry.
next prev parent reply other threads:[~2020-01-09 22:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 21:40 [PATCH] kallsyms: work around bogus -Wrestrict warning Arnd Bergmann
2020-01-07 22:25 ` Andrew Morton
2020-01-08 9:23 ` Oleksandr Natalenko
2020-01-08 1:26 ` Masami Hiramatsu
2020-01-09 22:02 ` Andrew Morton [this message]
2020-01-09 22:18 ` Arnd Bergmann
2020-01-09 22:18 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200109140202.fd5488a2ac02f81b25d83b88@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=acme@redhat.com \
--cc=adobriyan@gmail.com \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maz@kernel.org \
--cc=mhiramat@kernel.org \
--cc=oleksandr@redhat.com \
--cc=songliubraving@fb.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.