From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04780C33CA2 for ; Thu, 9 Jan 2020 14:35:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C5E702077C for ; Thu, 9 Jan 2020 14:35:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578580540; bh=6WcORVtf3DjfJCucb8ciuJeOMemSw+59Xl2wf5Zg4As=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=LInq3aNyNKrXp8QoqYshjfedJWapHeXGQLF3fVI/MmXZ9z8Qpe8f8Cxu1ZQbDpwXf zm5SrOS3+qS8zrT1in2xMB/A9VJ+RsMasHsyDRWDxQw8IOdYI1M6b4ccHi/oby1/6l kvvw4Bbr5Bpromvb8OK7nMQTkmQdUeuurmIY9cEM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731737AbgAIOfk (ORCPT ); Thu, 9 Jan 2020 09:35:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:38806 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729577AbgAIOfj (ORCPT ); Thu, 9 Jan 2020 09:35:39 -0500 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0715B2077B; Thu, 9 Jan 2020 14:35:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578580539; bh=6WcORVtf3DjfJCucb8ciuJeOMemSw+59Xl2wf5Zg4As=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JLcoFRE0CEI7rPiUjb8T/kz3hk2H769jyw7uuBhU49RmZ4zEs9p46DqAOS5b2bRy9 6VyNrlThT3o75JaweEKKKaEBq8ZmQE4NHf9JZluGVF82sah/LMOlJ9OcGJhyd1Bfzg 2MMAGgxQME80cfdAM2ugWu8VvdVlTa1nwwTEC49M= Date: Thu, 9 Jan 2020 09:35:37 -0500 From: Sasha Levin To: Suzuki K Poulose Cc: stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mathieu.poirier@linaro.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Subject: Re: [stable] [PATCH 1/2] coresight: etb10: Do not call smp_processor_id from preemptible Message-ID: <20200109143537.GE1706@sasha-vm> References: <20200108110541.318672-1-suzuki.poulose@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200108110541.318672-1-suzuki.poulose@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 08, 2020 at 11:05:40AM +0000, Suzuki K Poulose wrote: >[ Upstream commit 730766bae3280a25d40ea76a53dc6342e84e6513 ] > >During a perf session we try to allocate buffers on the "node" associated >with the CPU the event is bound to. If it is not bound to a CPU, we >use the current CPU node, using smp_processor_id(). However this is unsafe >in a pre-emptible context and could generate the splats as below : > > BUG: using smp_processor_id() in preemptible [00000000] code: perf/2544 > >Use NUMA_NO_NODE hint instead of using the current node for events >not bound to CPUs. > >Fixes: 2997aa4063d97fdb39 ("coresight: etb10: implementing AUX API") >Cc: Mathieu Poirier >Signed-off-by: Suzuki K Poulose >Cc: stable # v4.9 to v4.19 >Signed-off-by: Mathieu Poirier >Link: https://lore.kernel.org/r/20190620221237.3536-5-mathieu.poirier@linaro.org I've queued this for 4.9-4.19. There was a simple conflict on 4.9 which also had to be resolved. -- Thanks, Sasha From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9B26C282DD for ; Thu, 9 Jan 2020 14:35:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF4892077B for ; Thu, 9 Jan 2020 14:35:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hyzQLAmQ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="JLcoFRE0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF4892077B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RYxuS/gN/KLknCA4leKTR7PI3uZmNCzi4oaIa7rjkz0=; b=hyzQLAmQJbDLG/N9T7CNFeNTU hLs+ZgcX0hkAcb7fRvEATo8D4aE3GHD9+IfJ72mnqXrmnDTcsPkSWn4GySYt38zBb+ePc26LS1Ul6 MDEK6Y7xqyLDqw+XPK98qnxWuUg2908cAVNrVC1w+gX6Y1DfSUQAk8Da4dhSppYpgjyTVvO7UWP/l bgg4kkWYnME/nz+jnFPbXtyXaXMZpB4btKJYkldWlCQDaFStgOwslR4uLS9aNCGAne+X/jLINm04z HxRixzfsgFBSNg0Ivdj+lDO+rX4lLcBfT7jAWEqxCKQxJGDHmxFfEvzBTOK7G6nio7195+NDtxQTd s1r3JsYKQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipYuU-00045i-BX; Thu, 09 Jan 2020 14:35:42 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipYuR-000459-Tl for linux-arm-kernel@lists.infradead.org; Thu, 09 Jan 2020 14:35:41 +0000 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0715B2077B; Thu, 9 Jan 2020 14:35:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578580539; bh=6WcORVtf3DjfJCucb8ciuJeOMemSw+59Xl2wf5Zg4As=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JLcoFRE0CEI7rPiUjb8T/kz3hk2H769jyw7uuBhU49RmZ4zEs9p46DqAOS5b2bRy9 6VyNrlThT3o75JaweEKKKaEBq8ZmQE4NHf9JZluGVF82sah/LMOlJ9OcGJhyd1Bfzg 2MMAGgxQME80cfdAM2ugWu8VvdVlTa1nwwTEC49M= Date: Thu, 9 Jan 2020 09:35:37 -0500 From: Sasha Levin To: Suzuki K Poulose Subject: Re: [stable] [PATCH 1/2] coresight: etb10: Do not call smp_processor_id from preemptible Message-ID: <20200109143537.GE1706@sasha-vm> References: <20200108110541.318672-1-suzuki.poulose@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200108110541.318672-1-suzuki.poulose@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200109_063539_979153_7E280829 X-CRM114-Status: UNSURE ( 9.08 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mathieu.poirier@linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org, gregkh@linuxfoundation.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 08, 2020 at 11:05:40AM +0000, Suzuki K Poulose wrote: >[ Upstream commit 730766bae3280a25d40ea76a53dc6342e84e6513 ] > >During a perf session we try to allocate buffers on the "node" associated >with the CPU the event is bound to. If it is not bound to a CPU, we >use the current CPU node, using smp_processor_id(). However this is unsafe >in a pre-emptible context and could generate the splats as below : > > BUG: using smp_processor_id() in preemptible [00000000] code: perf/2544 > >Use NUMA_NO_NODE hint instead of using the current node for events >not bound to CPUs. > >Fixes: 2997aa4063d97fdb39 ("coresight: etb10: implementing AUX API") >Cc: Mathieu Poirier >Signed-off-by: Suzuki K Poulose >Cc: stable # v4.9 to v4.19 >Signed-off-by: Mathieu Poirier >Link: https://lore.kernel.org/r/20190620221237.3536-5-mathieu.poirier@linaro.org I've queued this for 4.9-4.19. There was a simple conflict on 4.9 which also had to be resolved. -- Thanks, Sasha _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel