From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1378C282DD for ; Thu, 9 Jan 2020 23:11:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A91302073A for ; Thu, 9 Jan 2020 23:11:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728989AbgAIXLA (ORCPT ); Thu, 9 Jan 2020 18:11:00 -0500 Received: from mail.kernel.org ([198.145.29.99]:50956 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727876AbgAIXLA (ORCPT ); Thu, 9 Jan 2020 18:11:00 -0500 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C447320656; Thu, 9 Jan 2020 23:10:57 +0000 (UTC) Date: Thu, 9 Jan 2020 18:10:55 -0500 From: Steven Rostedt To: Masami Hiramatsu Cc: Frank Rowand , Ingo Molnar , Randy Dunlap , Namhyung Kim , Tim Bird , Jiri Olsa , Arnaldo Carvalho de Melo , Tom Zanussi , Rob Herring , Andrew Morton , Thomas Gleixner , Greg Kroah-Hartman , Alexey Dobriyan , Jonathan Corbet , Linus Torvalds , linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 00/22] tracing: bootconfig: Boot-time tracing and Extra boot config Message-ID: <20200109181055.1999b344@gandalf.local.home> In-Reply-To: <157736902773.11126.2531161235817081873.stgit@devnote2> References: <157736902773.11126.2531161235817081873.stgit@devnote2> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 26 Dec 2019 23:03:48 +0900 Masami Hiramatsu wrote: > Hello, > > This is the 5th version of the series for the boot-time tracing. > > Previous version is here. > > https://lkml.kernel.org/r/157528159833.22451.14878731055438721716.stgit@devnote2 Hi Masami, I applied all your patches to a test branch and was playing with it a little. This seems fine to me and works well (and very easy to use). Probably could use some more examples, but that's just a nit. If nobody has any issues with this code, I'll wait for v6 with the fixes to issues found in this series, and I'll happily apply them for linux-next. -- Steve > > In this version, I removed RFC tag from the series. > Changes from the v4 are here, updating bootconfig things. > > - [1/22] Fix help comment and indent of Kconfig. > Restrict available characters in values(*) > Drop backslash escape from quoted value(**) > - [3/22] Fix Makefile to compile tool correctly > Remove unused pattern from Makefile > - [4/22] Show test target bootconfig > Add printable value testcases > Add bad array testcase > - [9/22] Fix TOC list > Add notes about available characters. > Fix to use correct quotes (``) for .rst. > > (*) this is for preventing admin from shoot himself. > (**) this rule is from legacy command line. > > Boot-time tracing features are not modified. I know Tom is working > on exporting synthetic event (and dynamic events) APIs for module. > If that APIs are merged first, I will update my series on top > of that. > > This series can be applied on v5.5-rc3 or directly available at; > > https://github.com/mhiramat/linux.git ftrace-boottrace-v5 > >