From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4DEAC282DD for ; Thu, 9 Jan 2020 18:39:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6FE6D20678 for ; Thu, 9 Jan 2020 18:39:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XWqE0aPm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6FE6D20678 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36216 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipci0-00025J-Iu for qemu-devel@archiver.kernel.org; Thu, 09 Jan 2020 13:39:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50215) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipcf8-0006BA-5T for qemu-devel@nongnu.org; Thu, 09 Jan 2020 13:36:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ipcf6-0003fu-7a for qemu-devel@nongnu.org; Thu, 09 Jan 2020 13:36:05 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:57419 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ipcf6-0003dH-37 for qemu-devel@nongnu.org; Thu, 09 Jan 2020 13:36:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578594963; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ugIuBw/TKifcdGwVVpXsvGNUKUYYbBiXDCY1q1lEIOs=; b=XWqE0aPmyQr41UUd0JY220Otwd5BeMI+fo08WTH0di1CpNsxau10Ou8B0Vsiq+xKHxmpf6 CnI8U3g/b74oK2mOTWUcGbdm/DEHdTv58pd7Q+0VjVVRPVlHLvbp6LLRuEd8X9zMTjedwa cggiBsPtOvPqZi4huEBGKAOHnz5nrjQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-67-dX4PGrMqNEmmRFAqDaUmJQ-1; Thu, 09 Jan 2020 13:35:59 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2FC73100551A; Thu, 9 Jan 2020 18:35:58 +0000 (UTC) Received: from linux.fritz.box.com (ovpn-117-193.ams2.redhat.com [10.36.117.193]) by smtp.corp.redhat.com (Postfix) with ESMTP id 13736691AD; Thu, 9 Jan 2020 18:35:56 +0000 (UTC) From: Kevin Wolf To: qemu-devel@nongnu.org Subject: [PATCH 0/4] qmp: Optionally run handlers in coroutines Date: Thu, 9 Jan 2020 19:35:41 +0100 Message-Id: <20200109183545.27452-1-kwolf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: dX4PGrMqNEmmRFAqDaUmJQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, marcandre.lureau@gmail.com, armbru@redhat.com, qemu-block@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Some QMP command handlers can block the main loop for a relatively long time, for example because they perform some I/O. This is quite nasty. Allowing such handlers to run in a coroutine where they can yield (and therefore release the BQL) while waiting for an event such as I/O completion solves the problem. This series adds the infrastructure to allow this and switches block_resize to run in a coroutine as a first example. This is an alternative solution to Marc-Andr=C3=A9's "monitor: add asynchronous command type" series. Kevin Wolf (4): qapi: Add a 'coroutine' flag for commands block: Mark 'block_resize' as coroutine vl: Initialise main loop earlier qmp: Move dispatcher to a coroutine qapi/block-core.json | 3 +- tests/qapi-schema/qapi-schema-test.json | 1 + docs/devel/qapi-code-gen.txt | 4 ++ include/qapi/qmp/dispatch.h | 3 + monitor/monitor-internal.h | 5 +- monitor/monitor.c | 24 ++++--- monitor/qmp.c | 83 ++++++++++++++++--------- qapi/qmp-dispatch.c | 38 ++++++++++- tests/test-qmp-cmds.c | 4 ++ vl.c | 10 +-- scripts/qapi/commands.py | 17 +++-- scripts/qapi/doc.py | 2 +- scripts/qapi/expr.py | 4 +- scripts/qapi/introspect.py | 2 +- scripts/qapi/schema.py | 9 ++- tests/qapi-schema/qapi-schema-test.out | 2 + tests/qapi-schema/test-qapi.py | 7 ++- 17 files changed, 155 insertions(+), 63 deletions(-) --=20 2.20.1