From: Dmitry Safonov <dima@arista.com>
To: linux-kernel@vger.kernel.org
Cc: Dmitry Safonov <0x7f454c46@gmail.com>,
Dmitry Safonov <dima@arista.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
Vasiliy Khoruzhick <vasilykh@arista.com>,
linux-serial@vger.kernel.org, Iurii Zaikin <yzaikin@google.com>,
Luis Chamberlain <mcgrof@kernel.org>,
Kees Cook <keescook@chromium.org>,
linux-fsdevel@vger.kernel.org
Subject: [PATCH-next 0/3] serial/sysrq: Add MAGIC_SYSRQ_SERIAL_SEQUENCE
Date: Thu, 9 Jan 2020 21:54:41 +0000 [thread overview]
Message-ID: <20200109215444.95995-1-dima@arista.com> (raw)
Magic sysrq has proven for Arista usecases to be useful for debugging
issues in field, over serial line when the switch is in such bad state
that it can't accept network connections anymore.
Unfortunately, having sysrq always enabled doesn't work for some
embedded boards that tend to generate garbage on serial line (including
BREAKs). Since commit 732dbf3a6104 ("serial: do not accept sysrq
characters via serial port"), it's possible to keep sysrq enabled, but
over serial line.
Add a way to enable sysrq on a uart, where currently it can be
constantly either on or off (CONFIG_MAGIC_SYSRQ_SERIAL).
While doing so, cleanup __sysrq_enabled and serial_core header file.
Sending against -next tree as it's based on removing SUPPORT_SYSRQ
ifdeffery [1].
[1]: https://lkml.kernel.org/r/20191213000657.931618-1-dima@arista.com
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.com>
Cc: Vasiliy Khoruzhick <vasilykh@arista.com>
Cc: linux-serial@vger.kernel.org
Thanks,
Dmitry
Dmitry Safonov (3):
serial_core: Move sysrq functions from header file
sysctl/sysrq: Remove __sysrq_enabled copy
serial/sysrq: Add MAGIC_SYSRQ_SERIAL_SEQUENCE
drivers/tty/serial/serial_core.c | 123 +++++++++++++++++++++++++++++++
drivers/tty/sysrq.c | 7 ++
include/linux/serial_core.h | 86 ++-------------------
include/linux/sysrq.h | 1 +
kernel/sysctl.c | 41 ++++++-----
lib/Kconfig.debug | 8 ++
6 files changed, 167 insertions(+), 99 deletions(-)
--
2.24.1
next reply other threads:[~2020-01-09 21:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 21:54 Dmitry Safonov [this message]
2020-01-09 21:54 ` [PATCH-next 1/3] serial_core: Move sysrq functions from header file Dmitry Safonov
2020-01-10 16:50 ` Greg Kroah-Hartman
2020-01-09 21:54 ` [PATCH-next 2/3] sysctl/sysrq: Remove __sysrq_enabled copy Dmitry Safonov
2020-01-10 3:19 ` Iurii Zaikin
2020-01-10 21:48 ` Dmitry Safonov
2020-01-10 16:40 ` Greg Kroah-Hartman
2020-01-10 21:45 ` Dmitry Safonov
2020-01-10 22:01 ` Greg Kroah-Hartman
2020-01-09 21:54 ` [PATCH-next 3/3] serial/sysrq: Add MAGIC_SYSRQ_SERIAL_SEQUENCE Dmitry Safonov
2020-01-09 23:53 ` Randy Dunlap
2020-01-10 22:02 ` Dmitry Safonov
2020-01-10 16:46 ` Greg Kroah-Hartman
2020-01-10 22:32 ` Dmitry Safonov
2020-01-14 19:10 ` Dmitry Safonov
2020-01-15 12:42 ` Greg Kroah-Hartman
2020-01-10 16:50 ` Joe Perches
2020-01-10 22:10 ` Dmitry Safonov
2020-01-11 14:08 ` Joe Perches
2020-01-10 19:01 ` kbuild test robot
2020-01-10 19:01 ` kbuild test robot
2020-01-10 19:20 ` kbuild test robot
2020-01-10 19:20 ` kbuild test robot
2020-01-11 10:52 ` kbuild test robot
2020-01-11 10:52 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200109215444.95995-1-dima@arista.com \
--to=dima@arista.com \
--cc=0x7f454c46@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=vasilykh@arista.com \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.