From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CC35C33CA3 for ; Fri, 10 Jan 2020 07:13:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E7D5D2080D for ; Fri, 10 Jan 2020 07:13:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578640412; bh=u3nc95r1jFTqR3hP2067iUtba3cgdved2A2t1XDWrfE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Ci0EC/49yrfYUO7UOr9z1dH5dewnTrFDTIAMpo5IaGmU0dTCOEfWy80Q0XWNSFwST NBj+t6fNAMocY9lREbdl/Vrhz60++cApw7whtgAyFDKU7A9AMtPTNcj9bSgXpB+8YZ 4trer36Yn0Z4ZzGWR0iOiERsAaQIjY0a0u5eQzus= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726264AbgAJHNb (ORCPT ); Fri, 10 Jan 2020 02:13:31 -0500 Received: from mail.kernel.org ([198.145.29.99]:32908 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725835AbgAJHNb (ORCPT ); Fri, 10 Jan 2020 02:13:31 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B58732073A; Fri, 10 Jan 2020 07:13:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578640410; bh=u3nc95r1jFTqR3hP2067iUtba3cgdved2A2t1XDWrfE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AkJi4eIokl+gNJwTiX5L2s1jG52dPvA6Jgftv8vlJJE5IuPr77FpapwCggwQGjNBo Lc0xGT2B6tpVICrV2wlunZa2Te4JDR3hhMlVY2bVtYkAn52knN+iraay07u7eZGKjt FQGPESEPyb1w3Ih9YAIsyu1MxcWPmabID1Su8r4E= Date: Fri, 10 Jan 2020 08:13:28 +0100 From: Greg Kroah-Hartman To: =?iso-8859-1?Q?S=E9bastien?= Szymanski Cc: Lucas Stach , Sasha Levin , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Srinivas Kandagatla , linux-arm-kernel@lists.infradead.org, Fabio Estevam Subject: Re: [PATCH AUTOSEL 4.19 102/177] nvmem: imx-ocotp: reset error status on probe Message-ID: <20200110071328.GA100095@kroah.com> References: <20191210213221.11921-1-sashal@kernel.org> <20191210213221.11921-102-sashal@kernel.org> <2dc7001f362358dfdcbef080118b23cabaa03a40.camel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 07, 2020 at 08:29:12PM +0100, Sébastien Szymanski wrote: > Hi Lucas, > > > On 7 Jan 2020, at 18:53, Lucas Stach wrote: > > > > Hi Sébastien, > > > > On Di, 2020-01-07 at 15:50 +0100, Sébastien Szymanski wrote: > >> On 12/10/19 10:31 PM, Sasha Levin wrote: > >>> From: Lucas Stach > >>> > >>> [ Upstream commit c33c585f1b3a99d53920bdac614aca461d8db06f ] > >>> > >>> If software running before the OCOTP driver is loaded left the > >>> controller with the error status pending, the driver will never > >>> be able to complete the read timing setup. Reset the error status > >>> on probe to make sure the controller is in usable state. > >>> > >>> Signed-off-by: Lucas Stach > >>> Signed-off-by: Srinivas Kandagatla > >>> Link: https://lore.kernel.org/r/20191029114240.14905-6-srinivas.kandagatla@linaro.org > >>> Signed-off-by: Greg Kroah-Hartman > >>> Signed-off-by: Sasha Levin > >>> --- > >>> drivers/nvmem/imx-ocotp.c | 4 ++++ > >>> 1 file changed, 4 insertions(+) > >>> > >>> diff --git a/drivers/nvmem/imx-ocotp.c b/drivers/nvmem/imx-ocotp.c > >>> index afb429a417fe0..926d9cc080cf4 100644 > >>> --- a/drivers/nvmem/imx-ocotp.c > >>> +++ b/drivers/nvmem/imx-ocotp.c > >>> @@ -466,6 +466,10 @@ static int imx_ocotp_probe(struct platform_device *pdev) > >>> if (IS_ERR(priv->clk)) > >>> return PTR_ERR(priv->clk); > >>> > >>> + clk_prepare_enable(priv->clk); > >>> + imx_ocotp_clr_err_if_set(priv->base); > >>> + clk_disable_unprepare(priv->clk); > >>> + > >>> priv->params = of_device_get_match_data(&pdev->dev); > >>> imx_ocotp_nvmem_config.size = 4 * priv->params->nregs; > >>> imx_ocotp_nvmem_config.dev = dev; > >>> > >> > >> Hi, > >> > >> This patch makes kernel 4.19.{92,93} hang at boot on my i.MX6ULL based > >> board. It hanks at > >> > >> [ 3.730078] cpu cpu0: Linked as a consumer to regulator.2 > >> [ 3.737760] cpu cpu0: Linked as a consumer to regulator.3 > >> > >> Full boot log is here: https://pastebin.com/TS8EFxkr > >> > >> The config is imx_v6_v7_defconfig. > >> > >> Reverting it makes the kernels boot again. > > > > Can you check if it actually hangs in imx_ocotp_clr_err_if_set(), or if > > the clk_disable_unprepare() is the culprit? > > > > If the clock disable hangs the system there is a missing clock > > reference somewhere else that we need to track down. > > Yes, the system hangs in the imx6q-cpufreq driver, here: > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/cpufreq/imx6q-cpufreq.c?h=v4.19.93#n322 > > Kernel 5.4.8 works thanks to commits: > > 2733fb0d0699 (“cpufreq: imx6q: read OCOTP through nvmem for imx6ul/imx6ull”) > 92f0eb08c66a ("ARM: dts: imx6ul: use nvmem-cells for cpu speed grading”) I've now queued both of these up for 4.19, hopefully that should resolve this issue, thanks! greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83C1AC33C99 for ; Fri, 10 Jan 2020 07:13:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 53BE32077C for ; Fri, 10 Jan 2020 07:13:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gxBe+PsV"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="AkJi4eIo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 53BE32077C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=q7l6xt5717kXeKCzATRjRUm3i6cT/AJF7OYeaBlNX+U=; b=gxBe+PsVeWREa4 9VlhCJCkydrJCjSdgq0icXBxoc/Vbw0+zJSPZ21CB3kZbZf6yVbaZ7BOfIoTn2m2iTOHppi0OnkfH 66d6zPSsUXibHLIlvcp3fSY/j1NLv58nI2tCnHXY+V/A3pAyJWK4XYSqWRFRNK/iahX6jr9roxmOv 3XLBpGA7INTS+ZfZF7eMDTrh2iDEAqjSQfyUNWbDLUGJJ4Qllv7CLgahyW6DhulBRFlYcQ9U84OkG wV1JINx+5cAZ1VT50Q/nsdcGveci6o3Qb2r0kdvaGvk5yZaEI6bCqX/jNcljarRGNARrz0Mzo91LY X+Y/taWg8y8MIIGmcHew==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipoUC-0001UO-UL; Fri, 10 Jan 2020 07:13:36 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipoU7-0001SE-DA for linux-arm-kernel@lists.infradead.org; Fri, 10 Jan 2020 07:13:34 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B58732073A; Fri, 10 Jan 2020 07:13:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578640410; bh=u3nc95r1jFTqR3hP2067iUtba3cgdved2A2t1XDWrfE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AkJi4eIokl+gNJwTiX5L2s1jG52dPvA6Jgftv8vlJJE5IuPr77FpapwCggwQGjNBo Lc0xGT2B6tpVICrV2wlunZa2Te4JDR3hhMlVY2bVtYkAn52knN+iraay07u7eZGKjt FQGPESEPyb1w3Ih9YAIsyu1MxcWPmabID1Su8r4E= Date: Fri, 10 Jan 2020 08:13:28 +0100 From: Greg Kroah-Hartman To: =?iso-8859-1?Q?S=E9bastien?= Szymanski Subject: Re: [PATCH AUTOSEL 4.19 102/177] nvmem: imx-ocotp: reset error status on probe Message-ID: <20200110071328.GA100095@kroah.com> References: <20191210213221.11921-1-sashal@kernel.org> <20191210213221.11921-102-sashal@kernel.org> <2dc7001f362358dfdcbef080118b23cabaa03a40.camel@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200109_231331_489634_FFD7881C X-CRM114-Status: GOOD ( 20.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sasha Levin , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Srinivas Kandagatla , Fabio Estevam , linux-arm-kernel@lists.infradead.org, Lucas Stach Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBKYW4gMDcsIDIwMjAgYXQgMDg6Mjk6MTJQTSArMDEwMCwgU8OpYmFzdGllbiBTenlt YW5za2kgd3JvdGU6Cj4gSGkgTHVjYXMsCj4gCj4gPiBPbiA3IEphbiAyMDIwLCBhdCAxODo1Mywg THVjYXMgU3RhY2ggPGwuc3RhY2hAcGVuZ3V0cm9uaXguZGU+IHdyb3RlOgo+ID4gCj4gPiBIaSBT w6liYXN0aWVuLAo+ID4gCj4gPiBPbiBEaSwgMjAyMC0wMS0wNyBhdCAxNTo1MCArMDEwMCwgU8Op YmFzdGllbiBTenltYW5za2kgd3JvdGU6Cj4gPj4gT24gMTIvMTAvMTkgMTA6MzEgUE0sIFNhc2hh IExldmluIHdyb3RlOgo+ID4+PiBGcm9tOiBMdWNhcyBTdGFjaCA8bC5zdGFjaEBwZW5ndXRyb25p eC5kZT4KPiA+Pj4gCj4gPj4+IFsgVXBzdHJlYW0gY29tbWl0IGMzM2M1ODVmMWIzYTk5ZDUzOTIw YmRhYzYxNGFjYTQ2MWQ4ZGIwNmYgXQo+ID4+PiAKPiA+Pj4gSWYgc29mdHdhcmUgcnVubmluZyBi ZWZvcmUgdGhlIE9DT1RQIGRyaXZlciBpcyBsb2FkZWQgbGVmdCB0aGUKPiA+Pj4gY29udHJvbGxl ciB3aXRoIHRoZSBlcnJvciBzdGF0dXMgcGVuZGluZywgdGhlIGRyaXZlciB3aWxsIG5ldmVyCj4g Pj4+IGJlIGFibGUgdG8gY29tcGxldGUgdGhlIHJlYWQgdGltaW5nIHNldHVwLiBSZXNldCB0aGUg ZXJyb3Igc3RhdHVzCj4gPj4+IG9uIHByb2JlIHRvIG1ha2Ugc3VyZSB0aGUgY29udHJvbGxlciBp cyBpbiB1c2FibGUgc3RhdGUuCj4gPj4+IAo+ID4+PiBTaWduZWQtb2ZmLWJ5OiBMdWNhcyBTdGFj aCA8bC5zdGFjaEBwZW5ndXRyb25peC5kZT4KPiA+Pj4gU2lnbmVkLW9mZi1ieTogU3Jpbml2YXMg S2FuZGFnYXRsYSA8c3Jpbml2YXMua2FuZGFnYXRsYUBsaW5hcm8ub3JnPgo+ID4+PiBMaW5rOiBo dHRwczovL2xvcmUua2VybmVsLm9yZy9yLzIwMTkxMDI5MTE0MjQwLjE0OTA1LTYtc3Jpbml2YXMu a2FuZGFnYXRsYUBsaW5hcm8ub3JnCj4gPj4+IFNpZ25lZC1vZmYtYnk6IEdyZWcgS3JvYWgtSGFy dG1hbiA8Z3JlZ2toQGxpbnV4Zm91bmRhdGlvbi5vcmc+Cj4gPj4+IFNpZ25lZC1vZmYtYnk6IFNh c2hhIExldmluIDxzYXNoYWxAa2VybmVsLm9yZz4KPiA+Pj4gLS0tCj4gPj4+IGRyaXZlcnMvbnZt ZW0vaW14LW9jb3RwLmMgfCA0ICsrKysKPiA+Pj4gMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9u cygrKQo+ID4+PiAKPiA+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbnZtZW0vaW14LW9jb3RwLmMg Yi9kcml2ZXJzL252bWVtL2lteC1vY290cC5jCj4gPj4+IGluZGV4IGFmYjQyOWE0MTdmZTAuLjky NmQ5Y2MwODBjZjQgMTAwNjQ0Cj4gPj4+IC0tLSBhL2RyaXZlcnMvbnZtZW0vaW14LW9jb3RwLmMK PiA+Pj4gKysrIGIvZHJpdmVycy9udm1lbS9pbXgtb2NvdHAuYwo+ID4+PiBAQCAtNDY2LDYgKzQ2 NiwxMCBAQCBzdGF0aWMgaW50IGlteF9vY290cF9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNl ICpwZGV2KQo+ID4+PiAJaWYgKElTX0VSUihwcml2LT5jbGspKQo+ID4+PiAJCXJldHVybiBQVFJf RVJSKHByaXYtPmNsayk7Cj4gPj4+IAo+ID4+PiArCWNsa19wcmVwYXJlX2VuYWJsZShwcml2LT5j bGspOwo+ID4+PiArCWlteF9vY290cF9jbHJfZXJyX2lmX3NldChwcml2LT5iYXNlKTsKPiA+Pj4g KwljbGtfZGlzYWJsZV91bnByZXBhcmUocHJpdi0+Y2xrKTsKPiA+Pj4gKwo+ID4+PiAJcHJpdi0+ cGFyYW1zID0gb2ZfZGV2aWNlX2dldF9tYXRjaF9kYXRhKCZwZGV2LT5kZXYpOwo+ID4+PiAJaW14 X29jb3RwX252bWVtX2NvbmZpZy5zaXplID0gNCAqIHByaXYtPnBhcmFtcy0+bnJlZ3M7Cj4gPj4+ IAlpbXhfb2NvdHBfbnZtZW1fY29uZmlnLmRldiA9IGRldjsKPiA+Pj4gCj4gPj4gCj4gPj4gSGks Cj4gPj4gCj4gPj4gVGhpcyBwYXRjaCBtYWtlcyBrZXJuZWwgNC4xOS57OTIsOTN9IGhhbmcgYXQg Ym9vdCBvbiBteSBpLk1YNlVMTCBiYXNlZAo+ID4+IGJvYXJkLiBJdCBoYW5rcyBhdAo+ID4+IAo+ ID4+IFsgICAgMy43MzAwNzhdIGNwdSBjcHUwOiBMaW5rZWQgYXMgYSBjb25zdW1lciB0byByZWd1 bGF0b3IuMgo+ID4+IFsgICAgMy43Mzc3NjBdIGNwdSBjcHUwOiBMaW5rZWQgYXMgYSBjb25zdW1l ciB0byByZWd1bGF0b3IuMwo+ID4+IAo+ID4+IEZ1bGwgYm9vdCBsb2cgaXMgaGVyZTogaHR0cHM6 Ly9wYXN0ZWJpbi5jb20vVFM4RUZ4a3IKPiA+PiAKPiA+PiBUaGUgY29uZmlnIGlzIGlteF92Nl92 N19kZWZjb25maWcuCj4gPj4gCj4gPj4gUmV2ZXJ0aW5nIGl0IG1ha2VzIHRoZSBrZXJuZWxzIGJv b3QgYWdhaW4uCj4gPiAKPiA+IENhbiB5b3UgY2hlY2sgaWYgaXQgYWN0dWFsbHkgaGFuZ3MgaW4g aW14X29jb3RwX2Nscl9lcnJfaWZfc2V0KCksIG9yIGlmCj4gPiB0aGUgY2xrX2Rpc2FibGVfdW5w cmVwYXJlKCkgaXMgdGhlIGN1bHByaXQ/Cj4gPiAKPiA+IElmIHRoZSBjbG9jayBkaXNhYmxlIGhh bmdzIHRoZSBzeXN0ZW0gdGhlcmUgaXMgYSBtaXNzaW5nIGNsb2NrCj4gPiByZWZlcmVuY2Ugc29t ZXdoZXJlIGVsc2UgdGhhdCB3ZSBuZWVkIHRvIHRyYWNrIGRvd24uCj4gCj4gWWVzLCB0aGUgc3lz dGVtIGhhbmdzIGluIHRoZSBpbXg2cS1jcHVmcmVxIGRyaXZlciwgaGVyZToKPiBodHRwczovL2dp dC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dpdC9zdGFibGUvbGludXguZ2l0L3Ry ZWUvZHJpdmVycy9jcHVmcmVxL2lteDZxLWNwdWZyZXEuYz9oPXY0LjE5LjkzI24zMjIKPiAKPiBL ZXJuZWwgNS40Ljggd29ya3MgdGhhbmtzIHRvIGNvbW1pdHM6Cj4gCj4gMjczM2ZiMGQwNjk5ICji gJxjcHVmcmVxOiBpbXg2cTogcmVhZCBPQ09UUCB0aHJvdWdoIG52bWVtIGZvciBpbXg2dWwvaW14 NnVsbOKAnSkKPiA5MmYwZWIwOGM2NmEgKCJBUk06IGR0czogaW14NnVsOiB1c2UgbnZtZW0tY2Vs bHMgZm9yIGNwdSBzcGVlZCBncmFkaW5n4oCdKQoKSSd2ZSBub3cgcXVldWVkIGJvdGggb2YgdGhl c2UgdXAgZm9yIDQuMTksIGhvcGVmdWxseSB0aGF0IHNob3VsZCByZXNvbHZlCnRoaXMgaXNzdWUs IHRoYW5rcyEKCmdyZWcgay1oCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==