From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD9BEC33CA2 for ; Fri, 10 Jan 2020 08:02:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 907D020678 for ; Fri, 10 Jan 2020 08:02:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578643335; bh=EGGrFg82AwWBngiHY+ftg7F0R1HyNOaQp8gvY2ISO+Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=OgQBNqn8gy/FsVu5UwIaSJjqlbuGYaxEsEPgFUaWlKp+dmFCW9XXOZXyxmBYCJJCY Fi139ESie4HbC8FBZScd1bWi+9FpXOewdzYAdJ+dfO1UBN6kivvecbyq5UVMVab0Lv 3hiAn0XE06OrrGm03KWy9J4n7OzzjZjK858bs4M8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726826AbgAJICM (ORCPT ); Fri, 10 Jan 2020 03:02:12 -0500 Received: from mail.kernel.org ([198.145.29.99]:56776 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726401AbgAJICM (ORCPT ); Fri, 10 Jan 2020 03:02:12 -0500 Received: from localhost (unknown [223.226.110.118]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 21B1320678; Fri, 10 Jan 2020 08:02:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578643332; bh=EGGrFg82AwWBngiHY+ftg7F0R1HyNOaQp8gvY2ISO+Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=u0L3uzcmQqZZM6x9wv0Y7nfmO3uZwSBsIuGcuVnBO/opMAojueHHAOkK03CZ7Faaj Iov7lqHgklf9rtbq3N+HLmG94IvqUgy/rF/MQH6WWFiPKoWfD+I6nEKKtrfEl2Rqo1 iEmuf/kkc7kUlQpjJOMY7r1rkSL3mBwBxpEGxywA= Date: Fri, 10 Jan 2020 13:31:56 +0530 From: Vinod Koul To: Kunihiko Hayashi Cc: Dan Williams , Masahiro Yamada , Rob Herring , Mark Rutland , dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Masami Hiramatsu , Jassi Brar Subject: Re: [PATCH 2/2] dmaengine: uniphier-xdmac: Add UniPhier external DMA controller driver Message-ID: <20200110080156.GG2818@vkoul-mobl> References: <1576630620-1977-3-git-send-email-hayashi.kunihiko@socionext.com> <20191227063411.GG3006@vkoul-mobl> <20200109211219.57FC.4A936039@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200109211219.57FC.4A936039@socionext.com> Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 09-01-20, 21:12, Kunihiko Hayashi wrote: > Hi Vinod, > > Thank you for your comment. > > On Fri, 27 Dec 2019 12:04:11 +0530 wrote: > > > On 18-12-19, 09:57, Kunihiko Hayashi wrote: > > > This adds external DMA controller driver implemented in Socionext > > > UniPhier SoCs. This driver supports DMA_MEMCPY and DMA_SLAVE modes. > > > > > > Since this driver does not support the the way to transfer size > > > unaligned to burst width, 'src_maxburst' or 'dst_maxburst' of > > > > You mean driver does not support any unaligned bursts? > > Yes. If transfer size is unaligned to burst size, the final transfer > will be overrun. That is fine, you shoudl return error for bursts which are not aligned when preparing the descriptors -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8E78C33CA2 for ; Fri, 10 Jan 2020 08:02:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 86E2720678 for ; Fri, 10 Jan 2020 08:02:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Tnu6+iTe"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="u0L3uzcm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 86E2720678 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iReek/tXuVplTGyo9ChE3BEMSKMRCler2ZqGybwCGFI=; b=Tnu6+iTeXk8s4U 9HM3GUAq94nGhbfN5hurTPEzhZOFHwe6mdZU/nubkIhQ39zmNOkKkrzooqq61Rbffn8Rg1F6T8pUZ 8kz+DiCP5z8aJsFiuoUViQI14YqfMRNSKPx/pMqZG2F5j90TLE+yFev/DEc+lPp7pg/t1zW6A02w6 2sEwSUht7c3JK5ggWqLKvo4iixA0Gs7XRTSZwR6azrU7Cuajwh5czgNs+xwtHMKnywdDLRC/okwAF rPwuZYFfM72IPiLWm1Raa8H4ghy0s+MNR9KGQlx6X4lWOyws+gfVmdgFkJnUo4rrkgdksPkHjcOU4 qV8S+CS/FUpnMdHJZ3tQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ippFH-0001HO-FW; Fri, 10 Jan 2020 08:02:15 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ippFE-0001H1-Ra for linux-arm-kernel@lists.infradead.org; Fri, 10 Jan 2020 08:02:14 +0000 Received: from localhost (unknown [223.226.110.118]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 21B1320678; Fri, 10 Jan 2020 08:02:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578643332; bh=EGGrFg82AwWBngiHY+ftg7F0R1HyNOaQp8gvY2ISO+Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=u0L3uzcmQqZZM6x9wv0Y7nfmO3uZwSBsIuGcuVnBO/opMAojueHHAOkK03CZ7Faaj Iov7lqHgklf9rtbq3N+HLmG94IvqUgy/rF/MQH6WWFiPKoWfD+I6nEKKtrfEl2Rqo1 iEmuf/kkc7kUlQpjJOMY7r1rkSL3mBwBxpEGxywA= Date: Fri, 10 Jan 2020 13:31:56 +0530 From: Vinod Koul To: Kunihiko Hayashi Subject: Re: [PATCH 2/2] dmaengine: uniphier-xdmac: Add UniPhier external DMA controller driver Message-ID: <20200110080156.GG2818@vkoul-mobl> References: <1576630620-1977-3-git-send-email-hayashi.kunihiko@socionext.com> <20191227063411.GG3006@vkoul-mobl> <20200109211219.57FC.4A936039@socionext.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200109211219.57FC.4A936039@socionext.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200110_000212_930064_783A1923 X-CRM114-Status: GOOD ( 14.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Masami Hiramatsu , Jassi Brar , linux-kernel@vger.kernel.org, Masahiro Yamada , Rob Herring , dmaengine@vger.kernel.org, Dan Williams , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09-01-20, 21:12, Kunihiko Hayashi wrote: > Hi Vinod, > > Thank you for your comment. > > On Fri, 27 Dec 2019 12:04:11 +0530 wrote: > > > On 18-12-19, 09:57, Kunihiko Hayashi wrote: > > > This adds external DMA controller driver implemented in Socionext > > > UniPhier SoCs. This driver supports DMA_MEMCPY and DMA_SLAVE modes. > > > > > > Since this driver does not support the the way to transfer size > > > unaligned to burst width, 'src_maxburst' or 'dst_maxburst' of > > > > You mean driver does not support any unaligned bursts? > > Yes. If transfer size is unaligned to burst size, the final transfer > will be overrun. That is fine, you shoudl return error for bursts which are not aligned when preparing the descriptors -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel