All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anand Jain <anand.jain@oracle.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 2/2] btrfs: make the scan logs consistent
Date: Fri, 10 Jan 2020 17:05:55 +0800	[thread overview]
Message-ID: <20200110090555.7049-2-anand.jain@oracle.com> (raw)
In-Reply-To: <20200110090555.7049-1-anand.jain@oracle.com>

Typically we follow, a logging format <parameter> <value> and no ":"
so just follow that here.

Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
David,
If required you may roll this into the patch 1/2 in this series. I didn't
dare, as there may be some concerns that it isn't relevent there.

 fs/btrfs/volumes.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 1a419841fc99..e6c2bf9d9f53 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -891,7 +891,7 @@ static noinline struct btrfs_device *device_list_add(const char *path,
 				mutex_unlock(&fs_devices->device_list_mutex);
 				rcu_read_lock();
 				printk_ratelimited(
-		"BTRFS: duplicate device fsid:devid for %pU:%llu old:%s new:%s",
+		"BTRFS: duplicate device fsid %pU devid %llu old %s new %s",
 					disk_super->fsid, devid,
 					rcu_str_deref(device->name), path);
 				rcu_read_unlock();
@@ -900,7 +900,7 @@ static noinline struct btrfs_device *device_list_add(const char *path,
 			bdput(path_bdev);
 			rcu_read_lock();
 			printk_ratelimited(
-			"BTRFS: device fsid %pU devid %llu moved old:%s new:%s",
+			"BTRFS: device fsid %pU devid %llu moved old %s new %s",
 				disk_super->fsid, devid,
 				rcu_str_deref(device->name), path);
 			rcu_read_unlock();
-- 
2.23.0


  reply	other threads:[~2020-01-10  9:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-10  9:05 [PATCH 1/2] btrfs: open code log helpers in device_list_add() Anand Jain
2020-01-10  9:05 ` Anand Jain [this message]
2020-01-10 16:42 ` David Sterba
2020-01-10 23:41   ` Anand Jain
2020-01-13 16:25     ` David Sterba
2020-01-14  5:15       ` Anand Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200110090555.7049-2-anand.jain@oracle.com \
    --to=anand.jain@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.