From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33BB0C33CA2 for ; Fri, 10 Jan 2020 11:51:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 14B472072A for ; Fri, 10 Jan 2020 11:51:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727919AbgAJLvh (ORCPT ); Fri, 10 Jan 2020 06:51:37 -0500 Received: from foss.arm.com ([217.140.110.172]:42992 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727689AbgAJLvg (ORCPT ); Fri, 10 Jan 2020 06:51:36 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5F0301063; Fri, 10 Jan 2020 03:51:36 -0800 (PST) Received: from arrakis.emea.arm.com (arrakis.cambridge.arm.com [10.1.197.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0F4573F534; Fri, 10 Jan 2020 03:51:34 -0800 (PST) Date: Fri, 10 Jan 2020 11:51:32 +0000 From: Catalin Marinas To: Suzuki K Poulose Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, will@kernel.org, maz@kernel.org, mark.rutland@arm.com, dave.martin@arm.com, ard.biesheuvel@linaro.org, christoffer.dall@arm.com, Will Deacon Subject: Re: [PATCH v2 2/7] arm64: fpsimd: Make sure SVE setup is complete before SIMD is used Message-ID: <20200110115132.GA8786@arrakis.emea.arm.com> References: <20191217183402.2259904-1-suzuki.poulose@arm.com> <20191217183402.2259904-3-suzuki.poulose@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191217183402.2259904-3-suzuki.poulose@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 17, 2019 at 06:33:57PM +0000, Suzuki K Poulose wrote: > In-kernel users of NEON rely on may_use_simd() to check if the SIMD > can be used. However, we must initialize the SVE before SIMD can > be used. Add a sanity check to make sure that we have completed the > SVE setup before anyone uses the SIMD. > > Cc: Ard Biesheuvel > Cc: Mark Rutland > Cc: Will Deacon > Cc: Catalin Marinas > Signed-off-by: Suzuki K Poulose > --- > Discussion here : https://lkml.kernel.org/r/20191014145204.GS27757@arm.com Re-reading this thread, I think the conclusion was more towards having a WARN_ON in system_supports_fpsimd() (or may_use_simd()). We don't expect code to start using neon before the SMP is initialised (other than early_initcall(), the rest run after the secondary CPUs are brought up). -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB45BC33CA2 for ; Fri, 10 Jan 2020 11:51:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8DC7420838 for ; Fri, 10 Jan 2020 11:51:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="f1kjaX/r" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8DC7420838 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=C7VMBTv+ELWUKFXvgzhchDSX2dCmzi9H8Yb3aI4ivFE=; b=f1kjaX/r69yjjd junUJ5zMmoU+luh/uM5reLCatEGAu3uixaY+eAmR7SiW7exec4V3xj4FkezkHZB8TnV45ouX03Hpf WMa7okaWG+9uOdPzZa258jAMnxasZifKv5CbyhHRQUkqPtAc3hDbQFeKikWUuYACa3FLkE7swl24U a71ZTPL3ChX06ueKsPHgUMf2KMHM8C11MNmLs9yd0mQfXk1WQTqK22GQfBYcYuz99KgYG/3Z7QCSW cYRpMqJYwFjLxkvuzveSDHFBZ5Cg8Seb0LkADH+cQECh7s38V8Z14/IKWlL2NjJhGJq606uGwloYj gq9M3Gv4WR6iEvAZLn2A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipspI-0005M0-N8; Fri, 10 Jan 2020 11:51:40 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipspF-0005Kf-Dh for linux-arm-kernel@lists.infradead.org; Fri, 10 Jan 2020 11:51:39 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5F0301063; Fri, 10 Jan 2020 03:51:36 -0800 (PST) Received: from arrakis.emea.arm.com (arrakis.cambridge.arm.com [10.1.197.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0F4573F534; Fri, 10 Jan 2020 03:51:34 -0800 (PST) Date: Fri, 10 Jan 2020 11:51:32 +0000 From: Catalin Marinas To: Suzuki K Poulose Subject: Re: [PATCH v2 2/7] arm64: fpsimd: Make sure SVE setup is complete before SIMD is used Message-ID: <20200110115132.GA8786@arrakis.emea.arm.com> References: <20191217183402.2259904-1-suzuki.poulose@arm.com> <20191217183402.2259904-3-suzuki.poulose@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191217183402.2259904-3-suzuki.poulose@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200110_035137_513699_9DD1A397 X-CRM114-Status: UNSURE ( 9.78 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, ard.biesheuvel@linaro.org, maz@kernel.org, Will Deacon , linux-kernel@vger.kernel.org, christoffer.dall@arm.com, will@kernel.org, dave.martin@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 17, 2019 at 06:33:57PM +0000, Suzuki K Poulose wrote: > In-kernel users of NEON rely on may_use_simd() to check if the SIMD > can be used. However, we must initialize the SVE before SIMD can > be used. Add a sanity check to make sure that we have completed the > SVE setup before anyone uses the SIMD. > > Cc: Ard Biesheuvel > Cc: Mark Rutland > Cc: Will Deacon > Cc: Catalin Marinas > Signed-off-by: Suzuki K Poulose > --- > Discussion here : https://lkml.kernel.org/r/20191014145204.GS27757@arm.com Re-reading this thread, I think the conclusion was more towards having a WARN_ON in system_supports_fpsimd() (or may_use_simd()). We don't expect code to start using neon before the SMP is initialised (other than early_initcall(), the rest run after the secondary CPUs are brought up). -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel