From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF3EAC33CA2 for ; Fri, 10 Jan 2020 11:54:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9BC1E2082E for ; Fri, 10 Jan 2020 11:54:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727967AbgAJLyU (ORCPT ); Fri, 10 Jan 2020 06:54:20 -0500 Received: from foss.arm.com ([217.140.110.172]:43054 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727717AbgAJLyT (ORCPT ); Fri, 10 Jan 2020 06:54:19 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EF7481063; Fri, 10 Jan 2020 03:54:18 -0800 (PST) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 360BF3F534; Fri, 10 Jan 2020 03:54:17 -0800 (PST) Date: Fri, 10 Jan 2020 11:54:15 +0000 From: Sudeep Holla To: Jolly Shah Cc: ard.biesheuvel@linaro.org, mingo@kernel.org, gregkh@linuxfoundation.org, matt@codeblueprint.co.uk, hkallweit1@gmail.com, keescook@chromium.org, dmitry.torokhov@gmail.com, michal.simek@xilinx.com, rajanv@xilinx.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Sudeep Holla , Tejas Patel Subject: Re: [PATCH 0/2] arch: arm64: xilinx: Make zynqmp_firmware driver optional Message-ID: <20200110115415.GC39451@bogus> References: <1578596764-29351-1-git-send-email-jolly.shah@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1578596764-29351-1-git-send-email-jolly.shah@xilinx.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 09, 2020 at 11:06:02AM -0800, Jolly Shah wrote: > From: Tejas Patel > > Zynqmp firmware driver requires firmware to be present in system. > Zynqmp firmware driver will crash if firmware is not present in system. > For example single arch QEMU, may not have firmware, with such setup > Linux booting fails. > > So make zynqmp_firmware driver as optional to disable it if user don't > have firmware in system. > Why can't it be detected runtime ? How do you handle single binary if you make this compile time option ? -- Regards, Sudeep From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 858CCC33CA3 for ; Fri, 10 Jan 2020 11:54:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C6672072A for ; Fri, 10 Jan 2020 11:54:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LepZrEeP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C6672072A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aI8AGP+uCb8lKep1ZONgHMs6rIckiPddc1vioM4L8aI=; b=LepZrEePEu2U8v w0aCD2jV5TQSCWxaPssCDsZmoubJXNxgSe+igrlklV0Ms1qHzoaiBuG9xPnS67wYLij19JVrGlb4Y jv8utlBKYrmSrCoj4iDB5kttbaXD57q56nhDNIzz/hZbjJpCBPzM/hc41JPoO9xVAJIaqqd4cAn0k /ch1FgoG1wWk0YCZMB4KzswcXGFnGPe9ZdRLJGVMT6Qdigh5e7Jrt8RTjENWUa7YRwf89oaorCFz9 ZnBkVLpdTt8NjefJ8LQiB+Q55JbNlSRGhQUOWrd53e6ziC7twkgMnxfOFdcBST55PHqrSceGmXC49 E3T7WXnu37lCrqrW15wg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipssN-0006wM-90; Fri, 10 Jan 2020 11:54:51 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipsru-0006Tu-3t for linux-arm-kernel@lists.infradead.org; Fri, 10 Jan 2020 11:54:24 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EF7481063; Fri, 10 Jan 2020 03:54:18 -0800 (PST) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 360BF3F534; Fri, 10 Jan 2020 03:54:17 -0800 (PST) Date: Fri, 10 Jan 2020 11:54:15 +0000 From: Sudeep Holla To: Jolly Shah Subject: Re: [PATCH 0/2] arch: arm64: xilinx: Make zynqmp_firmware driver optional Message-ID: <20200110115415.GC39451@bogus> References: <1578596764-29351-1-git-send-email-jolly.shah@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1578596764-29351-1-git-send-email-jolly.shah@xilinx.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200110_035422_209827_AD26A32C X-CRM114-Status: UNSURE ( 8.22 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tejas Patel , keescook@chromium.org, ard.biesheuvel@linaro.org, matt@codeblueprint.co.uk, gregkh@linuxfoundation.org, dmitry.torokhov@gmail.com, michal.simek@xilinx.com, linux-kernel@vger.kernel.org, rajanv@xilinx.com, Sudeep Holla , mingo@kernel.org, linux-arm-kernel@lists.infradead.org, hkallweit1@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 09, 2020 at 11:06:02AM -0800, Jolly Shah wrote: > From: Tejas Patel > > Zynqmp firmware driver requires firmware to be present in system. > Zynqmp firmware driver will crash if firmware is not present in system. > For example single arch QEMU, may not have firmware, with such setup > Linux booting fails. > > So make zynqmp_firmware driver as optional to disable it if user don't > have firmware in system. > Why can't it be detected runtime ? How do you handle single binary if you make this compile time option ? -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel