From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B53AC33CA2 for ; Fri, 10 Jan 2020 12:08:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 686682072A for ; Fri, 10 Jan 2020 12:08:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="X0wqYsTm"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="K/A4vxFD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 686682072A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0tBXEJVSdxNH6SwUKnpbKRKbmK1F/AkW0Nbym7OWnlE=; b=X0wqYsTm2MjRdz IsPRpy8HC1AjPLL5KhVxDL4ds9VpOyg+fgu0DJQwQd3U4ojOm3Pmv1ARuxdqkgKPJAnR7wgQHWjXK gzzuCqQKEszIFzxx1DhVLB1REdcFIhmM/7rV9nF0Gafa2mwVZpr8lJX49dzdywW9hl01rkLa2VcDb 9n9bCV3j1zYjicxxXctTBDZ1qj8pImbbsjzaqrZHJZv1MoEwPeFEa3PBN89i+KoHZGR+6LMYHfnYu 6eOwt+LiCDvvOEZTgjEF0zkQKTmh5vI+eVtblzyFMblp18BfCoomB7lTBTxscNb7WtDg338dUi7mB RF4wXxmzfgzfZrga+oxw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipt5g-0007h9-01; Fri, 10 Jan 2020 12:08:36 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipt5c-0007gK-U7 for linux-arm-kernel@lists.infradead.org; Fri, 10 Jan 2020 12:08:34 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E879C2072A; Fri, 10 Jan 2020 12:08:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578658110; bh=larVmVkeU3WRfxDwAQPsKTqJF1qSNwd1xhwAG5vCcC8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=K/A4vxFDuOPaUCeiyHjr6ShLxRsAqlO6/dHE7cOWeWOfD6pvq5i0E5xNYBXBhvQmO CYWI2M0FTJ5mFSVJiePLU3eSAVgBto1yYdjW+h6eJVY6LV/nqHv3Oc69pJ+KWQAq4V goyLD+/yRA5vQ92tsnuqAR8QF+7McDNkLWw+Q178= Date: Fri, 10 Jan 2020 12:08:26 +0000 From: Will Deacon To: Vladimir Murzin Subject: Re: [PATCH 2/2] arm64: Move the LSE gas support detection to Kconfig Message-ID: <20200110120826.GC10066@willie-the-truck> References: <20200109174948.48211-1-catalin.marinas@arm.com> <20200109174948.48211-3-catalin.marinas@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200110_040832_995953_00A6DBD4 X-CRM114-Status: GOOD ( 13.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 10, 2020 at 11:54:38AM +0000, Vladimir Murzin wrote: > On 1/9/20 5:49 PM, Catalin Marinas wrote: > > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > > index 04cf64e9f0c9..2595c2886d3f 100644 > > --- a/arch/arm64/kernel/cpufeature.c > > +++ b/arch/arm64/kernel/cpufeature.c > > @@ -1291,7 +1291,7 @@ static const struct arm64_cpu_capabilities arm64_features[] = { > > .cpu_enable = cpu_enable_pan, > > }, > > #endif /* CONFIG_ARM64_PAN */ > > -#if defined(CONFIG_AS_LSE) && defined(CONFIG_ARM64_LSE_ATOMICS) > > +#ifdef CONFIG_ARM64_LSE_ATOMICS > > { > > .desc = "LSE atomic instructions", > > .capability = ARM64_HAS_LSE_ATOMICS, > > @@ -1302,7 +1302,7 @@ static const struct arm64_cpu_capabilities arm64_features[] = { > > .sign = FTR_UNSIGNED, > > .min_field_value = 2, > > }, > > -#endif /* CONFIG_AS_LSE && CONFIG_ARM64_LSE_ATOMICS */ > > +#endif /* CONFIG_ARM64_LSE_ATOMICS */ > > { > > .desc = "Software prefetching using PRFM", > > .capability = ARM64_HAS_NO_HW_PREFETCH, > > > > I was not lucky with the similar patch [1], anyway > > Reviewed-by: Vladimir Murzin > > > [1] https://www.spinics.net/lists/linux-crypto/msg36059.html It's the loss of the warning that I object to, since I think it's a useful diagnostic to have. Is there some way we can keep that, but using the new kbuild logic? Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel