From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41D4DC33CA2 for ; Fri, 10 Jan 2020 12:27:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0DB9A2077C for ; Fri, 10 Jan 2020 12:27:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728065AbgAJM1a (ORCPT ); Fri, 10 Jan 2020 07:27:30 -0500 Received: from foss.arm.com ([217.140.110.172]:43886 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727753AbgAJM13 (ORCPT ); Fri, 10 Jan 2020 07:27:29 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0C9B01063; Fri, 10 Jan 2020 04:27:29 -0800 (PST) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E69F33F534; Fri, 10 Jan 2020 04:27:27 -0800 (PST) Date: Fri, 10 Jan 2020 12:27:25 +0000 From: Sudeep Holla To: Viresh Kumar Cc: Arnd Bergmann , peng.fan@nxp.com, Vincent Guittot , Jassi Brar , "linux-kernel@vger.kernel.org" , Sudeep Holla , Linux ARM Subject: Re: [PATCH] firmware: arm_scmi: Make scmi core independent of transport type Message-ID: <20200110122725.GB45077@bogus> References: <5c545c2866ba075ddb44907940a1dae1d823b8a1.1575019719.git.viresh.kumar@linaro.org> <20200109093442.4jt44eu2zlmjaq3f@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200109093442.4jt44eu2zlmjaq3f@vireshk-i7> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 09, 2020 at 03:04:42PM +0530, Viresh Kumar wrote: > On 09-01-20, 09:18, Arnd Bergmann wrote: > > On Fri, Nov 29, 2019 at 10:32 AM Viresh Kumar wrote: > > > > > > The SCMI specification is fairly independent of the transport protocol, > > > which can be a simple mailbox (already implemented) or anything else. > > > The current Linux implementation however is very much dependent of the > > > mailbox transport layer. > > > > > > This patch makes the SCMI core code (driver.c) independent of the > > > mailbox transport layer and moves all mailbox related code to a new > > > file: mailbox.c. > > > > > > We can now implement more transport protocols to transport SCMI > > > messages. > > > > > > The transport protocols just need to provide struct scmi_transport_ops, > > > with its version of the callbacks to enable exchange of SCMI messages. > > > > > > Signed-off-by: Viresh Kumar > > > > Conceptually I think this is fine, but as others have said, it would be > > better to have another transport implementation posted along with this > > to see if the interfaces actually work out. > > @Sudeep/Vincent: Do you think we can add another transport > implementation something right away for it ? > Even if we don't add new transport right away, I would like to see if the requirements are met. I will take a look at you v2 with that in mind anyways. We need not wait, we I want to see people think it meets their requirement. I will also add couple of guys working on virtio transport for SCMI when I respond to your v2. Thanks for posting it. > @Peng ? > Peng, Did you get a chance to try this with SMC ? If SCMI was the only usecase, you can try this approach instead of mailbox, now that no one has any objects to this approach conceptually. Please use v2 as base and update us. -- Regards, Sudeep From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C91EC33CA2 for ; Fri, 10 Jan 2020 12:27:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08D462077C for ; Fri, 10 Jan 2020 12:27:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oVnzGPmJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 08D462077C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KBUzu3KwmP4RYlCue8huTFkVX7ZvFCCiR+neuwf7ZrY=; b=oVnzGPmJOzpqJy XjgjQRDp8KXDaZ+zGDKTFNjktARiUesmjrzeJMHQKlprD9CVDToUT23ed7zyfF2NJgZELnjpkw82d 7TzkEHIo3S+E+6Fx6yTBVBmJwBC8nybkrOeSyOYDvAzqQiK/Hcop3jmw05xihqMl6qiKHK7Fy4LJ4 qLDqvOFQXOgXk1ZYFAU5/LNgQejR4V/u0N1mYBPqKo2rxldux15OuJi6tLgZxya/fZO8UsyiITQQC tSWeyWNgpfdand4PxfRD6wdbFJStESV/QNlirsbgkolUoACwyeDJxuApovMK07Vp0J2D7DC63MHll QVIdDvF2HTg7slQ4i7tA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iptO0-0000qn-9h; Fri, 10 Jan 2020 12:27:32 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iptNx-0000qJ-H1 for linux-arm-kernel@lists.infradead.org; Fri, 10 Jan 2020 12:27:30 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0C9B01063; Fri, 10 Jan 2020 04:27:29 -0800 (PST) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E69F33F534; Fri, 10 Jan 2020 04:27:27 -0800 (PST) Date: Fri, 10 Jan 2020 12:27:25 +0000 From: Sudeep Holla To: Viresh Kumar Subject: Re: [PATCH] firmware: arm_scmi: Make scmi core independent of transport type Message-ID: <20200110122725.GB45077@bogus> References: <5c545c2866ba075ddb44907940a1dae1d823b8a1.1575019719.git.viresh.kumar@linaro.org> <20200109093442.4jt44eu2zlmjaq3f@vireshk-i7> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200109093442.4jt44eu2zlmjaq3f@vireshk-i7> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200110_042729_606689_2E51244B X-CRM114-Status: GOOD ( 19.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peng.fan@nxp.com, Arnd Bergmann , Jassi Brar , "linux-kernel@vger.kernel.org" , Sudeep Holla , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 09, 2020 at 03:04:42PM +0530, Viresh Kumar wrote: > On 09-01-20, 09:18, Arnd Bergmann wrote: > > On Fri, Nov 29, 2019 at 10:32 AM Viresh Kumar wrote: > > > > > > The SCMI specification is fairly independent of the transport protocol, > > > which can be a simple mailbox (already implemented) or anything else. > > > The current Linux implementation however is very much dependent of the > > > mailbox transport layer. > > > > > > This patch makes the SCMI core code (driver.c) independent of the > > > mailbox transport layer and moves all mailbox related code to a new > > > file: mailbox.c. > > > > > > We can now implement more transport protocols to transport SCMI > > > messages. > > > > > > The transport protocols just need to provide struct scmi_transport_ops, > > > with its version of the callbacks to enable exchange of SCMI messages. > > > > > > Signed-off-by: Viresh Kumar > > > > Conceptually I think this is fine, but as others have said, it would be > > better to have another transport implementation posted along with this > > to see if the interfaces actually work out. > > @Sudeep/Vincent: Do you think we can add another transport > implementation something right away for it ? > Even if we don't add new transport right away, I would like to see if the requirements are met. I will take a look at you v2 with that in mind anyways. We need not wait, we I want to see people think it meets their requirement. I will also add couple of guys working on virtio transport for SCMI when I respond to your v2. Thanks for posting it. > @Peng ? > Peng, Did you get a chance to try this with SMC ? If SCMI was the only usecase, you can try this approach instead of mailbox, now that no one has any objects to this approach conceptually. Please use v2 as base and update us. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel