From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25909C282DD for ; Fri, 10 Jan 2020 14:51:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EC15E2072A for ; Fri, 10 Jan 2020 14:51:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728330AbgAJOvA (ORCPT ); Fri, 10 Jan 2020 09:51:00 -0500 Received: from foss.arm.com ([217.140.110.172]:45688 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727627AbgAJOu7 (ORCPT ); Fri, 10 Jan 2020 09:50:59 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4F0FB30E; Fri, 10 Jan 2020 06:50:59 -0800 (PST) Received: from arrakis.emea.arm.com (arrakis.cambridge.arm.com [10.1.197.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1C3BF3F6C4; Fri, 10 Jan 2020 06:50:58 -0800 (PST) Date: Fri, 10 Jan 2020 14:50:56 +0000 From: Catalin Marinas To: Suzuki K Poulose Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, will@kernel.org, maz@kernel.org, mark.rutland@arm.com, dave.martin@arm.com, ard.biesheuvel@linaro.org, christoffer.dall@arm.com Subject: Re: [PATCH v2 3/7] arm64: cpufeature: Fix the type of no FP/SIMD capability Message-ID: <20200110145055.GE8786@arrakis.emea.arm.com> References: <20191217183402.2259904-1-suzuki.poulose@arm.com> <20191217183402.2259904-4-suzuki.poulose@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191217183402.2259904-4-suzuki.poulose@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 17, 2019 at 06:33:58PM +0000, Suzuki K Poulose wrote: > The NO_FPSIMD capability is defined with scope SYSTEM, which implies > that the "absence" of FP/SIMD on at least one CPU is detected only > after all the SMP CPUs are brought up. However, we use the status > of this capability for every context switch. So, let us change > the scope to LOCAL_CPU to allow the detection of this capability > as and when the first CPU without FP is brought up. > > Also, the current type allows hotplugged CPU to be brought up without > FP/SIMD when all the current CPUs have FP/SIMD and we have the userspace > up. Fix both of these issues by changing the capability to > BOOT_RESTRICTED_LOCAL_CPU_FEATURE. > > Fixes: 82e0191a1aa11abf ("arm64: Support systems without FP/ASIMD") > Cc: Will Deacon > Cc: Mark Rutland > Cc: Catalin Marinas > Signed-off-by: Suzuki K Poulose Reviewed-by: Catalin Marinas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 725ACC282DD for ; Fri, 10 Jan 2020 14:51:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3D6FC2072A for ; Fri, 10 Jan 2020 14:51:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UT+A8kQJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D6FC2072A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DN0X3Kwz/qt6lgM4pYNFI8hXh66UHlmfLUh+Tf2duFs=; b=UT+A8kQJm0lpHY RtW1b07fIQ7hpWIcxhkF/06hpPxAixkO+80oc/x75V2EEYDXRe2esLKgx5EZ+yJ9DUFXkQuSbLzxO P+RNoFXC/f35jT1Y2w/rcyXQS+nifriQhSpJlKGM1umCjfS+VClmBpO3HdJZQXC0R52qcK1HG4N2T SrCKkNiRu3Byf78nbEq0CR2LOslUeRVJrQHLALrB6/OJHV60lYK0UehppjpWfl61BxtT59Iq0qnlI yyiuy5dejWSdWd4ojRK3bRrBQOjb/D8+Bd5R7UOQI9hJn0WvVSctuUwSQrHkbQSXU0WdYQzTdT9KD 97mmBweXiPAhwJ2WhGHA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipvct-0002Wx-PV; Fri, 10 Jan 2020 14:51:03 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipvcq-0002W5-8m for linux-arm-kernel@lists.infradead.org; Fri, 10 Jan 2020 14:51:01 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4F0FB30E; Fri, 10 Jan 2020 06:50:59 -0800 (PST) Received: from arrakis.emea.arm.com (arrakis.cambridge.arm.com [10.1.197.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1C3BF3F6C4; Fri, 10 Jan 2020 06:50:58 -0800 (PST) Date: Fri, 10 Jan 2020 14:50:56 +0000 From: Catalin Marinas To: Suzuki K Poulose Subject: Re: [PATCH v2 3/7] arm64: cpufeature: Fix the type of no FP/SIMD capability Message-ID: <20200110145055.GE8786@arrakis.emea.arm.com> References: <20191217183402.2259904-1-suzuki.poulose@arm.com> <20191217183402.2259904-4-suzuki.poulose@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191217183402.2259904-4-suzuki.poulose@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200110_065100_351701_29E25FD6 X-CRM114-Status: GOOD ( 12.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, ard.biesheuvel@linaro.org, maz@kernel.org, linux-kernel@vger.kernel.org, christoffer.dall@arm.com, will@kernel.org, dave.martin@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 17, 2019 at 06:33:58PM +0000, Suzuki K Poulose wrote: > The NO_FPSIMD capability is defined with scope SYSTEM, which implies > that the "absence" of FP/SIMD on at least one CPU is detected only > after all the SMP CPUs are brought up. However, we use the status > of this capability for every context switch. So, let us change > the scope to LOCAL_CPU to allow the detection of this capability > as and when the first CPU without FP is brought up. > > Also, the current type allows hotplugged CPU to be brought up without > FP/SIMD when all the current CPUs have FP/SIMD and we have the userspace > up. Fix both of these issues by changing the capability to > BOOT_RESTRICTED_LOCAL_CPU_FEATURE. > > Fixes: 82e0191a1aa11abf ("arm64: Support systems without FP/ASIMD") > Cc: Will Deacon > Cc: Mark Rutland > Cc: Catalin Marinas > Signed-off-by: Suzuki K Poulose Reviewed-by: Catalin Marinas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel