All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 00/10] Impveovements for random.h/archrandom.h
@ 2020-01-10 14:54 ` Mark Brown
  0 siblings, 0 replies; 51+ messages in thread
From: Mark Brown @ 2020-01-10 14:54 UTC (permalink / raw)
  To: linux-arch
  Cc: Richard Henderson, Borislav Petkov, linux-s390, herbert, x86,
	linux-crypto, linuxppc-dev, linux-arm-kernel, Mark Brown

This is a resend of a series from Richard Henderson last posted back in
November:

   https://lore.kernel.org/linux-arm-kernel/20191106141308.30535-1-rth@twiddle.net/

Back then Borislav said they looked good and asked if he should take
them through the tip tree but things seem to have got lost since then.

Original cover letter:

During patch review for an addition of archrandom.h for arm64, it was
suggeted that the arch_random_get_* functions should be marked __must_check.
Which does sound like a good idea, since the by-reference integer output
may be uninitialized when the boolean result is false.

In addition, it turns out that arch_has_random() and arch_has_random_seed()
are not used, and not easy to support for arm64.  Rather than cobble
something together that would not be testable, remove the interfaces
against some future accidental use.

In addition, I noticed a few other minor inconsistencies between the
different architectures, e.g. powerpc isn't using bool.

Change since v1:
   * Remove arch_has_random, arch_has_random_seed.

Richard Henderson (10):
  x86: Remove arch_has_random, arch_has_random_seed
  powerpc: Remove arch_has_random, arch_has_random_seed
  s390: Remove arch_has_random, arch_has_random_seed
  linux/random.h: Remove arch_has_random, arch_has_random_seed
  linux/random.h: Use false with bool
  linux/random.h: Mark CONFIG_ARCH_RANDOM functions __must_check
  x86: Mark archrandom.h functions __must_check
  powerpc: Use bool in archrandom.h
  powerpc: Mark archrandom.h functions __must_check
  s390x: Mark archrandom.h functions __must_check

 arch/powerpc/include/asm/archrandom.h | 27 +++++++++-----------------
 arch/s390/include/asm/archrandom.h    | 20 ++++---------------
 arch/x86/include/asm/archrandom.h     | 28 ++++++++++++---------------
 include/linux/random.h                | 24 ++++++++---------------
 4 files changed, 33 insertions(+), 66 deletions(-)

-- 
2.20.1


^ permalink raw reply	[flat|nested] 51+ messages in thread
* [PATCH v2 00/10] Improvements for random.h/archrandom.h
@ 2019-11-06 14:12 Richard Henderson
  2019-11-06 14:13   ` Richard Henderson
  0 siblings, 1 reply; 51+ messages in thread
From: Richard Henderson @ 2019-11-06 14:12 UTC (permalink / raw)
  To: linux-crypto
  Cc: herbert, linux-arch, x86, linuxppc-dev, linux-s390, linux-arm-kernel

During patch review for an addition of archrandom.h for arm64, it was
suggeted that the arch_random_get_* functions should be marked __must_check.
Which does sound like a good idea, since the by-reference integer output
may be uninitialized when the boolean result is false.

In addition, it turns out that arch_has_random() and arch_has_random_seed()
are not used, and not easy to support for arm64.  Rather than cobble
something together that would not be testable, remove the interfaces
against some future accidental use.

In addition, I noticed a few other minor inconsistencies between the
different architectures, e.g. powerpc isn't using bool.

Change since v1:
  * Remove arch_has_random, arch_has_random_seed.


r~


Richard Henderson (10):
  x86: Remove arch_has_random, arch_has_random_seed
  powerpc: Remove arch_has_random, arch_has_random_seed
  s390: Remove arch_has_random, arch_has_random_seed
  linux/random.h: Remove arch_has_random, arch_has_random_seed
  linux/random.h: Use false with bool
  linux/random.h: Mark CONFIG_ARCH_RANDOM functions __must_check
  x86: Mark archrandom.h functions __must_check
  powerpc: Use bool in archrandom.h
  powerpc: Mark archrandom.h functions __must_check
  s390x: Mark archrandom.h functions __must_check

 arch/powerpc/include/asm/archrandom.h | 27 +++++++++-----------------
 arch/s390/include/asm/archrandom.h    | 20 ++++---------------
 arch/x86/include/asm/archrandom.h     | 28 ++++++++++++---------------
 include/linux/random.h                | 24 ++++++++---------------
 4 files changed, 33 insertions(+), 66 deletions(-)

-- 
2.17.1


^ permalink raw reply	[flat|nested] 51+ messages in thread

end of thread, other threads:[~2020-01-25 17:47 UTC | newest]

Thread overview: 51+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-10 14:54 [PATCH v2 00/10] Impveovements for random.h/archrandom.h Mark Brown
2020-01-10 14:54 ` Mark Brown
2020-01-10 14:54 ` Mark Brown
2020-01-10 14:54 ` [PATCH v2 01/10] x86: Remove arch_has_random, arch_has_random_seed Mark Brown
2020-01-10 14:54   ` Mark Brown
2020-01-10 14:54   ` Mark Brown
2020-01-10 14:54 ` [PATCH v2 02/10] powerpc: " Mark Brown
2020-01-10 14:54   ` Mark Brown
2020-01-10 14:54   ` Mark Brown
2020-01-10 14:54 ` [PATCH v2 03/10] s390: " Mark Brown
2020-01-10 14:54   ` Mark Brown
2020-01-10 14:54   ` Mark Brown
2020-01-10 14:54 ` [PATCH v2 04/10] linux/random.h: " Mark Brown
2020-01-10 14:54   ` Mark Brown
2020-01-10 14:54   ` Mark Brown
2020-01-10 14:54 ` [PATCH v2 05/10] linux/random.h: Use false with bool Mark Brown
2020-01-10 14:54   ` Mark Brown
2020-01-10 14:54   ` Mark Brown
2020-01-10 14:54 ` [PATCH v2 06/10] linux/random.h: Mark CONFIG_ARCH_RANDOM functions __must_check Mark Brown
2020-01-10 14:54   ` Mark Brown
2020-01-10 14:54   ` Mark Brown
2020-01-10 14:54 ` [PATCH v2 07/10] x86: Mark archrandom.h " Mark Brown
2020-01-10 14:54   ` Mark Brown
2020-01-10 14:54   ` Mark Brown
2020-01-10 14:54 ` [PATCH v2 08/10] powerpc: Use bool in archrandom.h Mark Brown
2020-01-10 14:54   ` Mark Brown
2020-01-10 14:54   ` Mark Brown
2020-01-10 14:54 ` [PATCH v2 09/10] powerpc: Mark archrandom.h functions __must_check Mark Brown
2020-01-10 14:54   ` Mark Brown
2020-01-10 14:54   ` Mark Brown
2020-01-10 14:54 ` [PATCH v2 10/10] s390x: " Mark Brown
2020-01-10 14:54   ` Mark Brown
2020-01-10 14:54   ` Mark Brown
2020-01-10 15:51 ` [PATCH v2 00/10] Impveovements for random.h/archrandom.h Borislav Petkov
2020-01-10 15:51   ` Borislav Petkov
2020-01-10 15:51   ` Borislav Petkov
2020-01-10 17:05   ` Theodore Y. Ts'o
2020-01-10 17:05     ` Theodore Y. Ts'o
2020-01-10 17:05     ` Theodore Y. Ts'o
2020-01-20 17:26     ` Mark Brown
2020-01-20 17:26       ` Mark Brown
2020-01-20 17:26       ` Mark Brown
2020-01-20 17:59       ` Borislav Petkov
2020-01-20 17:59         ` Borislav Petkov
2020-01-20 17:59         ` Borislav Petkov
2020-01-25 17:46         ` Theodore Y. Ts'o
2020-01-25 17:46           ` Theodore Y. Ts'o
2020-01-25 17:46           ` Theodore Y. Ts'o
  -- strict thread matches above, loose matches on Subject: below --
2019-11-06 14:12 [PATCH v2 00/10] Improvements " Richard Henderson
2019-11-06 14:13 ` [PATCH v2 02/10] powerpc: Remove arch_has_random, arch_has_random_seed Richard Henderson
2019-11-06 14:13   ` Richard Henderson
2019-11-06 14:13   ` Richard Henderson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.