From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF30BC282DD for ; Fri, 10 Jan 2020 15:52:06 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D8ED20721 for ; Fri, 10 Jan 2020 15:52:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QIe2dMyl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D8ED20721 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48318 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipwZx-0008AS-SG for qemu-devel@archiver.kernel.org; Fri, 10 Jan 2020 10:52:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58346) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipwI8-0000I6-Lv for qemu-devel@nongnu.org; Fri, 10 Jan 2020 10:33:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ipwI7-0002Lt-J6 for qemu-devel@nongnu.org; Fri, 10 Jan 2020 10:33:40 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:52882 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ipwI7-0002KU-FK for qemu-devel@nongnu.org; Fri, 10 Jan 2020 10:33:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578670419; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3DSlkHiCPZJBJWfOU2yzggg6SGKexdbepyj5rAihYkw=; b=QIe2dMylOoaFOLlpMIvoZ0gn3NvJ5gv+BUnurBhgvrxRxw76vwpeu3P/MYEG8AzBAwyUBw Z2B66HuGcdOW09gQCDXYgvi/rMF7yxce4VaqbogOxDDdeL0oz1Oj2PdpM80oa/1/O+GSny +FjAt92K0ZZT9oJ0N4+FUsrwoPLvj/I= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-397-JWDFjDvfMberrCeGU3KvrQ-1; Fri, 10 Jan 2020 10:33:38 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1FA3A10054E3 for ; Fri, 10 Jan 2020 15:33:37 +0000 (UTC) Received: from localhost (ovpn-112-59.ams2.redhat.com [10.36.112.59]) by smtp.corp.redhat.com (Postfix) with ESMTP id 58EEF78E89; Fri, 10 Jan 2020 15:33:29 +0000 (UTC) From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= To: qemu-devel@nongnu.org Subject: [PATCH 14/26] object: add direct link flag Date: Fri, 10 Jan 2020 19:30:27 +0400 Message-Id: <20200110153039.1379601-15-marcandre.lureau@redhat.com> In-Reply-To: <20200110153039.1379601-1-marcandre.lureau@redhat.com> References: <20200110153039.1379601-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: JWDFjDvfMberrCeGU3KvrQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , "Daniel P . Berrange" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Eduardo Habkost , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Allow the link property to hold the pointer to the target, instead of indirectly through another variable. Signed-off-by: Marc-Andr=C3=A9 Lureau --- include/qom/object.h | 3 +++ qom/object.c | 26 ++++++++++++++++++++------ 2 files changed, 23 insertions(+), 6 deletions(-) diff --git a/include/qom/object.h b/include/qom/object.h index 7e66bc78c9..5b02be68ec 100644 --- a/include/qom/object.h +++ b/include/qom/object.h @@ -1528,6 +1528,9 @@ void object_property_add_child(Object *obj, const cha= r *name, typedef enum { /* Unref the link pointer when the property is deleted */ OBJ_PROP_LINK_STRONG =3D 0x1, + + /* private */ + OBJ_PROP_LINK_DIRECT =3D 0x2, } ObjectPropertyLinkFlags; =20 /** diff --git a/qom/object.c b/qom/object.c index 47d8be81a6..30eee0f36b 100644 --- a/qom/object.c +++ b/qom/object.c @@ -1720,17 +1720,30 @@ void object_property_allow_set_link(const Object *o= bj, const char *name, } =20 typedef struct { - Object **targetp; + union { + Object **targetp; + Object *target; /* if OBJ_PROP_LINK_DIRECT, when holding the point= er */ + }; void (*check)(const Object *, const char *, Object *, Error **); ObjectPropertyLinkFlags flags; } LinkProperty; =20 +static Object ** +object_link_get_targetp(Object *obj, LinkProperty *lprop) +{ + if (lprop->flags & OBJ_PROP_LINK_DIRECT) { + return &lprop->target; + } else { + return lprop->targetp; + } +} + static void object_get_link_property(Object *obj, Visitor *v, const char *name, void *opaque, Error **errp) { LinkProperty *lprop =3D opaque; - Object **targetp =3D lprop->targetp; + Object **targetp =3D object_link_get_targetp(obj, lprop); gchar *path; =20 if (*targetp) { @@ -1789,7 +1802,7 @@ static void object_set_link_property(Object *obj, Vis= itor *v, { Error *local_err =3D NULL; LinkProperty *prop =3D opaque; - Object **targetp =3D prop->targetp; + Object **targetp =3D object_link_get_targetp(obj, prop); Object *old_target =3D *targetp; Object *new_target =3D NULL; char *path =3D NULL; @@ -1823,16 +1836,17 @@ static Object *object_resolve_link_property(Object = *parent, void *opaque, const { LinkProperty *lprop =3D opaque; =20 - return *lprop->targetp; + return *object_link_get_targetp(parent, lprop); } =20 static void object_release_link_property(Object *obj, const char *name, void *opaque) { LinkProperty *prop =3D opaque; + Object **targetp =3D object_link_get_targetp(obj, prop); =20 - if ((prop->flags & OBJ_PROP_LINK_STRONG) && *prop->targetp) { - object_unref(*prop->targetp); + if ((prop->flags & OBJ_PROP_LINK_STRONG) && *targetp) { + object_unref(*targetp); } g_free(prop); } --=20 2.25.0.rc1.20.g2443f3f80d.dirty