All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Price <steven.price@arm.com>
To: Qian Cai <cai@lca.pw>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	Catalin Marinas <Catalin.Marinas@arm.com>,
	"will@kernel.org" <will@kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"sfr@canb.auug.org.au" <sfr@canb.auug.org.au>
Subject: Re: [PATCH -next] arm64/mm/dump: fix a compilation error
Date: Fri, 10 Jan 2020 15:34:48 +0000	[thread overview]
Message-ID: <20200110153447.GA30104@arm.com> (raw)
In-Reply-To: <20200110145112.7959-1-cai@lca.pw>

On Fri, Jan 10, 2020 at 02:51:12PM +0000, Qian Cai wrote:
> The linux-next commit "x86: mm: avoid allocating struct mm_struct on the
> stack" [1] introduced a compilation error with "arm64: mm: convert
> mm/dump.c to use walk_page_range()" [2]. Fixed it by using the new API.
> 
> arch/arm64/mm/dump.c:326:38: error: too few arguments to function call,
> expected 3, have 2
>         ptdump_walk_pgd(&st.ptdump, info->mm);
>         ~~~~~~~~~~~~~~~                     ^
> ./include/linux/ptdump.h:20:1: note: 'ptdump_walk_pgd' declared here
> void ptdump_walk_pgd(struct ptdump_state *st, struct mm_struct *mm,
> pgd_t *pgd);
> ^
> arch/arm64/mm/dump.c:364:38: error: too few arguments to function call,
> expected 3, have 2
>         ptdump_walk_pgd(&st.ptdump, &init_mm);
>         ~~~~~~~~~~~~~~~                     ^
> ./include/linux/ptdump.h:20:1: note: 'ptdump_walk_pgd' declared here
> void ptdump_walk_pgd(struct ptdump_state *st, struct mm_struct *mm,
> pgd_t *pgd);
> ^
> 2 errors generated.
> 
> [1] http://lkml.kernel.org/r/20200108145710.34314-1-steven.price@arm.com

Actually this was in the patch I originally posted - somehow it got
lost when Andrew picked it up.

> [2] http://lkml.kernel.org/r/20191218162402.45610-22-steven.price@arm.com
> 
> Signed-off-by: Qian Cai <cai@lca.pw>

Since this matches what I originally wrote... ;)

Reviewed-by: Steven Price <steven.price@arm.com>

Steve

> ---
>  arch/arm64/mm/dump.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/mm/dump.c b/arch/arm64/mm/dump.c
> index ef4b3ca1e058..860c00ec8bd3 100644
> --- a/arch/arm64/mm/dump.c
> +++ b/arch/arm64/mm/dump.c
> @@ -323,7 +323,7 @@ void ptdump_walk(struct seq_file *s, struct ptdump_info *info)
>  		}
>  	};
>  
> -	ptdump_walk_pgd(&st.ptdump, info->mm);
> +	ptdump_walk_pgd(&st.ptdump, info->mm, NULL);
>  }
>  
>  static void ptdump_initialize(void)
> @@ -361,7 +361,7 @@ void ptdump_check_wx(void)
>  		}
>  	};
>  
> -	ptdump_walk_pgd(&st.ptdump, &init_mm);
> +	ptdump_walk_pgd(&st.ptdump, &init_mm, NULL);
>  
>  	if (st.wx_pages || st.uxn_pages)
>  		pr_warn("Checked W+X mappings: FAILED, %lu W+X pages found, %lu non-UXN pages found\n",
> -- 
> 2.21.0 (Apple Git-122.2)
> 

WARNING: multiple messages have this Message-ID
From: Steven Price <steven.price@arm.com>
To: Qian Cai <cai@lca.pw>
Cc: "sfr@canb.auug.org.au" <sfr@canb.auug.org.au>,
	Catalin Marinas <Catalin.Marinas@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"will@kernel.org" <will@kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH -next] arm64/mm/dump: fix a compilation error
Date: Fri, 10 Jan 2020 15:34:48 +0000	[thread overview]
Message-ID: <20200110153447.GA30104@arm.com> (raw)
In-Reply-To: <20200110145112.7959-1-cai@lca.pw>

On Fri, Jan 10, 2020 at 02:51:12PM +0000, Qian Cai wrote:
> The linux-next commit "x86: mm: avoid allocating struct mm_struct on the
> stack" [1] introduced a compilation error with "arm64: mm: convert
> mm/dump.c to use walk_page_range()" [2]. Fixed it by using the new API.
> 
> arch/arm64/mm/dump.c:326:38: error: too few arguments to function call,
> expected 3, have 2
>         ptdump_walk_pgd(&st.ptdump, info->mm);
>         ~~~~~~~~~~~~~~~                     ^
> ./include/linux/ptdump.h:20:1: note: 'ptdump_walk_pgd' declared here
> void ptdump_walk_pgd(struct ptdump_state *st, struct mm_struct *mm,
> pgd_t *pgd);
> ^
> arch/arm64/mm/dump.c:364:38: error: too few arguments to function call,
> expected 3, have 2
>         ptdump_walk_pgd(&st.ptdump, &init_mm);
>         ~~~~~~~~~~~~~~~                     ^
> ./include/linux/ptdump.h:20:1: note: 'ptdump_walk_pgd' declared here
> void ptdump_walk_pgd(struct ptdump_state *st, struct mm_struct *mm,
> pgd_t *pgd);
> ^
> 2 errors generated.
> 
> [1] http://lkml.kernel.org/r/20200108145710.34314-1-steven.price@arm.com

Actually this was in the patch I originally posted - somehow it got
lost when Andrew picked it up.

> [2] http://lkml.kernel.org/r/20191218162402.45610-22-steven.price@arm.com
> 
> Signed-off-by: Qian Cai <cai@lca.pw>

Since this matches what I originally wrote... ;)

Reviewed-by: Steven Price <steven.price@arm.com>

Steve

> ---
>  arch/arm64/mm/dump.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/mm/dump.c b/arch/arm64/mm/dump.c
> index ef4b3ca1e058..860c00ec8bd3 100644
> --- a/arch/arm64/mm/dump.c
> +++ b/arch/arm64/mm/dump.c
> @@ -323,7 +323,7 @@ void ptdump_walk(struct seq_file *s, struct ptdump_info *info)
>  		}
>  	};
>  
> -	ptdump_walk_pgd(&st.ptdump, info->mm);
> +	ptdump_walk_pgd(&st.ptdump, info->mm, NULL);
>  }
>  
>  static void ptdump_initialize(void)
> @@ -361,7 +361,7 @@ void ptdump_check_wx(void)
>  		}
>  	};
>  
> -	ptdump_walk_pgd(&st.ptdump, &init_mm);
> +	ptdump_walk_pgd(&st.ptdump, &init_mm, NULL);
>  
>  	if (st.wx_pages || st.uxn_pages)
>  		pr_warn("Checked W+X mappings: FAILED, %lu W+X pages found, %lu non-UXN pages found\n",
> -- 
> 2.21.0 (Apple Git-122.2)
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-01-10 15:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-10 14:51 Qian Cai
2020-01-10 14:51 ` Qian Cai
2020-01-10 15:34 ` Steven Price [this message]
2020-01-10 15:34   ` Steven Price
2020-01-10 15:34   ` Steven Price
2020-01-10 16:07   ` Will Deacon
2020-01-10 16:07     ` Will Deacon
2020-01-10 16:07     ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200110153447.GA30104@arm.com \
    --to=steven.price@arm.com \
    --cc=Catalin.Marinas@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=cai@lca.pw \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=sfr@canb.auug.org.au \
    --cc=will@kernel.org \
    --subject='Re: [PATCH -next] arm64/mm/dump: fix a compilation error' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.