From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4726AC33CA3 for ; Fri, 10 Jan 2020 17:46:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1F5B220678 for ; Fri, 10 Jan 2020 17:46:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728406AbgAJRqK (ORCPT ); Fri, 10 Jan 2020 12:46:10 -0500 Received: from asavdk3.altibox.net ([109.247.116.14]:35070 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727405AbgAJRqJ (ORCPT ); Fri, 10 Jan 2020 12:46:09 -0500 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id EE7A920057; Fri, 10 Jan 2020 18:46:04 +0100 (CET) Date: Fri, 10 Jan 2020 18:46:03 +0100 From: Sam Ravnborg To: Icenowy Zheng Cc: Rob Herring , Maxime Ripard , Chen-Yu Tsai , Thierry Reding , David Airlie , Daniel Vetter , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH 3/5] drm/panel: Add Feixin K101 IM2BA02 panel Message-ID: <20200110174603.GC25099@ravnborg.org> References: <20200110155225.1051749-1-icenowy@aosc.io> <20200110155225.1051749-4-icenowy@aosc.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200110155225.1051749-4-icenowy@aosc.io> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=eMA9ckh1 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=bNPPjxCvKY4QfMc8yoEA:9 a=CjuIK1q_8ugA:10 a=pHzHmUro8NiASowvMSCR:22 a=6VlIyEUom7LUIeUMNQJH:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Icenowy. On Fri, Jan 10, 2020 at 11:52:23PM +0800, Icenowy Zheng wrote: > Feixin K101 IM2BA02 is a 800x1280 4-lane MIPI-DSI LCD panel. > > Add a panel driver for it. Thanks, driver looks really good. Only a few comments/nits below. Sam > > Signed-off-by: Icenowy Zheng > --- > MAINTAINERS | 6 + > drivers/gpu/drm/panel/Kconfig | 9 + > drivers/gpu/drm/panel/Makefile | 1 + > .../gpu/drm/panel/panel-feixin-k101-im2ba02.c | 548 ++++++++++++++++++ > 4 files changed, 564 insertions(+) > create mode 100644 drivers/gpu/drm/panel/panel-feixin-k101-im2ba02.c > > new file mode 100644 > index 000000000000..45a62bdabb3f > --- /dev/null > +++ b/drivers/gpu/drm/panel/panel-feixin-k101-im2ba02.c > @@ -0,0 +1,548 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Copyright (C) 2019-2020 Icenowy Zheng > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > +#include > +#include Sorted and in the right order - good. > + > +static int k101_im2ba02_prepare(struct drm_panel *panel) > +{ > + struct k101_im2ba02 *ctx = panel_to_k101_im2ba02(panel); > + struct mipi_dsi_device *dsi = ctx->dsi; > + unsigned int i; > + int ret; > + > + ret = regulator_enable(ctx->avdd); > + if (ret) > + return ret; > + > + msleep(20); > + > + ret = regulator_enable(ctx->dvdd); > + if (ret) > + return ret; > + > + msleep(20); > + > + ret = regulator_enable(ctx->cvdd); > + if (ret) > + return ret; Unless the msleep() between is regulator_enable() really is needed, this change this to use regulator_bulk_enable(). If the above is kept then please do proper error handling where all enabled regulators are disable in case of errors. > + > + msleep(30); > + > + gpiod_set_value(ctx->reset, 1); > + msleep(50); > + > + gpiod_set_value(ctx->reset, 0); > + msleep(50); > + > + gpiod_set_value(ctx->reset, 1); > + msleep(200); > + > + for (i = 0; i < ARRAY_SIZE(k101_im2ba02_init_cmds); i++) { > + const struct k101_im2ba02_init_cmd *cmd = &k101_im2ba02_init_cmds[i]; > + > + ret = mipi_dsi_dcs_write_buffer(dsi, cmd->data, K101_IM2BA02_INIT_CMD_LEN); > + if (ret < 0) > + return ret; > + } > + > + return 0; > +} > + > +static int k101_im2ba02_enable(struct drm_panel *panel) > +{ > + struct k101_im2ba02 *ctx = panel_to_k101_im2ba02(panel); > + const struct k101_im2ba02_init_cmd *cmd = &timed_cmds[1]; > + int ret; > + > + msleep(150); > + > + ret = mipi_dsi_dcs_set_display_on(ctx->dsi); > + if (ret < 0) > + return ret; > + > + msleep(50); > + > + return mipi_dsi_dcs_write_buffer(ctx->dsi, cmd->data, K101_IM2BA02_INIT_CMD_LEN); > + if (ret < 0) > + return ret; The last two lines can be deleted - they are never reached. > +} > + > +static int k101_im2ba02_disable(struct drm_panel *panel) > +{ > + struct k101_im2ba02 *ctx = panel_to_k101_im2ba02(panel); > + > + return mipi_dsi_dcs_set_display_off(ctx->dsi); > +} > + > +static int k101_im2ba02_unprepare(struct drm_panel *panel) > +{ > + struct k101_im2ba02 *ctx = panel_to_k101_im2ba02(panel); > + int ret; > + > + ret = mipi_dsi_dcs_set_display_off(ctx->dsi); > + if (ret < 0) > + DRM_DEV_ERROR(panel->dev, "failed to set display off: %d\n", > + ret); > + > + ret = mipi_dsi_dcs_enter_sleep_mode(ctx->dsi); > + if (ret < 0) > + DRM_DEV_ERROR(panel->dev, "failed to enter sleep mode: %d\n", > + ret); > + > + msleep(200); > + > + gpiod_set_value(ctx->reset, 0); > + > + msleep(20); > + > + regulator_disable(ctx->cvdd); > + > + msleep(20); > + > + regulator_disable(ctx->dvdd); > + > + msleep(20); > + > + regulator_disable(ctx->avdd); Can we get rid of a few empty lines here? If the 20 msecs are not really needed then use regulator_bulk_disable() > + return 0; > +} > + > +static const struct drm_display_mode k101_im2ba02_default_mode = { > + .clock = 70000, > + .vrefresh = 60, > + > + .hdisplay = 800, > + .hsync_start = 800 + 20, > + .hsync_end = 800 + 20 + 20, > + .htotal = 800 + 20 + 20 + 20, > + > + .vdisplay = 1280, > + .vsync_start = 1280 + 16, > + .vsync_end = 1280 + 16 + 4, > + .vtotal = 1280 + 16 + 4 + 4, > + > + .type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED, > + .width_mm = 136, > + .height_mm = 217, > +}; > + > +static int k101_im2ba02_get_modes(struct drm_panel *panel, > + struct drm_connector *connector) > +{ > + struct k101_im2ba02 *ctx = panel_to_k101_im2ba02(panel); > + struct drm_display_mode *mode; > + > + mode = drm_mode_duplicate(connector->dev, &k101_im2ba02_default_mode); > + if (!mode) { > + DRM_DEV_ERROR(&ctx->dsi->dev, "failed to add mode %ux%ux@%u\n", > + k101_im2ba02_default_mode.hdisplay, > + k101_im2ba02_default_mode.vdisplay, > + k101_im2ba02_default_mode.vrefresh); > + return -ENOMEM; > + } > + > + drm_mode_set_name(mode); > + > + mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED; > + connector->display_info.width_mm = mode->width_mm; > + connector->display_info.height_mm = mode->height_mm; > + drm_mode_probed_add(connector, mode); > + > + return 1; > +} > + > +static const struct drm_panel_funcs k101_im2ba02_funcs = { > + .disable = k101_im2ba02_disable, > + .unprepare = k101_im2ba02_unprepare, > + .prepare = k101_im2ba02_prepare, > + .enable = k101_im2ba02_enable, > + .get_modes = k101_im2ba02_get_modes, > +}; > + > +static int k101_im2ba02_dsi_probe(struct mipi_dsi_device *dsi) > +{ > + struct k101_im2ba02 *ctx; > + int ret; > + > + ctx = devm_kzalloc(&dsi->dev, sizeof(*ctx), GFP_KERNEL); > + if (!ctx) > + return -ENOMEM; > + > + mipi_dsi_set_drvdata(dsi, ctx); > + ctx->dsi = dsi; > + > + ctx->dvdd = devm_regulator_get(&dsi->dev, "dvdd"); > + if (IS_ERR(ctx->dvdd)) { > + DRM_DEV_ERROR(&dsi->dev, "Couldn't get dvdd regulator\n"); > + return PTR_ERR(ctx->dvdd); > + } > + > + ctx->avdd = devm_regulator_get(&dsi->dev, "avdd"); > + if (IS_ERR(ctx->avdd)) { > + DRM_DEV_ERROR(&dsi->dev, "Couldn't get avdd regulator\n"); > + return PTR_ERR(ctx->avdd); > + } > + > + ctx->cvdd = devm_regulator_get(&dsi->dev, "cvdd"); > + if (IS_ERR(ctx->cvdd)) { > + DRM_DEV_ERROR(&dsi->dev, "Couldn't get cvdd regulator\n"); > + return PTR_ERR(ctx->cvdd); > + } > + > + ctx->reset = devm_gpiod_get(&dsi->dev, "reset", GPIOD_OUT_LOW); > + if (IS_ERR(ctx->reset)) { > + DRM_DEV_ERROR(&dsi->dev, "Couldn't get our reset GPIO\n"); > + return PTR_ERR(ctx->reset); > + } > + > + drm_panel_init(&ctx->panel, &dsi->dev, &k101_im2ba02_funcs, > + DRM_MODE_CONNECTOR_DSI); > + > + ret = drm_panel_of_backlight(&ctx->panel); > + if (ret) > + return ret; > + > + ret = drm_panel_add(&ctx->panel); > + if (ret < 0) > + return ret; > + > + dsi->mode_flags = MIPI_DSI_MODE_VIDEO; > + dsi->format = MIPI_DSI_FMT_RGB888; > + dsi->lanes = 4; > + > + ret = mipi_dsi_attach(dsi); > + if (ret < 0) { > + drm_panel_remove(&ctx->panel); > + return ret; > + } > + > + return 0; > +} > + > +static int k101_im2ba02_dsi_remove(struct mipi_dsi_device *dsi) > +{ > + struct k101_im2ba02 *ctx = mipi_dsi_get_drvdata(dsi); > + > + mipi_dsi_detach(dsi); > + drm_panel_remove(&ctx->panel); > + > + return 0; > +} > + > +static const struct of_device_id k101_im2ba02_of_match[] = { > + { .compatible = "feixin,k101-im2ba02", }, > + { } Use { /* sentinel */ }, > +}; > +MODULE_DEVICE_TABLE(of, k101_im2ba02_of_match); > + > +static struct mipi_dsi_driver k101_im2ba02_driver = { > + .probe = k101_im2ba02_dsi_probe, > + .remove = k101_im2ba02_dsi_remove, > + .driver = { > + .name = "feixin-k101-im2ba02", > + .of_match_table = k101_im2ba02_of_match, > + }, > +}; > +module_mipi_dsi_driver(k101_im2ba02_driver); > + > +MODULE_AUTHOR("Icenowy Zheng "); > +MODULE_DESCRIPTION("Feixin K101 IM2BA02 MIPI-DSI LCD panel"); > +MODULE_LICENSE("GPL"); > -- > 2.23.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71385C282DD for ; Fri, 10 Jan 2020 17:46:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C5C2206ED for ; Fri, 10 Jan 2020 17:46:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ncka+uwW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C5C2206ED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Efjo3Ky9pwBDbo+yZHULfQKy6NcnWczPo/9m9J6W3oY=; b=ncka+uwWfO1FlB 3TyGJ8RT+u8j6THz5D8txWVAP+3QjQuJ9EYCgUQNh9KKXmHLQ28Xk1vPjEEVVFugltFbeaOTldx/i d0dNgSZfz5eCBSUAQtTAq/+ScjYpYrKwanzO2IuSSD5SONMpiAwrfmKE74PWLlu8R05emO3QDYsnH wYWj+TzSqpJblm8tXX0UaxMyLyGQ4k/8DKFrLpZ4tegBBBuYqU75YYHlDz1+7S0rsEvulVOQsG+pf aTh935oqM/AR68xP98XAdWFyl1HEBfCzvI3aMVQ+FwSXg0DGHPD3k5l+5YId4TK/eOH0jG9jCpNrI 1fw6i24kNgs+YJovZIYg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipyMO-0006ma-Sk; Fri, 10 Jan 2020 17:46:12 +0000 Received: from asavdk3.altibox.net ([109.247.116.14]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipyML-0006le-QX for linux-arm-kernel@lists.infradead.org; Fri, 10 Jan 2020 17:46:11 +0000 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id EE7A920057; Fri, 10 Jan 2020 18:46:04 +0100 (CET) Date: Fri, 10 Jan 2020 18:46:03 +0100 From: Sam Ravnborg To: Icenowy Zheng Subject: Re: [PATCH 3/5] drm/panel: Add Feixin K101 IM2BA02 panel Message-ID: <20200110174603.GC25099@ravnborg.org> References: <20200110155225.1051749-1-icenowy@aosc.io> <20200110155225.1051749-4-icenowy@aosc.io> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200110155225.1051749-4-icenowy@aosc.io> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=eMA9ckh1 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=bNPPjxCvKY4QfMc8yoEA:9 a=CjuIK1q_8ugA:10 a=pHzHmUro8NiASowvMSCR:22 a=6VlIyEUom7LUIeUMNQJH:22 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200110_094610_224322_BFDFD1A9 X-CRM114-Status: GOOD ( 22.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, David Airlie , linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, Maxime Ripard , Chen-Yu Tsai , Rob Herring , Thierry Reding , dri-devel@lists.freedesktop.org, Daniel Vetter , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Icenowy. On Fri, Jan 10, 2020 at 11:52:23PM +0800, Icenowy Zheng wrote: > Feixin K101 IM2BA02 is a 800x1280 4-lane MIPI-DSI LCD panel. > > Add a panel driver for it. Thanks, driver looks really good. Only a few comments/nits below. Sam > > Signed-off-by: Icenowy Zheng > --- > MAINTAINERS | 6 + > drivers/gpu/drm/panel/Kconfig | 9 + > drivers/gpu/drm/panel/Makefile | 1 + > .../gpu/drm/panel/panel-feixin-k101-im2ba02.c | 548 ++++++++++++++++++ > 4 files changed, 564 insertions(+) > create mode 100644 drivers/gpu/drm/panel/panel-feixin-k101-im2ba02.c > > new file mode 100644 > index 000000000000..45a62bdabb3f > --- /dev/null > +++ b/drivers/gpu/drm/panel/panel-feixin-k101-im2ba02.c > @@ -0,0 +1,548 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Copyright (C) 2019-2020 Icenowy Zheng > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > +#include > +#include Sorted and in the right order - good. > + > +static int k101_im2ba02_prepare(struct drm_panel *panel) > +{ > + struct k101_im2ba02 *ctx = panel_to_k101_im2ba02(panel); > + struct mipi_dsi_device *dsi = ctx->dsi; > + unsigned int i; > + int ret; > + > + ret = regulator_enable(ctx->avdd); > + if (ret) > + return ret; > + > + msleep(20); > + > + ret = regulator_enable(ctx->dvdd); > + if (ret) > + return ret; > + > + msleep(20); > + > + ret = regulator_enable(ctx->cvdd); > + if (ret) > + return ret; Unless the msleep() between is regulator_enable() really is needed, this change this to use regulator_bulk_enable(). If the above is kept then please do proper error handling where all enabled regulators are disable in case of errors. > + > + msleep(30); > + > + gpiod_set_value(ctx->reset, 1); > + msleep(50); > + > + gpiod_set_value(ctx->reset, 0); > + msleep(50); > + > + gpiod_set_value(ctx->reset, 1); > + msleep(200); > + > + for (i = 0; i < ARRAY_SIZE(k101_im2ba02_init_cmds); i++) { > + const struct k101_im2ba02_init_cmd *cmd = &k101_im2ba02_init_cmds[i]; > + > + ret = mipi_dsi_dcs_write_buffer(dsi, cmd->data, K101_IM2BA02_INIT_CMD_LEN); > + if (ret < 0) > + return ret; > + } > + > + return 0; > +} > + > +static int k101_im2ba02_enable(struct drm_panel *panel) > +{ > + struct k101_im2ba02 *ctx = panel_to_k101_im2ba02(panel); > + const struct k101_im2ba02_init_cmd *cmd = &timed_cmds[1]; > + int ret; > + > + msleep(150); > + > + ret = mipi_dsi_dcs_set_display_on(ctx->dsi); > + if (ret < 0) > + return ret; > + > + msleep(50); > + > + return mipi_dsi_dcs_write_buffer(ctx->dsi, cmd->data, K101_IM2BA02_INIT_CMD_LEN); > + if (ret < 0) > + return ret; The last two lines can be deleted - they are never reached. > +} > + > +static int k101_im2ba02_disable(struct drm_panel *panel) > +{ > + struct k101_im2ba02 *ctx = panel_to_k101_im2ba02(panel); > + > + return mipi_dsi_dcs_set_display_off(ctx->dsi); > +} > + > +static int k101_im2ba02_unprepare(struct drm_panel *panel) > +{ > + struct k101_im2ba02 *ctx = panel_to_k101_im2ba02(panel); > + int ret; > + > + ret = mipi_dsi_dcs_set_display_off(ctx->dsi); > + if (ret < 0) > + DRM_DEV_ERROR(panel->dev, "failed to set display off: %d\n", > + ret); > + > + ret = mipi_dsi_dcs_enter_sleep_mode(ctx->dsi); > + if (ret < 0) > + DRM_DEV_ERROR(panel->dev, "failed to enter sleep mode: %d\n", > + ret); > + > + msleep(200); > + > + gpiod_set_value(ctx->reset, 0); > + > + msleep(20); > + > + regulator_disable(ctx->cvdd); > + > + msleep(20); > + > + regulator_disable(ctx->dvdd); > + > + msleep(20); > + > + regulator_disable(ctx->avdd); Can we get rid of a few empty lines here? If the 20 msecs are not really needed then use regulator_bulk_disable() > + return 0; > +} > + > +static const struct drm_display_mode k101_im2ba02_default_mode = { > + .clock = 70000, > + .vrefresh = 60, > + > + .hdisplay = 800, > + .hsync_start = 800 + 20, > + .hsync_end = 800 + 20 + 20, > + .htotal = 800 + 20 + 20 + 20, > + > + .vdisplay = 1280, > + .vsync_start = 1280 + 16, > + .vsync_end = 1280 + 16 + 4, > + .vtotal = 1280 + 16 + 4 + 4, > + > + .type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED, > + .width_mm = 136, > + .height_mm = 217, > +}; > + > +static int k101_im2ba02_get_modes(struct drm_panel *panel, > + struct drm_connector *connector) > +{ > + struct k101_im2ba02 *ctx = panel_to_k101_im2ba02(panel); > + struct drm_display_mode *mode; > + > + mode = drm_mode_duplicate(connector->dev, &k101_im2ba02_default_mode); > + if (!mode) { > + DRM_DEV_ERROR(&ctx->dsi->dev, "failed to add mode %ux%ux@%u\n", > + k101_im2ba02_default_mode.hdisplay, > + k101_im2ba02_default_mode.vdisplay, > + k101_im2ba02_default_mode.vrefresh); > + return -ENOMEM; > + } > + > + drm_mode_set_name(mode); > + > + mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED; > + connector->display_info.width_mm = mode->width_mm; > + connector->display_info.height_mm = mode->height_mm; > + drm_mode_probed_add(connector, mode); > + > + return 1; > +} > + > +static const struct drm_panel_funcs k101_im2ba02_funcs = { > + .disable = k101_im2ba02_disable, > + .unprepare = k101_im2ba02_unprepare, > + .prepare = k101_im2ba02_prepare, > + .enable = k101_im2ba02_enable, > + .get_modes = k101_im2ba02_get_modes, > +}; > + > +static int k101_im2ba02_dsi_probe(struct mipi_dsi_device *dsi) > +{ > + struct k101_im2ba02 *ctx; > + int ret; > + > + ctx = devm_kzalloc(&dsi->dev, sizeof(*ctx), GFP_KERNEL); > + if (!ctx) > + return -ENOMEM; > + > + mipi_dsi_set_drvdata(dsi, ctx); > + ctx->dsi = dsi; > + > + ctx->dvdd = devm_regulator_get(&dsi->dev, "dvdd"); > + if (IS_ERR(ctx->dvdd)) { > + DRM_DEV_ERROR(&dsi->dev, "Couldn't get dvdd regulator\n"); > + return PTR_ERR(ctx->dvdd); > + } > + > + ctx->avdd = devm_regulator_get(&dsi->dev, "avdd"); > + if (IS_ERR(ctx->avdd)) { > + DRM_DEV_ERROR(&dsi->dev, "Couldn't get avdd regulator\n"); > + return PTR_ERR(ctx->avdd); > + } > + > + ctx->cvdd = devm_regulator_get(&dsi->dev, "cvdd"); > + if (IS_ERR(ctx->cvdd)) { > + DRM_DEV_ERROR(&dsi->dev, "Couldn't get cvdd regulator\n"); > + return PTR_ERR(ctx->cvdd); > + } > + > + ctx->reset = devm_gpiod_get(&dsi->dev, "reset", GPIOD_OUT_LOW); > + if (IS_ERR(ctx->reset)) { > + DRM_DEV_ERROR(&dsi->dev, "Couldn't get our reset GPIO\n"); > + return PTR_ERR(ctx->reset); > + } > + > + drm_panel_init(&ctx->panel, &dsi->dev, &k101_im2ba02_funcs, > + DRM_MODE_CONNECTOR_DSI); > + > + ret = drm_panel_of_backlight(&ctx->panel); > + if (ret) > + return ret; > + > + ret = drm_panel_add(&ctx->panel); > + if (ret < 0) > + return ret; > + > + dsi->mode_flags = MIPI_DSI_MODE_VIDEO; > + dsi->format = MIPI_DSI_FMT_RGB888; > + dsi->lanes = 4; > + > + ret = mipi_dsi_attach(dsi); > + if (ret < 0) { > + drm_panel_remove(&ctx->panel); > + return ret; > + } > + > + return 0; > +} > + > +static int k101_im2ba02_dsi_remove(struct mipi_dsi_device *dsi) > +{ > + struct k101_im2ba02 *ctx = mipi_dsi_get_drvdata(dsi); > + > + mipi_dsi_detach(dsi); > + drm_panel_remove(&ctx->panel); > + > + return 0; > +} > + > +static const struct of_device_id k101_im2ba02_of_match[] = { > + { .compatible = "feixin,k101-im2ba02", }, > + { } Use { /* sentinel */ }, > +}; > +MODULE_DEVICE_TABLE(of, k101_im2ba02_of_match); > + > +static struct mipi_dsi_driver k101_im2ba02_driver = { > + .probe = k101_im2ba02_dsi_probe, > + .remove = k101_im2ba02_dsi_remove, > + .driver = { > + .name = "feixin-k101-im2ba02", > + .of_match_table = k101_im2ba02_of_match, > + }, > +}; > +module_mipi_dsi_driver(k101_im2ba02_driver); > + > +MODULE_AUTHOR("Icenowy Zheng "); > +MODULE_DESCRIPTION("Feixin K101 IM2BA02 MIPI-DSI LCD panel"); > +MODULE_LICENSE("GPL"); > -- > 2.23.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCDCCC282DD for ; Fri, 10 Jan 2020 17:46:09 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA5F520678 for ; Fri, 10 Jan 2020 17:46:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA5F520678 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EBE436EA71; Fri, 10 Jan 2020 17:46:08 +0000 (UTC) Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3C6386EA71 for ; Fri, 10 Jan 2020 17:46:07 +0000 (UTC) Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id EE7A920057; Fri, 10 Jan 2020 18:46:04 +0100 (CET) Date: Fri, 10 Jan 2020 18:46:03 +0100 From: Sam Ravnborg To: Icenowy Zheng Subject: Re: [PATCH 3/5] drm/panel: Add Feixin K101 IM2BA02 panel Message-ID: <20200110174603.GC25099@ravnborg.org> References: <20200110155225.1051749-1-icenowy@aosc.io> <20200110155225.1051749-4-icenowy@aosc.io> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200110155225.1051749-4-icenowy@aosc.io> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=eMA9ckh1 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=bNPPjxCvKY4QfMc8yoEA:9 a=CjuIK1q_8ugA:10 a=pHzHmUro8NiASowvMSCR:22 a=6VlIyEUom7LUIeUMNQJH:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, David Airlie , linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, Chen-Yu Tsai , Rob Herring , Thierry Reding , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Icenowy. On Fri, Jan 10, 2020 at 11:52:23PM +0800, Icenowy Zheng wrote: > Feixin K101 IM2BA02 is a 800x1280 4-lane MIPI-DSI LCD panel. > > Add a panel driver for it. Thanks, driver looks really good. Only a few comments/nits below. Sam > > Signed-off-by: Icenowy Zheng > --- > MAINTAINERS | 6 + > drivers/gpu/drm/panel/Kconfig | 9 + > drivers/gpu/drm/panel/Makefile | 1 + > .../gpu/drm/panel/panel-feixin-k101-im2ba02.c | 548 ++++++++++++++++++ > 4 files changed, 564 insertions(+) > create mode 100644 drivers/gpu/drm/panel/panel-feixin-k101-im2ba02.c > > new file mode 100644 > index 000000000000..45a62bdabb3f > --- /dev/null > +++ b/drivers/gpu/drm/panel/panel-feixin-k101-im2ba02.c > @@ -0,0 +1,548 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Copyright (C) 2019-2020 Icenowy Zheng > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > +#include > +#include Sorted and in the right order - good. > + > +static int k101_im2ba02_prepare(struct drm_panel *panel) > +{ > + struct k101_im2ba02 *ctx = panel_to_k101_im2ba02(panel); > + struct mipi_dsi_device *dsi = ctx->dsi; > + unsigned int i; > + int ret; > + > + ret = regulator_enable(ctx->avdd); > + if (ret) > + return ret; > + > + msleep(20); > + > + ret = regulator_enable(ctx->dvdd); > + if (ret) > + return ret; > + > + msleep(20); > + > + ret = regulator_enable(ctx->cvdd); > + if (ret) > + return ret; Unless the msleep() between is regulator_enable() really is needed, this change this to use regulator_bulk_enable(). If the above is kept then please do proper error handling where all enabled regulators are disable in case of errors. > + > + msleep(30); > + > + gpiod_set_value(ctx->reset, 1); > + msleep(50); > + > + gpiod_set_value(ctx->reset, 0); > + msleep(50); > + > + gpiod_set_value(ctx->reset, 1); > + msleep(200); > + > + for (i = 0; i < ARRAY_SIZE(k101_im2ba02_init_cmds); i++) { > + const struct k101_im2ba02_init_cmd *cmd = &k101_im2ba02_init_cmds[i]; > + > + ret = mipi_dsi_dcs_write_buffer(dsi, cmd->data, K101_IM2BA02_INIT_CMD_LEN); > + if (ret < 0) > + return ret; > + } > + > + return 0; > +} > + > +static int k101_im2ba02_enable(struct drm_panel *panel) > +{ > + struct k101_im2ba02 *ctx = panel_to_k101_im2ba02(panel); > + const struct k101_im2ba02_init_cmd *cmd = &timed_cmds[1]; > + int ret; > + > + msleep(150); > + > + ret = mipi_dsi_dcs_set_display_on(ctx->dsi); > + if (ret < 0) > + return ret; > + > + msleep(50); > + > + return mipi_dsi_dcs_write_buffer(ctx->dsi, cmd->data, K101_IM2BA02_INIT_CMD_LEN); > + if (ret < 0) > + return ret; The last two lines can be deleted - they are never reached. > +} > + > +static int k101_im2ba02_disable(struct drm_panel *panel) > +{ > + struct k101_im2ba02 *ctx = panel_to_k101_im2ba02(panel); > + > + return mipi_dsi_dcs_set_display_off(ctx->dsi); > +} > + > +static int k101_im2ba02_unprepare(struct drm_panel *panel) > +{ > + struct k101_im2ba02 *ctx = panel_to_k101_im2ba02(panel); > + int ret; > + > + ret = mipi_dsi_dcs_set_display_off(ctx->dsi); > + if (ret < 0) > + DRM_DEV_ERROR(panel->dev, "failed to set display off: %d\n", > + ret); > + > + ret = mipi_dsi_dcs_enter_sleep_mode(ctx->dsi); > + if (ret < 0) > + DRM_DEV_ERROR(panel->dev, "failed to enter sleep mode: %d\n", > + ret); > + > + msleep(200); > + > + gpiod_set_value(ctx->reset, 0); > + > + msleep(20); > + > + regulator_disable(ctx->cvdd); > + > + msleep(20); > + > + regulator_disable(ctx->dvdd); > + > + msleep(20); > + > + regulator_disable(ctx->avdd); Can we get rid of a few empty lines here? If the 20 msecs are not really needed then use regulator_bulk_disable() > + return 0; > +} > + > +static const struct drm_display_mode k101_im2ba02_default_mode = { > + .clock = 70000, > + .vrefresh = 60, > + > + .hdisplay = 800, > + .hsync_start = 800 + 20, > + .hsync_end = 800 + 20 + 20, > + .htotal = 800 + 20 + 20 + 20, > + > + .vdisplay = 1280, > + .vsync_start = 1280 + 16, > + .vsync_end = 1280 + 16 + 4, > + .vtotal = 1280 + 16 + 4 + 4, > + > + .type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED, > + .width_mm = 136, > + .height_mm = 217, > +}; > + > +static int k101_im2ba02_get_modes(struct drm_panel *panel, > + struct drm_connector *connector) > +{ > + struct k101_im2ba02 *ctx = panel_to_k101_im2ba02(panel); > + struct drm_display_mode *mode; > + > + mode = drm_mode_duplicate(connector->dev, &k101_im2ba02_default_mode); > + if (!mode) { > + DRM_DEV_ERROR(&ctx->dsi->dev, "failed to add mode %ux%ux@%u\n", > + k101_im2ba02_default_mode.hdisplay, > + k101_im2ba02_default_mode.vdisplay, > + k101_im2ba02_default_mode.vrefresh); > + return -ENOMEM; > + } > + > + drm_mode_set_name(mode); > + > + mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED; > + connector->display_info.width_mm = mode->width_mm; > + connector->display_info.height_mm = mode->height_mm; > + drm_mode_probed_add(connector, mode); > + > + return 1; > +} > + > +static const struct drm_panel_funcs k101_im2ba02_funcs = { > + .disable = k101_im2ba02_disable, > + .unprepare = k101_im2ba02_unprepare, > + .prepare = k101_im2ba02_prepare, > + .enable = k101_im2ba02_enable, > + .get_modes = k101_im2ba02_get_modes, > +}; > + > +static int k101_im2ba02_dsi_probe(struct mipi_dsi_device *dsi) > +{ > + struct k101_im2ba02 *ctx; > + int ret; > + > + ctx = devm_kzalloc(&dsi->dev, sizeof(*ctx), GFP_KERNEL); > + if (!ctx) > + return -ENOMEM; > + > + mipi_dsi_set_drvdata(dsi, ctx); > + ctx->dsi = dsi; > + > + ctx->dvdd = devm_regulator_get(&dsi->dev, "dvdd"); > + if (IS_ERR(ctx->dvdd)) { > + DRM_DEV_ERROR(&dsi->dev, "Couldn't get dvdd regulator\n"); > + return PTR_ERR(ctx->dvdd); > + } > + > + ctx->avdd = devm_regulator_get(&dsi->dev, "avdd"); > + if (IS_ERR(ctx->avdd)) { > + DRM_DEV_ERROR(&dsi->dev, "Couldn't get avdd regulator\n"); > + return PTR_ERR(ctx->avdd); > + } > + > + ctx->cvdd = devm_regulator_get(&dsi->dev, "cvdd"); > + if (IS_ERR(ctx->cvdd)) { > + DRM_DEV_ERROR(&dsi->dev, "Couldn't get cvdd regulator\n"); > + return PTR_ERR(ctx->cvdd); > + } > + > + ctx->reset = devm_gpiod_get(&dsi->dev, "reset", GPIOD_OUT_LOW); > + if (IS_ERR(ctx->reset)) { > + DRM_DEV_ERROR(&dsi->dev, "Couldn't get our reset GPIO\n"); > + return PTR_ERR(ctx->reset); > + } > + > + drm_panel_init(&ctx->panel, &dsi->dev, &k101_im2ba02_funcs, > + DRM_MODE_CONNECTOR_DSI); > + > + ret = drm_panel_of_backlight(&ctx->panel); > + if (ret) > + return ret; > + > + ret = drm_panel_add(&ctx->panel); > + if (ret < 0) > + return ret; > + > + dsi->mode_flags = MIPI_DSI_MODE_VIDEO; > + dsi->format = MIPI_DSI_FMT_RGB888; > + dsi->lanes = 4; > + > + ret = mipi_dsi_attach(dsi); > + if (ret < 0) { > + drm_panel_remove(&ctx->panel); > + return ret; > + } > + > + return 0; > +} > + > +static int k101_im2ba02_dsi_remove(struct mipi_dsi_device *dsi) > +{ > + struct k101_im2ba02 *ctx = mipi_dsi_get_drvdata(dsi); > + > + mipi_dsi_detach(dsi); > + drm_panel_remove(&ctx->panel); > + > + return 0; > +} > + > +static const struct of_device_id k101_im2ba02_of_match[] = { > + { .compatible = "feixin,k101-im2ba02", }, > + { } Use { /* sentinel */ }, > +}; > +MODULE_DEVICE_TABLE(of, k101_im2ba02_of_match); > + > +static struct mipi_dsi_driver k101_im2ba02_driver = { > + .probe = k101_im2ba02_dsi_probe, > + .remove = k101_im2ba02_dsi_remove, > + .driver = { > + .name = "feixin-k101-im2ba02", > + .of_match_table = k101_im2ba02_of_match, > + }, > +}; > +module_mipi_dsi_driver(k101_im2ba02_driver); > + > +MODULE_AUTHOR("Icenowy Zheng "); > +MODULE_DESCRIPTION("Feixin K101 IM2BA02 MIPI-DSI LCD panel"); > +MODULE_LICENSE("GPL"); > -- > 2.23.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel