From: Sam Ravnborg <sam@ravnborg.org>
To: Icenowy Zheng <icenowy@aosc.io>
Cc: Rob Herring <robh+dt@kernel.org>,
Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Thierry Reding <thierry.reding@gmail.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-sunxi@googlegroups.com
Subject: Re: [PATCH 5/5] arm64: dts: allwinner: a64: add support for PineTab
Date: Fri, 10 Jan 2020 19:12:21 +0100 [thread overview]
Message-ID: <20200110181220.GA27540@ravnborg.org> (raw)
In-Reply-To: <20200110155225.1051749-6-icenowy@aosc.io>
Hi Icenowy.
checkpatch noticed a small inconsistency in the i2c1 node.
>
> Misc:
> - Debug UART is muxed with the headphone jack, with the switch next to
> the microSD slot.
> - A bosch BMA223 accelerometer is connected to the I2C bus of A64 SoC.
> - Wi-Fi and Bluetooth are available via a RTL8723CS chip, similar to the
> one in Pinebook.
>
> +
> +&i2c1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2c1_pins>;
> + status = "okay";
> +
> + bma223@18 {
> + compatible = "bosch,bma223", "bosch,bma222e";
These compatible have no binding file?!?
> + reg = <0x18>;
> + interrupt-parent = <&pio>;
> + interrupts = <7 5 IRQ_TYPE_LEVEL_HIGH>; /* PH5 */
> + mount-matrix = "0", "-1", "0",
> + "-1", "0", "0",
> + "0", "0", "-1";
> + };
> +};
bosch,bma222e is referenced by a driver, whereas this is the
first reference of bosch,bma223.
Sam
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Icenowy Zheng <icenowy@aosc.io>
Cc: devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org,
Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Rob Herring <robh+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
dri-devel@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 5/5] arm64: dts: allwinner: a64: add support for PineTab
Date: Fri, 10 Jan 2020 19:12:21 +0100 [thread overview]
Message-ID: <20200110181220.GA27540@ravnborg.org> (raw)
In-Reply-To: <20200110155225.1051749-6-icenowy@aosc.io>
Hi Icenowy.
checkpatch noticed a small inconsistency in the i2c1 node.
>
> Misc:
> - Debug UART is muxed with the headphone jack, with the switch next to
> the microSD slot.
> - A bosch BMA223 accelerometer is connected to the I2C bus of A64 SoC.
> - Wi-Fi and Bluetooth are available via a RTL8723CS chip, similar to the
> one in Pinebook.
>
> +
> +&i2c1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2c1_pins>;
> + status = "okay";
> +
> + bma223@18 {
> + compatible = "bosch,bma223", "bosch,bma222e";
These compatible have no binding file?!?
> + reg = <0x18>;
> + interrupt-parent = <&pio>;
> + interrupts = <7 5 IRQ_TYPE_LEVEL_HIGH>; /* PH5 */
> + mount-matrix = "0", "-1", "0",
> + "-1", "0", "0",
> + "0", "0", "-1";
> + };
> +};
bosch,bma222e is referenced by a driver, whereas this is the
first reference of bosch,bma223.
Sam
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Icenowy Zheng <icenowy@aosc.io>
Cc: devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org,
Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 5/5] arm64: dts: allwinner: a64: add support for PineTab
Date: Fri, 10 Jan 2020 19:12:21 +0100 [thread overview]
Message-ID: <20200110181220.GA27540@ravnborg.org> (raw)
In-Reply-To: <20200110155225.1051749-6-icenowy@aosc.io>
Hi Icenowy.
checkpatch noticed a small inconsistency in the i2c1 node.
>
> Misc:
> - Debug UART is muxed with the headphone jack, with the switch next to
> the microSD slot.
> - A bosch BMA223 accelerometer is connected to the I2C bus of A64 SoC.
> - Wi-Fi and Bluetooth are available via a RTL8723CS chip, similar to the
> one in Pinebook.
>
> +
> +&i2c1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2c1_pins>;
> + status = "okay";
> +
> + bma223@18 {
> + compatible = "bosch,bma223", "bosch,bma222e";
These compatible have no binding file?!?
> + reg = <0x18>;
> + interrupt-parent = <&pio>;
> + interrupts = <7 5 IRQ_TYPE_LEVEL_HIGH>; /* PH5 */
> + mount-matrix = "0", "-1", "0",
> + "-1", "0", "0",
> + "0", "0", "-1";
> + };
> +};
bosch,bma222e is referenced by a driver, whereas this is the
first reference of bosch,bma223.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-01-10 18:12 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 15:52 [PATCH 0/5] Add support for Pine64 PineTab Icenowy Zheng
2020-01-10 15:52 ` Icenowy Zheng
2020-01-10 15:52 ` Icenowy Zheng
2020-01-10 15:52 ` [PATCH 1/5] dt-bindings: vendor-prefix: add Shenzhen Feixin Photoelectics Co., Ltd Icenowy Zheng
2020-01-10 15:52 ` Icenowy Zheng
2020-01-10 15:52 ` Icenowy Zheng
2020-01-10 17:07 ` Sam Ravnborg
2020-01-10 17:07 ` Sam Ravnborg
2020-01-10 17:07 ` Sam Ravnborg
2020-01-15 15:22 ` Rob Herring
2020-01-15 15:22 ` Rob Herring
2020-01-15 15:22 ` Rob Herring
2020-01-10 15:52 ` [PATCH 2/5] dt-bindings: panel: add Feixin K101 IM2BA02 MIPI-DSI panel Icenowy Zheng
2020-01-10 15:52 ` Icenowy Zheng
2020-01-10 15:52 ` Icenowy Zheng
2020-01-10 17:12 ` Sam Ravnborg
2020-01-10 17:12 ` Sam Ravnborg
2020-01-10 17:12 ` Sam Ravnborg
2020-01-10 15:52 ` [PATCH 3/5] drm/panel: Add Feixin K101 IM2BA02 panel Icenowy Zheng
2020-01-10 15:52 ` Icenowy Zheng
2020-01-10 15:52 ` Icenowy Zheng
2020-01-10 17:46 ` Sam Ravnborg
2020-01-10 17:46 ` Sam Ravnborg
2020-01-10 17:46 ` Sam Ravnborg
2020-01-10 15:52 ` [PATCH 4/5] dt-bindings: arm: sunxi: add binding for PineTab tablet Icenowy Zheng
2020-01-10 15:52 ` Icenowy Zheng
2020-01-10 15:52 ` Icenowy Zheng
2020-01-15 15:24 ` Rob Herring
2020-01-15 15:24 ` Rob Herring
2020-01-15 15:24 ` Rob Herring
2020-01-10 15:52 ` [PATCH 5/5] arm64: dts: allwinner: a64: add support for PineTab Icenowy Zheng
2020-01-10 15:52 ` Icenowy Zheng
2020-01-10 15:52 ` Icenowy Zheng
2020-01-10 17:23 ` Maxime Ripard
2020-01-10 17:23 ` Maxime Ripard
2020-01-10 17:23 ` Maxime Ripard
2020-01-10 18:12 ` Sam Ravnborg [this message]
2020-01-10 18:12 ` Sam Ravnborg
2020-01-10 18:12 ` Sam Ravnborg
2020-01-10 18:51 ` [linux-sunxi] " Vasily Khoruzhick
2020-01-10 18:51 ` Vasily Khoruzhick
2020-01-10 18:51 ` Vasily Khoruzhick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200110181220.GA27540@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=icenowy@aosc.io \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.