From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EAD2C3F68F for ; Fri, 10 Jan 2020 18:12:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 06B7D2080D for ; Fri, 10 Jan 2020 18:12:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728855AbgAJSM0 (ORCPT ); Fri, 10 Jan 2020 13:12:26 -0500 Received: from asavdk4.altibox.net ([109.247.116.15]:59292 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726789AbgAJSM0 (ORCPT ); Fri, 10 Jan 2020 13:12:26 -0500 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 78C0C803D4; Fri, 10 Jan 2020 19:12:22 +0100 (CET) Date: Fri, 10 Jan 2020 19:12:21 +0100 From: Sam Ravnborg To: Icenowy Zheng Cc: Rob Herring , Maxime Ripard , Chen-Yu Tsai , Thierry Reding , David Airlie , Daniel Vetter , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH 5/5] arm64: dts: allwinner: a64: add support for PineTab Message-ID: <20200110181220.GA27540@ravnborg.org> References: <20200110155225.1051749-1-icenowy@aosc.io> <20200110155225.1051749-6-icenowy@aosc.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200110155225.1051749-6-icenowy@aosc.io> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VcLZwmh9 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=8xDXtNipsti8RRz39MQA:9 a=CjuIK1q_8ugA:10 a=pHzHmUro8NiASowvMSCR:22 a=6VlIyEUom7LUIeUMNQJH:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Icenowy. checkpatch noticed a small inconsistency in the i2c1 node. > > Misc: > - Debug UART is muxed with the headphone jack, with the switch next to > the microSD slot. > - A bosch BMA223 accelerometer is connected to the I2C bus of A64 SoC. > - Wi-Fi and Bluetooth are available via a RTL8723CS chip, similar to the > one in Pinebook. > > + > +&i2c1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c1_pins>; > + status = "okay"; > + > + bma223@18 { > + compatible = "bosch,bma223", "bosch,bma222e"; These compatible have no binding file?!? > + reg = <0x18>; > + interrupt-parent = <&pio>; > + interrupts = <7 5 IRQ_TYPE_LEVEL_HIGH>; /* PH5 */ > + mount-matrix = "0", "-1", "0", > + "-1", "0", "0", > + "0", "0", "-1"; > + }; > +}; bosch,bma222e is referenced by a driver, whereas this is the first reference of bosch,bma223. Sam From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C874C282DD for ; Fri, 10 Jan 2020 18:12:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1444C2080D for ; Fri, 10 Jan 2020 18:12:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QAAgY1rG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1444C2080D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CcFTd7dR3AMHn+lMaJXnFm+BAA1vtiAXI4l+mT/4Tk4=; b=QAAgY1rGYzixyx Iqt7Wo5pta5LUsTHvur7d368Shb0RxPJuWbDo3FIxTv6uT/h73nmPwxtVMW53d6lKEYQqcDZ/ZDzc 5iFqXqElrCH6jMDl2NQtyGaa+Tm/pJJPynpjcmRxxLBzgG8FiRfjlNHRNBdSRL0VkRCcJ5xL9ABl6 50I4Dw6OAzNY5LsuJWXkQqjylyZouwad7h29wrYHFvvmmPoPZT9r/OhKPTTjANVKgqy4SRNoiiypE ico5y3BZyrfcd1J9N73+YDOS9doQ2tSm5jb0bWkzDDpN1ffHT9ErNSeFcKYQZ1i30dXJGmFoTLR+c miEIYSDYBkLdVD2ukRuA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipylp-000228-IY; Fri, 10 Jan 2020 18:12:29 +0000 Received: from asavdk4.altibox.net ([109.247.116.15]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ipyln-00021A-4W for linux-arm-kernel@lists.infradead.org; Fri, 10 Jan 2020 18:12:28 +0000 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 78C0C803D4; Fri, 10 Jan 2020 19:12:22 +0100 (CET) Date: Fri, 10 Jan 2020 19:12:21 +0100 From: Sam Ravnborg To: Icenowy Zheng Subject: Re: [PATCH 5/5] arm64: dts: allwinner: a64: add support for PineTab Message-ID: <20200110181220.GA27540@ravnborg.org> References: <20200110155225.1051749-1-icenowy@aosc.io> <20200110155225.1051749-6-icenowy@aosc.io> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200110155225.1051749-6-icenowy@aosc.io> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VcLZwmh9 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=8xDXtNipsti8RRz39MQA:9 a=CjuIK1q_8ugA:10 a=pHzHmUro8NiASowvMSCR:22 a=6VlIyEUom7LUIeUMNQJH:22 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200110_101227_356649_74449499 X-CRM114-Status: GOOD ( 13.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, David Airlie , linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, Maxime Ripard , Chen-Yu Tsai , Rob Herring , Thierry Reding , dri-devel@lists.freedesktop.org, Daniel Vetter , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Icenowy. checkpatch noticed a small inconsistency in the i2c1 node. > > Misc: > - Debug UART is muxed with the headphone jack, with the switch next to > the microSD slot. > - A bosch BMA223 accelerometer is connected to the I2C bus of A64 SoC. > - Wi-Fi and Bluetooth are available via a RTL8723CS chip, similar to the > one in Pinebook. > > + > +&i2c1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c1_pins>; > + status = "okay"; > + > + bma223@18 { > + compatible = "bosch,bma223", "bosch,bma222e"; These compatible have no binding file?!? > + reg = <0x18>; > + interrupt-parent = <&pio>; > + interrupts = <7 5 IRQ_TYPE_LEVEL_HIGH>; /* PH5 */ > + mount-matrix = "0", "-1", "0", > + "-1", "0", "0", > + "0", "0", "-1"; > + }; > +}; bosch,bma222e is referenced by a driver, whereas this is the first reference of bosch,bma223. Sam _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE86AC33CA4 for ; Fri, 10 Jan 2020 18:12:27 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A0AAC2080D for ; Fri, 10 Jan 2020 18:12:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A0AAC2080D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2156C89D4B; Fri, 10 Jan 2020 18:12:27 +0000 (UTC) Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 928A189D4B for ; Fri, 10 Jan 2020 18:12:25 +0000 (UTC) Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 78C0C803D4; Fri, 10 Jan 2020 19:12:22 +0100 (CET) Date: Fri, 10 Jan 2020 19:12:21 +0100 From: Sam Ravnborg To: Icenowy Zheng Subject: Re: [PATCH 5/5] arm64: dts: allwinner: a64: add support for PineTab Message-ID: <20200110181220.GA27540@ravnborg.org> References: <20200110155225.1051749-1-icenowy@aosc.io> <20200110155225.1051749-6-icenowy@aosc.io> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200110155225.1051749-6-icenowy@aosc.io> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VcLZwmh9 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=8xDXtNipsti8RRz39MQA:9 a=CjuIK1q_8ugA:10 a=pHzHmUro8NiASowvMSCR:22 a=6VlIyEUom7LUIeUMNQJH:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, David Airlie , linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, Chen-Yu Tsai , Rob Herring , Thierry Reding , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Icenowy. checkpatch noticed a small inconsistency in the i2c1 node. > > Misc: > - Debug UART is muxed with the headphone jack, with the switch next to > the microSD slot. > - A bosch BMA223 accelerometer is connected to the I2C bus of A64 SoC. > - Wi-Fi and Bluetooth are available via a RTL8723CS chip, similar to the > one in Pinebook. > > + > +&i2c1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c1_pins>; > + status = "okay"; > + > + bma223@18 { > + compatible = "bosch,bma223", "bosch,bma222e"; These compatible have no binding file?!? > + reg = <0x18>; > + interrupt-parent = <&pio>; > + interrupts = <7 5 IRQ_TYPE_LEVEL_HIGH>; /* PH5 */ > + mount-matrix = "0", "-1", "0", > + "-1", "0", "0", > + "0", "0", "-1"; > + }; > +}; bosch,bma222e is referenced by a driver, whereas this is the first reference of bosch,bma223. Sam _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel