From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 509FCC282DD for ; Fri, 10 Jan 2020 17:16:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1D6F620838 for ; Fri, 10 Jan 2020 17:16:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NpaAcbkL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D6F620838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49418 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipxtb-00031G-Rx for qemu-devel@archiver.kernel.org; Fri, 10 Jan 2020 12:16:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44385) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipxsA-00029s-FM for qemu-devel@nongnu.org; Fri, 10 Jan 2020 12:15:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ipxs7-00044T-AU for qemu-devel@nongnu.org; Fri, 10 Jan 2020 12:14:56 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:22793 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ipxs6-000413-WD for qemu-devel@nongnu.org; Fri, 10 Jan 2020 12:14:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578676493; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6xZdGZTYCdkB6RlGHCUvBf3kH1Ssz/FqmrkJqQAeCUg=; b=NpaAcbkL3er1J7hWkYTlTV23Y8hmldWnFLvjY5MqXl7IeCIv9LY7pLgnOGJMiNNhPamIPL 8zXn+kjRqQqE76U/krqMViEPhLemQlV4xaIkn1edmlO/OR+jqhSA3/DxLx4GhTh7wy4Wci bFMgWp5MmXMef5aGdptmcrX2lSiNUkY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-93-utkTlDF4NgmxKJ3ll4beHw-1; Fri, 10 Jan 2020 12:14:50 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 88D6A801E67; Fri, 10 Jan 2020 17:14:48 +0000 (UTC) Received: from localhost (unknown [10.43.2.114]) by smtp.corp.redhat.com (Postfix) with ESMTP id DC5B419C58; Fri, 10 Jan 2020 17:14:47 +0000 (UTC) Date: Fri, 10 Jan 2020 18:14:45 +0100 From: Igor Mammedov To: BALATON Zoltan Subject: Re: [PATCH 66/86] ppc:ppc440_bamboo/sam460ex: drop RAM size fixup Message-ID: <20200110181445.1e3c4a6c@redhat.com> In-Reply-To: References: <1577797450-88458-1-git-send-email-imammedo@redhat.com> <1577797450-88458-67-git-send-email-imammedo@redhat.com> <20200102124749.03a0368d@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: utkTlDF4NgmxKJ3ll4beHw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 2 Jan 2020 16:52:50 +0100 (CET) BALATON Zoltan wrote: > On Thu, 2 Jan 2020, Igor Mammedov wrote: > > On Wed, 1 Jan 2020 12:54:37 +0100 (CET) > > BALATON Zoltan wrote: > >> On Tue, 31 Dec 2019, Igor Mammedov wrote: > >>> If user provided non-sense RAM size, board will complain and > >>> continue running with max RAM size supported. > >>> Also RAM is going to be allocated by generic code, so it won't be > >>> possible for board to fix things up for user. > >>> > >>> Make it error message and exit to force user fix CLI, > >>> instead of accepting non-sense CLI values. > >>> > >>> Signed-off-by: Igor Mammedov > >>> --- > >>> include/hw/ppc/ppc4xx.h | 9 ++++----- > >>> hw/ppc/ppc440_bamboo.c | 11 ++++------- > >>> hw/ppc/ppc4xx_devs.c | 26 ++++++++++++++++---------- > >>> hw/ppc/sam460ex.c | 5 ++--- > >>> 4 files changed, 26 insertions(+), 25 deletions(-) > >>> > >>> diff --git a/include/hw/ppc/ppc4xx.h b/include/hw/ppc/ppc4xx.h > >>> index 7d82259..1a28127 100644 > >>> --- a/include/hw/ppc/ppc4xx.h > >>> +++ b/include/hw/ppc/ppc4xx.h > >>> @@ -42,11 +42,10 @@ enum { > >>> qemu_irq *ppcuic_init (CPUPPCState *env, qemu_irq *irqs, > >>> uint32_t dcr_base, int has_ssr, int has_vr); > >>> > >>> -ram_addr_t ppc4xx_sdram_adjust(ram_addr_t ram_size, int nr_banks, > >>> - MemoryRegion ram_memories[], > >>> - hwaddr ram_bases[], > >>> - hwaddr ram_sizes[], > >>> - const ram_addr_t sdram_bank_sizes[]); > >>> +void ppc4xx_sdram_adjust(ram_addr_t ram_size, int nr_banks, > >>> + MemoryRegion ram_memories[], > >>> + hwaddr ram_bases[], hwaddr ram_sizes[], > >>> + const ram_addr_t sdram_bank_sizes[]); > >> > >> With this change this function does not adjust ram size any more so it may > >> need to be renamed, e.g. ppc4xx_sdram_banks or something else. > >> > >> A better patch title may be > >> > >> ppc/{ppc440_bamboo,sam460x}: drop RAM size fixup > >> > >> (or without curly braces at your preference). > > I'll rename and use this subj as you suggest on v2. > > > >> This is inconvenient for the user because it worked whatever number > >> they've given but now they have to do the math. So it suggests that what > >> you're replacing this with may not support all the existing use cases. If > >> that can't be fixed to allow checking and changing ram size (maybe via a > >> callback in board code similar to above adjust function returning adjusted > >> size) it may be OK to drop this convenience for the sake of cleaning up > >> code elsewhere. > > > > There were few boards that did fix up and in all cases it was to cover up > > invalid CLI input. > > Creating callback for fixing user mistake doesn't seems to me justified, > > I'd much prefer to have a hard error and consistent behavior across all > > the boards versus being lax on error checking. > > > > [...] > > > > > >>> @@ -699,10 +698,19 @@ ram_addr_t ppc4xx_sdram_adjust(ram_addr_t ram_size, int nr_banks, > >>> } > >>> } > >>> > >>> - ram_size -= size_left; > >>> if (size_left) { > >>> - error_report("Truncating memory to %" PRId64 " MiB to fit SDRAM" > >>> - " controller limits", ram_size / MiB); > >>> + char *s = g_strdup(""); > >>> + for (i = 0; sdram_bank_sizes[i]; i++) { > >>> + char *t = g_strdup_printf("%s%" PRIi64 "%s", s, sdram_bank_sizes[i], > >>> + sdram_bank_sizes[i + 1] ? " ," : ""); > >>> + g_free(s); > >>> + s = t; > >>> + } > >>> + error_report("Invalid RAM size, unable to fit all RAM into RAM banks" > >>> + " (unassigned RAM: %" PRIi64 ")", size_left); > >>> + error_report("Supported: %d banks and sizes/bank: %s", nr_banks, s); > > > > Do you have any suggestions how to make error message better? > > (maybe do calculation here and dump all valid -m variants instead of "#bank,size/bank") > > Listing the valid values would certainly help users who don't know what > the constraints of the SoC or SPD ROMs are (which I think most users don't > have a clue about and we should not expect them to know). I gave it a shot, in case of bamboo board it ends up with huge ~80 entries list, Perhaps it might be better to avoid combinatorial explosion and keep managable error_report("Supported: %d banks and sizes/bank: %s", nr_banks, s); error_report("Invalid RAM size, unable to fit all RAM into RAM banks" " (unassigned RAM: %" PRIi64 ")", size_left); maybe also print relative to user provided value, nearest valid "above" and "below" sizes, instead of remainder. [...] > > Regards, > BALATON Zoltan >